From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83B32EB64D8 for ; Thu, 22 Jun 2023 10:14:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D1C5B8D0002; Thu, 22 Jun 2023 06:14:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA4E68D0001; Thu, 22 Jun 2023 06:14:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD0128D0002; Thu, 22 Jun 2023 06:14:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 97C3F8D0001 for ; Thu, 22 Jun 2023 06:14:52 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 67E751C8D9C for ; Thu, 22 Jun 2023 10:14:52 +0000 (UTC) X-FDA: 80929975224.13.B355111 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id AC03FA0023 for ; Thu, 22 Jun 2023 10:14:50 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bash4qEo; spf=pass (imf15.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687428890; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7+cabg86v1cYpPv8vDJOW5RfunjhlSEWXfJLwIkmtqs=; b=6x54EC3pzVHog74joBCKBPokGGDiWYgFrzXAkNZ/gKMzSZerGA8OG+I3XGw5Dh1TSk0PQu mvprkMQML6FXrHX6ElUJqyn90bC5gpySIpvKw1+FoH1ecveIQcqnwwFEKXspYLA0P2O4W+ yHvehqEGlstBqeOcO6dqU4i/YqB9QsA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687428890; a=rsa-sha256; cv=none; b=1GuT3QH7pAG46RuZ3/qMUn1ffbeKPAR/TIEZjVT2X2uWn1zSCOp/qT2noNqskQcm0X+td7 crwcqaZvXYyqGEGktJvSOBcs44w2DGT6VSvqBS4BeNEDBJcdYBrPqlkbWVEdPIdVbBeMM9 Cya9aq8VOYA55n5P28x220f9/DsJViU= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bash4qEo; spf=pass (imf15.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E3FA6616CB; Thu, 22 Jun 2023 10:14:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2888C433C9; Thu, 22 Jun 2023 10:14:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687428888; bh=7+cabg86v1cYpPv8vDJOW5RfunjhlSEWXfJLwIkmtqs=; h=Subject:From:To:Date:In-Reply-To:References:From; b=bash4qEoN8ysoF4HTnLUBoIb4R/VvEf+WW/D9VIwZ7IkIbfsRZHAuo5DrHgU3mESQ YV3L6vJlJ5RLoTi5/71VkN5rQAydrP7yy38zcSGGfwasNdQxjqfQEDJO2KhRfaS72P L3pOkZCMNStmacczTh8Bxts4KstAt3iUVQoAzfNq5O0qEkTp/AQ/ZxnvFiOtuM8Rrh hGFigQvIDdzAyY8j4H2gTF58blmQ8XCJxFBrtJ8bp21DHjiO/HINP7f4QOOgCaaZnm wPOh/3PFD9MITyv48Pm3mcErp57QuFgfhsUJhmJROqlUtadgwIZDzlw31/avwVXFpE VwFt0TPP5toFA== Message-ID: Subject: Re: [PATCH 01/79] fs: add ctime accessors infrastructure From: Jeff Layton To: Damien Le Moal , Jeremy Kerr , Arnd Bergmann , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Greg Kroah-Hartman , Arve =?ISO-8859-1?Q?Hj=F8nnev=E5g?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Carlos Llamas , Suren Baghdasaryan , Dennis Dalessandro , Jason Gunthorpe , Leon Romanovsky , Brad Warrum , Ritu Agarwal , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , David Howells , Marc Dionne , Alexander Viro , Ian Kent , Luis de Bethencourt , Salah Triki , "Tigran A. Aivazian" , Eric Biederman , Kees Cook , Chris Mason , Josef Bacik , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Joel Becker , Christoph Hellwig , Nicolas Pitre , "Rafael J. Wysocki" , Tyler Hicks , Ard Biesheuvel , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Richard Weinberger , Anton Ivanov , Johannes Berg , Mikulas Patocka , Mike Kravetz , Muchun Song , David Woodhouse , Dave Kleikamp , Tejun Heo , Trond Myklebust , Anna Schumaker , Chuck Lever , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Mark Fasheh , Joseph Qi , Bob Copeland , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Iurii Zaikin , Tony Luck , "Guilherme G. Piccoli" , Anders Larsen , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Sergey Senozhatsky , Phillip Lougher , Steven Rostedt , Masami Hiramatsu , Evgeniy Dushistov , Hans de Goede , "Darrick J. Wong" , Naohiro Aota , Johannes Thumshirn , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Hugh Dickins , Andrew Morton , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Stephen Smalley , Eric Paris , Juergen Gross , Ruihan Li , Laurent Pinchart , Wolfram Sang , Udipto Goswami , Linyu Yuan , John Keeping , Andrzej Pietrasiewicz , Dan Carpenter , Yuta Hayama , Jozef Martiniak , Jens Axboe , Alan Stern , Sandeep Dhavale , Dave Chinner , Johannes Weiner , ZhangPeng , Viacheslav Dubeyko , Tetsuo Handa , Aditya Garg , Erez Zadok , Yifei Liu , Yu Zhe , "Matthew Wilcox (Oracle)" , Oleg Kanatov , "Dr. David Alan Gilbert" , Jiangshan Yi , xu xin , Stefan Roesch , Zhihao Cheng , "Liam R. Howlett" , Alexey Dobriyan , Minghao Chi , Seth Forshee , Zeng Jingxiang , Bart Van Assche , Mimi Zohar , Roberto Sassu , Zhang Yi , Tom Rix , "Fabio M. De Francesco" , Chen Zhongjin , Zhengchao Shao , Rik van Riel , Jingyu Wang , Hangyu Hua , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org, linux-usb@vger.kernel.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, autofs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-efi@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-um@lists.infradead.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, ocfs2-devel@oss.oracle.com, linux-karma-devel@lists.sourceforge.net, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, linux-hardening@vger.kernel.org, reiserfs-devel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, selinux@vger.kernel.org Date: Thu, 22 Jun 2023 06:14:30 -0400 In-Reply-To: <99b3c749-23d9-6f09-fb75-6a84f3d1b066@kernel.org> References: <20230621144507.55591-1-jlayton@kernel.org> <20230621144507.55591-2-jlayton@kernel.org> <99b3c749-23d9-6f09-fb75-6a84f3d1b066@kernel.org> Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.3 (3.48.3-1.fc38) MIME-Version: 1.0 X-Rspamd-Queue-Id: AC03FA0023 X-Rspam-User: X-Stat-Signature: b5fd4rw95haaiiy9kbgnu9qepepibm6t X-Rspamd-Server: rspam03 X-HE-Tag: 1687428890-877199 X-HE-Meta: U2FsdGVkX1+5z5xMKDT36WmfBSmiNbP0+kzfcKN9e1wmjXvk0/aQRiTdxUdtaFEfjle0AmbAf7GNNtN3iDXWieJTroUAS6MLZ5vvNIyOnl47gebm1Do53UW+G2lEkXa3xwPPwEmu/QRwKoKNu03DVN8OaTD2UGLkyNAwVrND5ifA5dJMNwQxsGnXsHnQ4UKRoyOTJuHjHWcD1rP3LLV1/MDzvnpXEzsNDzYIm4kk7D4Bi1ozbeH9FYu18CP5rlo6NU5a4DvKVFMgtC4xTO8r4wM2TufmdGALp52HYA6ZwRbQOfGZTAGkaDnZPqtRsAGLVCJJukTZH1gJWYy4Dx7b3zBBg1cPowym9P+OuQyBbcb0gaxAhWrDT9ktGtPijIAINirDeNo5rdJ2oxvaFyMPgEdOas/jwX5kQooWNkRuJI8yevpRWaNY9JDcL29HnEtyQFoAtvVzfsoyW39hr113tgmL4ALihu5ZLFURK5oO8O9D9yECJNYH+4HHPy0E092zyYVroO3GCCTdYqiLg6dzf57wYwZPPHphiUfifiUoPjdobl1onDQziBGThSWSlYPnvSoabYPJx/GHMG1k8/YFcp2nXxSWNAVf2LtyWZOaJOI2VyYNujPw59yWBpugmzwm5srxbdDR3gk+NSg9ztv25JfQxOyv+5B8t1bOxeiE607028KW3K/6PJJQY2lESIfuYRwX670WtHIFOYN8TH7Y+K5f2P+WdoLY/2Ec4P39IdwYOdCH+lq7tBCD40iGUUDajdidq5ADvsH/CMV4hYfj6/u/gbBkYhb2KOgM9S88QsSMjGgIcAIpt/igE/v5fSJSJdSN1ZROG+DVNdsrsB0DQC3pok5BUwpYD7i1uVDRLZdlmrYMBAYhnTQzWi6+7EejZ53FYMxu/XOppwbW2bEZ3lQJul65cn0sfH7CaIma6BrlltfGujmyiCwIKIf60qCHaH6IOU7K87msvlaNpGT MNf7AUFt 8poWwRlZrdwHcnHG8yCGiF+PioXNrympqXltNoOl0UhPGiA2JFMf1yQT3c2Z49eMJ7H0gKonWWpgQF7gKuWwN79yaI/ePQYdA5NIlVce+3IKZcJzcOVsDCI8uNWjUUesOZZi8BoULvFUSDWq5W8pKk23wU4+4B5BDmd4Koiugz6HQ7T0BhcYs/9v2noI14kFb+wI/H8jsM4uRagW0Q2Awj+ffp1nOE9gYkKUQEiotyXD8GBMvybnn0W8Ds49mbkGgGd4uhGfjCCui/qJoCxJLRT77/DgbNaQfb6NPLqqjLLaCQE3YOsbklUPtUKPceq4dQUH6oqNN4K0sidRwDMGUEidphMuY19qtpQouLll2+m41P/qIDo390fHfEv+6SPu03TDBdstpCo4OdUpUkfT6k3Zg4L9LVWCFOsjz2xlylPSg8PMP+mZtr6HQtePz+7ybN/KIujLXHVDyqr1GRydY6K8VT5CuWd2L5qHaPDWYNQsWwqR0FNhMqXcKApJO785eFG5df+IkXsUTshwAiLFpCbv/4LaWRM43TCVZYz+vRsNuXoB8kElWwNMy40JVKRAw5SHR1Z42xI7GtBZxnzGpiIxbSlwSEnwAFuAWpAJ8sMSo6blL65T7Tx5ttt61+67v81O8EFrzPqqm0A5h9ZhbmVyP+gXTtUNXEnhpv7ZNvO4EUD/FgoY/cAr6+XJ18YtivtMP7gv6GddbNaRhD6a7zvFXF310fUHWeeO7AePkceC2mmTs6oODi+wC+Tm74gIp+BraBT6WEtMmAJD24bfrXujI5lVILWDmwS+4ONogfw132u3PYROwEbIsyeeivNS1O/95zdCirtQRvy3PJgch/es/75+W+AnfiU+fg12fkYUVN+nS4RV7ieFBz227jxSW5oKj6YPKdikakVotppMEna0RAXv344RnAfupQXRA7geTxlbZxYCnMeZYMezOTq7U98UJT5GK3tdBCdDDB63Mys5GkEZ8 cz0efhvw hfKOfm3Ja72Ms7cNcNa+F3V3bfjG30/kaMFxrgimQscRqfSZlpHtJjWql62KvaDMiGGE/d5goIhkUNjKUR+4xtfmhY0iYGdDUrrCMi+DbQxLNG3xZvK4bKP0KMVMMAf6EgTda5TM+ZehTJ5KL0Xt8GAQUu20CX5MSHt/37LLouSRmqUR2WYkiLe8dcUdr2zzNdA325KkSgZRoC8egK94nhyN0i5G53LOli8V35k9YEN7Uf2rjpFyKdv0YNBJnsuJATq4JOF/jKsNayI6jMPkd/EVg2B2xtR5RPjk7u27N9DEJlwaBqp/QaWRS89Td9bfw364uLsHiUX+qOueKdPtdL3jjtysuOZfsJmQwc4wyT1UcbQvjmFCljqB+/yOV1nn7b7cKzCBgaO9xWXd4KuaFg8O6gkkYxtw5zXs0HME6ihhnp8qPbLatKbCGjVgRfatRnupMNLXuKp+CEF+XyNoLumcEbaByRemDRAEVEv9IgclLV+OaAsR6lq9cfyQCotXgcCwWu08GAD2RqInV8oG8pdq+0N+vRLY6GaRspmvAmx4vkHhErJWUGAtK5paK7PcFTVKsct61sRPkMAaLDfwlnOQ2GoksIknAS2Kyr8g2e+twtH2LA8fSsHMjjcFDq8sQkQPyo2EZcE9vflX0a7P2fjEnb28mO6a+LaN8syqny5nGpnL094nOaJn1dD93Z1jPf0ajJAPX55USl+8194R4PUxf4G52LuGYNUR/+7KMDuwPYiX6z8yQnCoBFwfjBwdZOqbByHdAdlAX4IM3lrgQuZvTwOT6Qu43dS0XJzW8f+6eRZBpkHKnzRw876oT7kXWpeLjJ1MMRef9yJIx09ahx3T2EP5EJSwFnEjdsLeV49urAvQ98k3ST+QjRGULqt6Eptn4Y99pmagOT7lWsiOmrTB0Vz034Bq1VckOLiP4Y9ZFP0NlK+pH6FCP0tT9FJsyXPkIcPAFE2jQAKR8KzVjAPmDbzaC CpPFJ2QR 2I4MCpJNPw+w6kI6yLeIhK8Fes8/8ORWg1Ta14JQALCw8Y1yuP/y9WhJALsnZ/fVQ4QtAYdT9wxalQlv46yUY9q+fnDjU4n3qUEALdy5rx8sjU21bWB8NVfGUloJMIQ00fkk/NpqOvlH6VbAxP1TRTCqS64tNCLgtwAUdJQ7/6WGr99cqZvgBxnMZKFrvF9QXq03sUVDT1CpKwaohMaO+JTa5q1xH5bPjuvJBj1kbVkuW39eE+hILrvKJoVeS6LnhJHH+mrJhtJaiIHBqbOfYL0f0ZYuorsJglOyRB/6rZ0ZkFeD3QzHcLURROROuJ8iSoEQ3fIBzRrG3qE+n4c9aKzlFgTwoIrMByhzWXbY9Uar6ixAcnh72pmlpHFPzZztY52F6Kdo7sRUY4dpKTWu0k36l18DCoOZg3zwbAXheP3FKcMGDWphIu0Gs0gixPOEQhLM7UJH993BI0JFPLRyktJGUDCOjUQFhhfCeZzHAiN3W6d1M1sImyWqj11PktpfHTx372M5+7sRpE+dM2Ic4cVY4P4iTXSRFV4/K9s6OzX2tkDq/4GJGljQ1jkig2iowqi6nQwafDOrnfvX70XQUqzXqMZ43mGmAq+nJJle/kjzMgYMk7j5RbTh4fkB+udNDixR4z361OqWGcttwq70LynLhzBdDQ2PSaLOjbNenwP0bFeZRf3GL0+L1sd7USJwBQmgBe9t6wRgbaNDQIhD4/rXRjVoXwHusya9uTU8bOIjjtQ8MunwIPk4ax74dItPt3uIL5pjgK9CRvAi+3nxjYgNYYW1X7ABrZB07UQRBae7OsRfXDA0uJ+Nb6e/51DOM6DEkBVoFhJOLlt40VgRkTRg4U6EDlLb4EbKoPOlyJrrpQ84sUtxiWpCOc1WpccVxff/3yZaVCsbLqbV7TpP1G5uobAJ8nlcoOMcHf6A+5m/7fFRknYOrt5ThYIibNF67I5lYj+xzTHhC5meVHhrccDKDstaC KC5ANTcy iBkSrjlt+nxJen+Z5i9w82C3lPhO9J/52Vu/zhc6BCxeHOdqns8J1gS0hmW0PiHVPLY+IA65ZqtvUSbSq30u0M7H/sbm2JWjYel8luuyHEeDqAAW4nxdvKrROfoBjxyFEj4vxqZRhWMHrD57q0y+Adqc9oM0KBw+eVhXhzsxJaaTWkZ2D/Kp5N5ABbkxMKKDRKxTra2F0Li4JBmBen9u2aiYxpduHEuKKach4532yvQ+engawO/8KjoqqOmXGoEbkbD27yhKpymgyFGjm80/ECljVNkq/uLujt11uU3J2YC/uG0sotrQVc/OjB2SPEH+5XcRXMVGUrb9kKpa4MGu2+wfX4sO2kdD0FiarcGVMxhWUDt+CyvLN2E/ribJzuiujPu2DN8Khgsg+OoAp+WgywT2Hzzl+0RE29hyl8J03PtAInDej8VHoBBLJCgY4YWLw3WfOagBpnrb7Wsr1KCZh6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 2023-06-22 at 09:46 +0900, Damien Le Moal wrote: > On 6/21/23 23:45, Jeff Layton wrote: > > struct timespec64 has unused bits in the tv_nsec field that can be used > > for other purposes. In future patches, we're going to change how the > > inode->i_ctime is accessed in certain inodes in order to make use of > > them. In order to do that safely though, we'll need to eradicate raw > > accesses of the inode->i_ctime field from the kernel. > >=20 > > Add new accessor functions for the ctime that we can use to replace the= m. > >=20 > > Signed-off-by: Jeff Layton >=20 > [...] >=20 > > +/** > > + * inode_ctime_peek - fetch the current ctime from the inode > > + * @inode: inode from which to fetch ctime > > + * > > + * Grab the current ctime from the inode and return it. > > + */ > > +static inline struct timespec64 inode_ctime_peek(const struct inode *i= node) >=20 > To be consistent with inode_ctime_set(), why not call this one inode_ctim= e_get() In later patches fetching the ctime for presentation may have side effects on certain filesystems. Using "peek" here is a hint that we want to avoid those side effects in these calls. > ? Also, inode_set_ctime() & inode_get_ctime() may be a little more natura= l. But > no strong opinion about that though. >=20 I like the consistency of the inode_ctime_* prefix. It makes it simpler to find these calls when grepping, etc. That said, my opinions on naming are pretty loosely-held, so if the consensus is that the names should as you suggest, I'll go along with it. --=20 Jeff Layton