From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx161.postini.com [74.125.245.161]) by kanga.kvack.org (Postfix) with SMTP id 4C3A46B0044 for ; Mon, 6 Aug 2012 12:10:53 -0400 (EDT) MIME-Version: 1.0 Message-ID: Date: Mon, 6 Aug 2012 09:10:26 -0700 (PDT) From: Dan Magenheimer Subject: RE: [RFC/PATCH] zcache/ramster rewrite and promotion References: In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: Pekka Enberg Cc: Seth Jennings , Konrad Wilk , Minchan Kim , Nitin Gupta , Andrew Morton , Robert Jennings , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org > From: Pekka Enberg [mailto:penberg@kernel.org] > Subject: Re: [RFC/PATCH] zcache/ramster rewrite and promotion >=20 > On Mon, Aug 6, 2012 at 5:07 PM, Dan Magenheimer > wrote: > > I'm OK with placing it wherever kernel developers want to put > > it, as long as the reason is not NIMBY-ness. [1] My preference > > is to keep all the parts together, at least for the review phase, > > but if there is a consensus that it belongs someplace else, > > I will be happy to move it. >=20 > I'd go for core code in mm/zcache.c and mm/ramster.c, and move the > clustering code under net/ramster or drivers/ramster. Hi Pekka -- Thanks for the quick feedback! Hmmm.. there's also zbud.c and tmem.c which are critical components of both zcache and ramster. And there are header files as well which will need to either be in mm/ or somewhere in include/linux/ Is there a reason or rule that mm/ can't have subdirectories? Since zcache has at least three .c files plus ramster.c, and since mm/frontswap.c and mm/cleancache.c are the foundation on which all of these are built, I was thinking grouping all six (plus headers) in the same mm/tmem/ subdirectory was a good way to keep mm/ from continuing to get more cluttered... not counting new zcache and ramster files, there are now 74 .c files in mm/! (Personally, I think a directory has too many files in it if "ls" doesn't fit in a 25x80 window.) Thoughts? Dan -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org