From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 856B9CCD183 for ; Thu, 16 Oct 2025 16:15:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DFF5C8E0021; Thu, 16 Oct 2025 12:15:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DD6DB8E0002; Thu, 16 Oct 2025 12:15:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CECC08E0021; Thu, 16 Oct 2025 12:15:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BE8988E0002 for ; Thu, 16 Oct 2025 12:15:35 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6A320C0365 for ; Thu, 16 Oct 2025 16:15:35 +0000 (UTC) X-FDA: 84004477830.09.6E1DDB9 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf22.hostedemail.com (Postfix) with ESMTP id 0274DC0014 for ; Thu, 16 Oct 2025 16:15:32 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qVuEo+l9; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=5+wqPiVD; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qVuEo+l9; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=5+wqPiVD; dmarc=none; spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1760631333; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Uz/Ghx4FHi2vcXr5rnmAHNkktOBn1Zpc/YuwEV6tR7E=; b=3i0yLh4BqLGwNzGn1u6Qxojnx/tqwXQ+IelxlQMNPG6jfRXl75y3JJ2SFfbgcw+hghmn68 4UIh0GVHfF/IgmNhdfZK/q51A+F3AwURwTh+kVca4Vvz1YPk0yiTJffPnHjgnu59o61cre mI7hZotttgH3INKZ8DeRA3Q4bhememA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1760631333; a=rsa-sha256; cv=none; b=FSQTf1P/H9tm3O1n4tYGSy+9l8b3Eo0SdxUkLRcBJ23rpW+UAeq42I2lPDVdIzYvg0yW6Z RKrK8yDaSAhY359fhiug2PLKtmNH/bvXi5ACcsrd3Z7EOgNfEREdpq2S56zsDtSeRvdKTO iFhBMJgj3hYH6G3bMP0kLyHxN+xInS8= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qVuEo+l9; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=5+wqPiVD; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qVuEo+l9; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=5+wqPiVD; dmarc=none; spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1C46A21B2E; Thu, 16 Oct 2025 16:15:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1760631331; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Uz/Ghx4FHi2vcXr5rnmAHNkktOBn1Zpc/YuwEV6tR7E=; b=qVuEo+l9XL8knKBUcMrbHu3Qnt2Ya4jJGdyykHRDM1veCaywo8UErcmfRmZZxWYgCga0yd F4WBu7/nX30YdMORpcGS1Yfe8V1YcvsolIb4gwYeUTqtD2bbqwDoSgyId+0tbZgOVsSrxt uMIew4+P4a4FAA6ibTwddKXLmqQ/iQQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1760631331; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Uz/Ghx4FHi2vcXr5rnmAHNkktOBn1Zpc/YuwEV6tR7E=; b=5+wqPiVD4LQto9VFMKpADBXaLhebDVW5DbLUVRsx1YSD6cDQ9XUBWE/Q7DG3WK9VLFjCvH Vffft9PSx5FAsMAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1760631331; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Uz/Ghx4FHi2vcXr5rnmAHNkktOBn1Zpc/YuwEV6tR7E=; b=qVuEo+l9XL8knKBUcMrbHu3Qnt2Ya4jJGdyykHRDM1veCaywo8UErcmfRmZZxWYgCga0yd F4WBu7/nX30YdMORpcGS1Yfe8V1YcvsolIb4gwYeUTqtD2bbqwDoSgyId+0tbZgOVsSrxt uMIew4+P4a4FAA6ibTwddKXLmqQ/iQQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1760631331; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Uz/Ghx4FHi2vcXr5rnmAHNkktOBn1Zpc/YuwEV6tR7E=; b=5+wqPiVD4LQto9VFMKpADBXaLhebDVW5DbLUVRsx1YSD6cDQ9XUBWE/Q7DG3WK9VLFjCvH Vffft9PSx5FAsMAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id EDC7C1376E; Thu, 16 Oct 2025 16:15:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id FwK6OSIa8Wh2agAAD6G6ig (envelope-from ); Thu, 16 Oct 2025 16:15:30 +0000 Message-ID: Date: Thu, 16 Oct 2025 18:15:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 15/23] maple_tree: use percpu sheaves for maple_node_cache Content-Language: en-US To: "D, Suneeth" , Suren Baghdasaryan , "Liam R. Howlett" , Christoph Lameter , David Rientjes Cc: Roman Gushchin , Harry Yoo , Uladzislau Rezki , Sidhartha Kumar , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rcu@vger.kernel.org, maple-tree@lists.infradead.org References: <20250910-slub-percpu-caches-v8-0-ca3099d8352c@suse.cz> <20250910-slub-percpu-caches-v8-15-ca3099d8352c@suse.cz> <262c742f-dc0c-4adc-b23c-047cd3298a5e@amd.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: <262c742f-dc0c-4adc-b23c-047cd3298a5e@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Stat-Signature: aq8wgnrgsk1us61nporux7rxop54p49t X-Rspam-User: X-Rspamd-Queue-Id: 0274DC0014 X-HE-Tag: 1760631332-693512 X-HE-Meta: U2FsdGVkX19tcrFPsttkTcLw/7fFjnahyN0NTLrxWGpb971uTZsdrinfRjNKaMOcpLU+VdPh2ISIuZu+xMNc8Rf+OpiXWrM1ie/+Bo4Qq4DUxtor/7YyntRaEPheSEIqL6+8M31hREQFUp9A/amITzwcvHzk44bNbvzrbGd+SA13Uc2AQWW/Gx/xrPW2N94V+wnsTdOxsmNKZFy/mh7EPcDdMgPl59RDaZ/mDyTGiRw6hHXtbqi32yNUDhYplhkXI5ZusrGa+hJg5Hcrnz00RFTq5jy32XDr8Is1gIl0nXChi8OgbJtlV9ycgXFUMQektaE1INqQ22m1uSGnU9CtvPFqUnqqPHacFVUCYf7IdBFi8Pg5QvgeFd2pRVC8Tec5NXWAeYEj8aB72vY2VtfYrtK4/yxBB+JXq7Ci7t+Uch4vx4hfYCJbKr+F672BP9bGL3Eo19TzJDLk9w/3iVmvDXuKNIHhj1z2QIeksTqkwbHQUEcbEMFgj+2NA6ve/CFxwoJuk7FKH18WIANvxtaAFmPb7M62dc/dKU5a8PKOd1eWaTzmV1loX5gTLcnEcRFnT5iNy8YbaCTYFcLvES/JHc4+V/F1Sqbuv/TJa2XVwXGCnLkUzKH0aNzvvkE1D9aR6Y8gRhbjssYsrzQSFMox3NZPBd5EtE+lK5+qt8oQ3tCt+YYQ8EQpMR8ewZRjCl1Z29zJHy9vUv4J7Pp4rf4hry5xkMt/2lFh0204wU+0SgwaGdynCoX19jmra9U6QqAxQP3ePreJrxa0ra66208EyHfhtvXOeydSm7n2qRa7wbJntsrmxrEvgFICuhTmTqrIr0jKNo9TSjZVd1bV02aNu8Ok860CY19H79JQ/cG+Jx7K4Zn33OsqbH+p1w5QmZGYfsCzxWekXde3jG2L957L+Bp36tUkwxxtGg7BpL7PqpgIeO3jKnhndnGXFDf+O0J5hRwngfF0U35AKja+4Fc N6dS8hA2 82t1qQBv0vAoakW8HsaTE9+jNqLxv4t/W2oJyccTZCq1GgCrdFLqs5mJnR51u2hEh8sRIVdt/E5IOiLvAv2nScJsQgn4vkXylj4yBQb62WSURxruMjUrdHkME8ufK0ZeQM5JOrjNHlen3R5e0bAoHVLDwE/AsnQxs1Kccwk4FC8dRfOK9NomXKRRWVfMrlTzaBm9Vcu8MdewRHmRQJanA1PzvE/g2j/5qkS84GGq+RBLFenh5/tN9CTo8hsCHfMPJGyIl+PS0NVs2M6JfZi1V6i6J+ojGK3olnnqrNnxTDGm3Hote+kpIJnzosbPVqMqPPUPBrGZw39qxZlfNZm+lSf4UHZGT7TTnhx+vo90FyN+X4KWIJpXMM7aJCHWHhsLSt0bPf9l3xYknSxYF142H9dP9EA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/16/25 17:16, D, Suneeth wrote: > Hi Vlastimil Babka, > > On 9/10/2025 1:31 PM, Vlastimil Babka wrote: >> Setup the maple_node_cache with percpu sheaves of size 32 to hopefully >> improve its performance. Note this will not immediately take advantage >> of sheaf batching of kfree_rcu() operations due to the maple tree using >> call_rcu with custom callbacks. The followup changes to maple tree will >> change that and also make use of the prefilled sheaves functionality. >> > > > We run will-it-scale-process-mmap2 micro-benchmark as part of our weekly > CI for Kernel Performance Regression testing between a stable vs rc > kernel. In this week's run we were able to observe severe regression on > AMD platforms (Turin and Bergamo) with running the micro-benchmark > between the kernels v6.17 and v6.18-rc1 in the range of 12-13% (Turin) > and 22-26% (Bergamo). Bisecting further landed me onto this commit > (59faa4da7cd4565cbce25358495556b75bb37022) as first bad commit. The > following were the machines' configuration and test parameters used:- > > Model name: AMD EPYC 128-Core Processor [Bergamo] > Thread(s) per core: 2 > Core(s) per socket: 128 > Socket(s): 1 > Total online memory: 258G > > Model name: AMD EPYC 64-Core Processor [Turin] > Thread(s) per core: 2 > Core(s) per socket: 64 > Socket(s): 1 > Total online memory: 258G > > Test params: > > nr_task: [1 8 64 128 192 256] > mode: process > test: mmap2 > kpi: per_process_ops > cpufreq_governor: performance > > The following are the stats after bisection:- > (the KPI used here is per_process_ops) > > kernel_versions per_process_ops > --------------- --------------- > v6.17.0 - 258291 > v6.18.0-rc1 - 225839 > v6.17.0-rc3-59faa4da7 - 212152 > v6.17.0-rc3-3accabda4da1(one commit before bad commit) - 265054 Thanks for the info. Is there any difference if you increase the sheaf_capacity in the commit from 32 to a higher value? For example 120 to match what the automatically calculated cpu partial slabs target would be. I think there's a lock contention on the barn lock causing the regression. By matching the cpu partial slabs value we should have same batching factor for the barn lock as there would be on the node list_lock before sheaves. Thanks. > Recreation steps: > > 1) git clone https://github.com/antonblanchard/will-it-scale.git > 2) git clone https://github.com/intel/lkp-tests.git > 3) cd will-it-scale && git apply > lkp-tests/programs/will-it-scale/pkg/will-it-scale.patch > 4) make > 5) python3 runtest.py mmap2 25 process 0 0 1 8 64 128 192 256 > > NOTE: [5] is specific to machine's architecture. starting from 1 is the > array of no.of tasks that you'd wish to run the testcase which here is > no.cores per CCX, per NUMA node/ per Socket, nr_threads. > > I also ran the micro-benchmark with tools/testing/perf record and > following is the collected data:- > > # perf diff perf.data.old perf.data > No kallsyms or vmlinux with build-id > 0fc9c7b62ade1502af5d6a060914732523f367ef was found > Warning: > 43 out of order events recorded. > Warning: > 54 out of order events recorded. > # Event 'cycles:P' > # > # Baseline Delta Abs Shared Object Symbol > # ........ ......... ...................... > .............................................. > # > +51.51% [kernel.kallsyms] [k] > native_queued_spin_lock_slowpath > +14.39% [kernel.kallsyms] [k] perf_iterate_ctx > +2.52% [kernel.kallsyms] [k] unmap_page_range > +1.75% [kernel.kallsyms] [k] mas_wr_node_store > +1.47% [kernel.kallsyms] [k] __pi_memset > +1.38% [kernel.kallsyms] [k] mt_free_rcu > +1.36% [kernel.kallsyms] [k] free_pgd_range > +1.10% [kernel.kallsyms] [k] __pi_memcpy > +0.96% [kernel.kallsyms] [k] __kmem_cache_alloc_bulk > +0.92% [kernel.kallsyms] [k] __mmap_region > +0.79% [kernel.kallsyms] [k] mas_empty_area_rev > +0.74% [kernel.kallsyms] [k] __cond_resched > +0.73% [kernel.kallsyms] [k] mas_walk > +0.59% [kernel.kallsyms] [k] mas_pop_node > +0.57% [kernel.kallsyms] [k] perf_event_mmap_output > +0.49% [kernel.kallsyms] [k] mas_find > +0.48% [kernel.kallsyms] [k] mas_next_slot > +0.46% [kernel.kallsyms] [k] kmem_cache_free > +0.42% [kernel.kallsyms] [k] mas_leaf_max_gap > +0.42% [kernel.kallsyms] [k] > __call_rcu_common.constprop.0 > +0.39% [kernel.kallsyms] [k] entry_SYSCALL_64 > +0.38% [kernel.kallsyms] [k] mas_prev_slot > +0.38% [kernel.kallsyms] [k] kmem_cache_alloc_noprof > +0.37% [kernel.kallsyms] [k] mas_store_gfp > > >> Reviewed-by: Sidhartha Kumar >> Reviewed-by: Suren Baghdasaryan >> Signed-off-by: Vlastimil Babka >> --- >> lib/maple_tree.c | 9 +++++++-- >> 1 file changed, 7 insertions(+), 2 deletions(-) >> >> diff --git a/lib/maple_tree.c b/lib/maple_tree.c >> index 4f0e30b57b0cef9e5cf791f3f64f5898752db402..d034f170ac897341b40cfd050b6aee86b6d2cf60 100644 >> --- a/lib/maple_tree.c >> +++ b/lib/maple_tree.c >> @@ -6040,9 +6040,14 @@ bool mas_nomem(struct ma_state *mas, gfp_t gfp) >> >> void __init maple_tree_init(void) >> { >> + struct kmem_cache_args args = { >> + .align = sizeof(struct maple_node), >> + .sheaf_capacity = 32, >> + }; >> + >> maple_node_cache = kmem_cache_create("maple_node", >> - sizeof(struct maple_node), sizeof(struct maple_node), >> - SLAB_PANIC, NULL); >> + sizeof(struct maple_node), &args, >> + SLAB_PANIC); >> } >> >> /** >> > > --- > Thanks and Regards > Suneeth D >