From: Lorenzo Stoakes <ljs@kernel.org>
To: "Liam R. Howlett" <Liam.Howlett@oracle.com>,
"Anand Moon" <linux.amoon@gmail.com>,
"David Howells" <dhowells@redhat.com>,
"David Woodhouse" <dwmw2@infradead.org>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Christian Brauner" <brauner@kernel.org>,
"Jan Kara" <jack@suse.cz>,
"Andrew Morton" <akpm@linux-foundation.org>,
"David Hildenbrand" <david@kernel.org>,
"Vlastimil Babka" <vbabka@kernel.org>,
"Mike Rapoport" <rppt@kernel.org>,
"Suren Baghdasaryan" <surenb@google.com>,
"Michal Hocko" <mhocko@suse.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Kees Cook" <kees@kernel.org>,
"Thomas Gleixner" <tglx@kernel.org>,
"Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
"Douglas Anderson" <dianders@chromium.org>,
"Shakeel Butt" <shakeel.butt@linux.dev>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Masahiro Yamada" <masahiroy@kernel.org>,
"open list:CERTIFICATE HANDLING" <keyrings@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:FILESYSTEMS (VFS and infrastructure)"
<linux-fsdevel@vger.kernel.org>,
"open list:MEMORY MANAGEMENT - CORE" <linux-mm@kvack.org>
Subject: Re: [PATCH v1] treewide: Fix indentation and whitespace in Kconfig files
Date: Tue, 7 Apr 2026 15:37:36 +0100 [thread overview]
Message-ID: <adUWbw60LyIMaDKg@lucifer> (raw)
In-Reply-To: <2w7il2oprhkus5eyuxj3alzlsstp4yv23gazmxfmofzikqllrh@uwsx5nbj2hwv>
On Tue, Apr 07, 2026 at 09:58:56AM -0400, Liam R. Howlett wrote:
> * Anand Moon <linux.amoon@gmail.com> [260407 01:40]:
> > Clean up inconsistent indentation (mixing tabs and spaces) and remove
> > extraneous whitespace in several Kconfig files across the tree.
> > This is a purely cosmetic change to improve readability.
> >
> > Adjust indentation from spaces to tab (+optional two spaces) as in
> > coding style with command like:
> >
> > $ sed -e 's/^ /\t/' -i */Kconfig
> >
> > Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>
> For the mm section,
>
> Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>
Looks correct to me for mm also, so:
Reviewed-by: Lorenzo Stoakes <ljs@kernel.org>
Cheers, Lorenzo
>
> > ---
> > certs/Kconfig | 16 ++++++++--------
> > fs/Kconfig | 6 +++---
> > init/Kconfig | 24 ++++++++++++------------
> > lib/Kconfig | 2 +-
> > mm/Kconfig | 4 ++--
> > 5 files changed, 26 insertions(+), 26 deletions(-)
> >
> > diff --git a/certs/Kconfig b/certs/Kconfig
> > index 8e39a80c7abe5..9d2bf7fb5b9e4 100644
> > --- a/certs/Kconfig
> > +++ b/certs/Kconfig
> > @@ -6,14 +6,14 @@ config MODULE_SIG_KEY
> > default "certs/signing_key.pem"
> > depends on MODULE_SIG || (IMA_APPRAISE_MODSIG && MODULES)
> > help
> > - Provide the file name of a private key/certificate in PEM format,
> > - or a PKCS#11 URI according to RFC7512. The file should contain, or
> > - the URI should identify, both the certificate and its corresponding
> > - private key.
> > -
> > - If this option is unchanged from its default "certs/signing_key.pem",
> > - then the kernel will automatically generate the private key and
> > - certificate as described in Documentation/admin-guide/module-signing.rst
> > + Provide the file name of a private key/certificate in PEM format,
> > + or a PKCS#11 URI according to RFC7512. The file should contain, or
> > + the URI should identify, both the certificate and its corresponding
> > + private key.
> > +
> > + If this option is unchanged from its default "certs/signing_key.pem",
> > + then the kernel will automatically generate the private key and
> > + certificate as described in Documentation/admin-guide/module-signing.rst
> >
> > choice
> > prompt "Type of module signing key to be generated"
> > diff --git a/fs/Kconfig b/fs/Kconfig
> > index 0bfdaecaa8775..74110311968aa 100644
> > --- a/fs/Kconfig
> > +++ b/fs/Kconfig
> > @@ -78,7 +78,7 @@ config FS_DAX
> > --map=mem:
> > https://docs.pmem.io/ndctl-user-guide/ndctl-man-pages/ndctl-create-namespace
> >
> > - For ndctl to work CONFIG_DEV_DAX needs to be enabled as well. For most
> > + For ndctl to work CONFIG_DEV_DAX needs to be enabled as well. For most
> > file systems DAX support needs to be manually enabled globally or
> > per-inode using a mount option as well. See the file documentation in
> > Documentation/filesystems/dax.rst for details.
> > @@ -116,8 +116,8 @@ config FILE_LOCKING
> > default y
> > help
> > This option enables standard file locking support, required
> > - for filesystems like NFS and for the flock() system
> > - call. Disabling this option saves about 11k.
> > + for filesystems like NFS and for the flock() system
> > + call. Disabling this option saves about 11k.
> >
> > source "fs/crypto/Kconfig"
> >
> > diff --git a/init/Kconfig b/init/Kconfig
> > index 7484cd703bc1a..6fea1453c2941 100644
> > --- a/init/Kconfig
> > +++ b/init/Kconfig
> > @@ -1036,14 +1036,14 @@ config PAGE_COUNTER
> > bool
> >
> > config CGROUP_FAVOR_DYNMODS
> > - bool "Favor dynamic modification latency reduction by default"
> > - help
> > - This option enables the "favordynmods" mount option by default
> > - which reduces the latencies of dynamic cgroup modifications such
> > - as task migrations and controller on/offs at the cost of making
> > - hot path operations such as forks and exits more expensive.
> > + bool "Favor dynamic modification latency reduction by default"
> > + help
> > + This option enables the "favordynmods" mount option by default
> > + which reduces the latencies of dynamic cgroup modifications such
> > + as task migrations and controller on/offs at the cost of making
> > + hot path operations such as forks and exits more expensive.
> >
> > - Say N if unsure.
> > + Say N if unsure.
> >
> > config MEMCG
> > bool "Memory controller"
> > @@ -1125,7 +1125,7 @@ config GROUP_SCHED_WEIGHT
> > def_bool n
> >
> > config GROUP_SCHED_BANDWIDTH
> > - def_bool n
> > + def_bool n
> >
> > config FAIR_GROUP_SCHED
> > bool "Group scheduling for SCHED_OTHER"
> > @@ -1625,10 +1625,10 @@ config LD_ORPHAN_WARN
> > depends on $(ld-option,--orphan-handling=error)
> >
> > config LD_ORPHAN_WARN_LEVEL
> > - string
> > - depends on LD_ORPHAN_WARN
> > - default "error" if WERROR
> > - default "warn"
> > + string
> > + depends on LD_ORPHAN_WARN
> > + default "error" if WERROR
> > + default "warn"
> >
> > config SYSCTL
> > bool
> > diff --git a/lib/Kconfig b/lib/Kconfig
> > index 0f2fb96106476..4b0026954a370 100644
> > --- a/lib/Kconfig
> > +++ b/lib/Kconfig
> > @@ -589,7 +589,7 @@ config OBJAGG
> > config LWQ_TEST
> > bool "Boot-time test for lwq queuing"
> > help
> > - Run boot-time test of light-weight queuing.
> > + Run boot-time test of light-weight queuing.
> >
> > endmenu
> >
> > diff --git a/mm/Kconfig b/mm/Kconfig
> > index ebd8ea353687e..10a4ce4247fa1 100644
> > --- a/mm/Kconfig
> > +++ b/mm/Kconfig
> > @@ -1304,7 +1304,7 @@ config ARCH_HAS_PTE_SPECIAL
> > bool
> >
> > config MAPPING_DIRTY_HELPERS
> > - bool
> > + bool
> >
> > config KMAP_LOCAL
> > bool
> > @@ -1435,7 +1435,7 @@ config ARCH_HAS_USER_SHADOW_STACK
> > bool
> > help
> > The architecture has hardware support for userspace shadow call
> > - stacks (eg, x86 CET, arm64 GCS or RISC-V Zicfiss).
> > + stacks (eg, x86 CET, arm64 GCS or RISC-V Zicfiss).
> >
> > config HAVE_ARCH_TLB_REMOVE_TABLE
> > def_bool n
> >
> > base-commit: bfe62a454542cfad3379f6ef5680b125f41e20f4
> > --
> > 2.50.1
> >
prev parent reply other threads:[~2026-04-07 14:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 5:39 [PATCH v1] treewide: Fix indentation and whitespace in Kconfig files Anand Moon
2026-04-07 11:01 ` Jan Kara
2026-04-07 13:58 ` Liam R. Howlett
2026-04-07 14:37 ` Lorenzo Stoakes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adUWbw60LyIMaDKg@lucifer \
--to=ljs@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=david@kernel.org \
--cc=dhowells@redhat.com \
--cc=dianders@chromium.org \
--cc=dwmw2@infradead.org \
--cc=jack@suse.cz \
--cc=kees@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux.amoon@gmail.com \
--cc=masahiroy@kernel.org \
--cc=mhocko@suse.com \
--cc=nathan@kernel.org \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=rppt@kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=surenb@google.com \
--cc=tglx@kernel.org \
--cc=thomas.weissschuh@linutronix.de \
--cc=vbabka@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox