* Re: [PATCH] f2fs: do not support mmap write for large folio
[not found] <20260406154940.2407853-1-jaegeuk@kernel.org>
@ 2026-04-07 5:17 ` Christoph Hellwig
2026-04-07 22:58 ` Jaegeuk Kim
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2026-04-07 5:17 UTC (permalink / raw)
To: Jaegeuk Kim; +Cc: linux-kernel, linux-mm
On Mon, Apr 06, 2026 at 03:49:40PM +0000, Jaegeuk Kim wrote:
> Let's check mmmap writes onto the large folio.
Why? And how is this not breaking applications?
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> fs/f2fs/file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 2c4880f24b54..edfc3a374c40 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -82,7 +82,7 @@ static vm_fault_t f2fs_vm_page_mkwrite(struct vm_fault *vmf)
> int err = 0;
> vm_fault_t ret;
>
> - if (unlikely(IS_IMMUTABLE(inode)))
> + if (mapping_large_folio_support(inode->i_mapping))
> return VM_FAULT_SIGBUS;
>
> if (is_inode_flag_set(inode, FI_COMPRESS_RELEASED)) {
> --
> 2.53.0.1213.gd9a14994de-goog
>
>
---end quoted text---
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] f2fs: do not support mmap write for large folio
2026-04-07 5:17 ` [PATCH] f2fs: do not support mmap write for large folio Christoph Hellwig
@ 2026-04-07 22:58 ` Jaegeuk Kim
2026-04-08 5:03 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Jaegeuk Kim @ 2026-04-07 22:58 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linux-kernel, linux-mm
On 04/06, Christoph Hellwig wrote:
> On Mon, Apr 06, 2026 at 03:49:40PM +0000, Jaegeuk Kim wrote:
> > Let's check mmmap writes onto the large folio.
>
> Why? And how is this not breaking applications?
Since we only support the large folio on the read case.
>
> >
> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> > ---
> > fs/f2fs/file.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> > index 2c4880f24b54..edfc3a374c40 100644
> > --- a/fs/f2fs/file.c
> > +++ b/fs/f2fs/file.c
> > @@ -82,7 +82,7 @@ static vm_fault_t f2fs_vm_page_mkwrite(struct vm_fault *vmf)
> > int err = 0;
> > vm_fault_t ret;
> >
> > - if (unlikely(IS_IMMUTABLE(inode)))
> > + if (mapping_large_folio_support(inode->i_mapping))
> > return VM_FAULT_SIGBUS;
> >
> > if (is_inode_flag_set(inode, FI_COMPRESS_RELEASED)) {
> > --
> > 2.53.0.1213.gd9a14994de-goog
> >
> >
> ---end quoted text---
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] f2fs: do not support mmap write for large folio
2026-04-07 22:58 ` Jaegeuk Kim
@ 2026-04-08 5:03 ` Christoph Hellwig
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2026-04-08 5:03 UTC (permalink / raw)
To: Jaegeuk Kim; +Cc: Christoph Hellwig, linux-kernel, linux-mm
On Tue, Apr 07, 2026 at 10:58:11PM +0000, Jaegeuk Kim wrote:
> On 04/06, Christoph Hellwig wrote:
> > On Mon, Apr 06, 2026 at 03:49:40PM +0000, Jaegeuk Kim wrote:
> > > Let's check mmmap writes onto the large folio.
> >
> > Why? And how is this not breaking applications?
>
> Since we only support the large folio on the read case.
In general spelling such basic out in the commit log, and even comments
is really helpful. I'm curious how this works, though - by the time
you read a large folio you don't know if it will ever be written to.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-08 5:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260406154940.2407853-1-jaegeuk@kernel.org>
2026-04-07 5:17 ` [PATCH] f2fs: do not support mmap write for large folio Christoph Hellwig
2026-04-07 22:58 ` Jaegeuk Kim
2026-04-08 5:03 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox