linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Aboorva Devarajan <aboorvad@linux.ibm.com>,
	akpm@linux-foundation.org, Liam.Howlett@oracle.com,
	lorenzo.stoakes@oracle.com, shuah@kernel.org, pfalcato@suse.de,
	ziy@nvidia.com, baolin.wang@linux.alibaba.com, npache@redhat.com,
	ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org
Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org, donettom@linux.ibm.com,
	ritesh.list@gmail.com
Subject: Re: [PATCH v2 1/7] mm/selftests: Fix incorrect pointer being passed to mark_range()
Date: Thu, 3 Jul 2025 10:03:01 +0200	[thread overview]
Message-ID: <adcdaa67-9eb4-47a8-86dd-56ccae0dd99b@redhat.com> (raw)
In-Reply-To: <20250703060656.54345-2-aboorvad@linux.ibm.com>

On 03.07.25 08:06, Aboorva Devarajan wrote:
> From: Donet Tom <donettom@linux.ibm.com>
> 
> In main(), the high address is stored in hptr, but for mark_range(),
> the address passed is ptr, not hptr. Fixed this by changing ptr[i] to
> hptr[i] in mark_range() function call.
> 
> Fixes: b2a79f62133a ("selftests/mm: virtual_address_range: unmap chunks after validation")
> Signed-off-by: Donet Tom <donettom@linux.ibm.com>
> Signed-off-by: Aboorva Devarajan <aboorvad@linux.ibm.com>
> ---
>   tools/testing/selftests/mm/virtual_address_range.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/mm/virtual_address_range.c b/tools/testing/selftests/mm/virtual_address_range.c
> index 169dbd692bf5..e24c36a39f22 100644
> --- a/tools/testing/selftests/mm/virtual_address_range.c
> +++ b/tools/testing/selftests/mm/virtual_address_range.c
> @@ -227,7 +227,7 @@ int main(int argc, char *argv[])
>   		if (hptr[i] == MAP_FAILED)
>   			break;
>   
> -		mark_range(ptr[i], MAP_CHUNK_SIZE);
> +		mark_range(hptr[i], MAP_CHUNK_SIZE);
>   		validate_addr(hptr[i], 1);
>   	}
>   	hchunks = i;

Acked-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb



  parent reply	other threads:[~2025-07-03  8:03 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-03  6:06 [PATCH v2 0/7] selftests/mm: Fix false positives and skip unsupported tests Aboorva Devarajan
2025-07-03  6:06 ` [PATCH v2 1/7] mm/selftests: Fix incorrect pointer being passed to mark_range() Aboorva Devarajan
2025-07-03  7:59   ` Dev Jain
2025-07-03  8:03   ` David Hildenbrand [this message]
2025-07-03 14:33   ` Zi Yan
2025-07-03  6:06 ` [PATCH v2 2/7] selftests/mm: Add support to test 4PB VA on PPC64 Aboorva Devarajan
2025-07-03  8:05   ` Dev Jain
2025-07-03  8:09   ` David Hildenbrand
2025-07-03 14:41   ` Zi Yan
2025-07-03 14:44     ` Dev Jain
2025-07-03 14:53       ` Zi Yan
2025-07-03 14:50     ` Donet Tom
2025-07-03  6:06 ` [PATCH v2 3/7] selftest/mm: Fix ksm_funtional_test failures Aboorva Devarajan
2025-07-03  6:06 ` [PATCH v2 4/7] mm/selftests: Fix split_huge_page_test failure on systems with 64KB page size Aboorva Devarajan
2025-07-03  8:15   ` Dev Jain
2025-07-03  8:22   ` David Hildenbrand
2025-07-03  8:58     ` Donet Tom
2025-07-03 14:21       ` Zi Yan
2025-07-03 14:30         ` Donet Tom
2025-07-03 14:30   ` Zi Yan
2025-07-03 14:52     ` Donet Tom
2025-07-03  6:06 ` [PATCH v2 5/7] selftests/mm: Fix child process exit codes in ksm_functional_tests Aboorva Devarajan
2025-07-03  8:29   ` David Hildenbrand
2025-07-03  8:33   ` David Hildenbrand
2025-07-03  8:51     ` Donet Tom
2025-07-03  9:14       ` David Hildenbrand
2025-07-03 14:31         ` Donet Tom
2025-07-03  6:06 ` [PATCH v2 6/7] selftests/mm: Skip thuge-gen if shmmax is too small or no 1G huge pages Aboorva Devarajan
2025-07-03  8:21   ` Dev Jain
2025-07-03  8:36   ` David Hildenbrand
2025-07-03 14:43   ` Zi Yan
2025-07-03  6:06 ` [PATCH v2 7/7] selftests/mm: Skip hugepage-mremap test if userfaultfd unavailable Aboorva Devarajan
2025-07-03  8:38   ` David Hildenbrand
2025-07-03 14:52     ` Zi Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adcdaa67-9eb4-47a8-86dd-56ccae0dd99b@redhat.com \
    --to=david@redhat.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=aboorvad@linux.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=dev.jain@arm.com \
    --cc=donettom@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=npache@redhat.com \
    --cc=pfalcato@suse.de \
    --cc=ritesh.list@gmail.com \
    --cc=ryan.roberts@arm.com \
    --cc=shuah@kernel.org \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).