From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59C2AC83030 for ; Thu, 3 Jul 2025 08:03:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D0F2C900006; Thu, 3 Jul 2025 04:03:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CE761900005; Thu, 3 Jul 2025 04:03:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD615900006; Thu, 3 Jul 2025 04:03:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AD8BB900005 for ; Thu, 3 Jul 2025 04:03:09 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6B0E11246AA for ; Thu, 3 Jul 2025 08:03:09 +0000 (UTC) X-FDA: 83622212898.24.FE1CD5F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 05DE88000D for ; Thu, 3 Jul 2025 08:03:06 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Hid5h7Zo; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751529787; a=rsa-sha256; cv=none; b=xSuoGHItj8CFNU+5cpcU+Jb5fgQON986iLld8+YMKY+V9SBYdbkVfB8PrUDiBLWtxZwosP IR/UrHpKTgjeSaFcJqtH58kZwDLD/9JQZyj6ztHRSskLUQ6+v7XHdae4olkL3+24yWuF1j YMO0ewFm5kZ6fP+Or3GMRJ5T401v2rQ= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Hid5h7Zo; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751529787; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rU5Offe+0rSj19APlLiLOhHgLRiJXDUZDGfkGR8DMfM=; b=sRJ6SlQmZ98Lc6MyHlOB1/VfmTvdBcDWvgu1s8N13npxI1WgMVtbazJu+Ie7MPTsSDYxOQ TNRtoNxxz6gTtXXn/U9CmopmO+UzC6vg1z4/V8xivLCS651lTxxtNOo0RNDFbxjbLQUFlL e8tkIFJ5U2uur0AkI82jiKJ5x0M4fv0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751529786; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=rU5Offe+0rSj19APlLiLOhHgLRiJXDUZDGfkGR8DMfM=; b=Hid5h7Zofu1MijQvdZD0TNjcf+GCNV4pam3CsL66iNJ5JQ+YBuKH1o6SHcwQR9J/kWIq+p Iq/026i5+73h6CWYrNYMEFWPSkeh2HReMt2yXGJpPjVZZnneym/+Da9peyRvZmiF6V+0cW AMVCEdz1la9iR5KSEqe0kXD0kz/+trU= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-542-xw6eO2ntNAWcuC6e7XYTuQ-1; Thu, 03 Jul 2025 04:03:04 -0400 X-MC-Unique: xw6eO2ntNAWcuC6e7XYTuQ-1 X-Mimecast-MFC-AGG-ID: xw6eO2ntNAWcuC6e7XYTuQ_1751529784 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-ade5013e0b9so442437866b.2 for ; Thu, 03 Jul 2025 01:03:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751529783; x=1752134583; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=rU5Offe+0rSj19APlLiLOhHgLRiJXDUZDGfkGR8DMfM=; b=vZ5NU95Aj7t7bS24TiNZiaAM85PnjX/CRHzHehuy3Sh4167nUV/1w15rIP74UDXFic rZlddREJoT280oJg4N61piOqRjgnSvpa8wQdMvxCwSdNQ+zeZaVfzlML5gRTm8zfdftn 1wN4mU2ZdQTJwZ9gH2Dp04yxWmSQ7INr6NEaC/Mj7QVs9mjx8Ymc9fzekDAvH+eqx9ye x3nHCtR/V6wjamIw5yaegu+zpjWWfvIKe4dhWFPEyiUjSzH8USaM6l3gOv4NXgg3jMku Lw9fIvYx2DiShPy6v6p4Ys3BR8zLrqjs/Mg5UTl19DmVjF3RZFJcZlGg51dw2sO+E+y1 WiTQ== X-Gm-Message-State: AOJu0YxjVaYU6Usv/l4VHOIQKsv53BAznvf0DhHQXDqPhZI58ZgeFaZz 9jZ9w0lT/ahxNgRpKvI8iYitCKTR6/RcMiQUdN1U0oO+QLBydILfWUGwlgPLplYoLFILitu2pWT BLD7Vl/A+Zm+IwZ1LxvrGcyBEzm4UYhqbunhgJopNhPQ6RU1ph8hY X-Gm-Gg: ASbGncsIeqLF2ln+C4NKayQGW6Hjpdvbsokl1bybtZ+ZsofWOtwXWVEbdFCsxCmF8j5 1eBDWMoKAjJd97wm8s7hucg55cdCGiZyI87IPW9Ku5g77m/WDFVpMw6AUf2wqT+qHWe1eso+GbQ f/86yVSUJnVu569ZYgiQ30I45LB9E9xvsgOPfCwCUzycJCQ/UVl6FmiDTISb3g8SFdyD/iF0rcy Opq7RQuR6NYBG2xDyoqpkLAvY5t2VkML6KXMWtHE3k0EqBCGRtrBUcw4LWz2K+75uoTFEI+jU9C OrBGMoHdAnct1gSkkKnHTybmPXvni7Vm528g7TQMZREa X-Received: by 2002:a17:907:930a:b0:adf:7740:9284 with SMTP id a640c23a62f3a-ae3d8b956ecmr238108966b.57.1751529783567; Thu, 03 Jul 2025 01:03:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHN+d3U8Q/iQsyL2MRs8lXfAMehX7tLoN1mBKlzYUA4dzhVi2aypXBlEYkxHUC75seobjJ6gQ== X-Received: by 2002:a17:907:930a:b0:adf:7740:9284 with SMTP id a640c23a62f3a-ae3d8b956ecmr238104766b.57.1751529783091; Thu, 03 Jul 2025 01:03:03 -0700 (PDT) Received: from [10.32.64.156] (nat-pool-muc-t.redhat.com. [149.14.88.26]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae353c6b448sm1203266966b.127.2025.07.03.01.03.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Jul 2025 01:03:02 -0700 (PDT) Message-ID: Date: Thu, 3 Jul 2025 10:03:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/7] mm/selftests: Fix incorrect pointer being passed to mark_range() To: Aboorva Devarajan , akpm@linux-foundation.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, shuah@kernel.org, pfalcato@suse.de, ziy@nvidia.com, baolin.wang@linux.alibaba.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, donettom@linux.ibm.com, ritesh.list@gmail.com References: <20250703060656.54345-1-aboorvad@linux.ibm.com> <20250703060656.54345-2-aboorvad@linux.ibm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250703060656.54345-2-aboorvad@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: rirLEifAz07Mir6wU7M3tHov5NA_4AVpZcswaU2Wv5o_1751529784 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 05DE88000D X-Stat-Signature: qa5r4c38wxywddhd4bsipe1wuar89tdc X-HE-Tag: 1751529786-229068 X-HE-Meta: U2FsdGVkX19VTKbXSzvHm/CuZpsNnurZncO0wOHZdszka1k2r9fuGWzEIpNb3mA2gN63T00c0VP1XA9LM3FgjjQ5eI88LajP8a7jyayWp5VeQf9nqN1zjVHLvnxfNRt9dUMz8vV4hNFZKNzkcbYcmRjk9SICfYv0CWSmxzIbScCGEM1RkBjZfe/yR2wYXn8+zaUHt01P3Nwyu93ZRGpIoR1roZQD7kOeAhh1r007wYuTE6znbhZX1A1pioIvR6aArL0wb681Qf0dAy/xEGxs0WtIjceMr2CGveV5IDyQDMw7BZbNeEMqXEaVVqp3Tfx96qbBkcxB34bUdzyS8XBv/emrnzWQsiVJfksXtVfGt8t2QIIXHCqH1lG6Itm4kAmEf9RKZAa4OYRBN9sTntql+fXmDIp/vDh2Ws2tBkrcBJ3fBi6V1/9PZd70x3k5w3+m8YZmVBlrv1HG+EjCaJ3Iefnhj+tSXRjMT549hc/QUc9lAJgAH0Zo+hdIhEmOBtbOOFO67KDXRlZpkpBPj8zhmiz4TXlOgNb1ksnvdz2HS9RPhmGCRWpBznpl23zqhMEtP3aVuZBuqDOr2BpHiT96Vc4q35S3SMNYczQfqQqIP4w7jB0oR1XJxYabbkoX0Dkx7UYK0G9oUobIjy/hQ/CWJWyHaaW8+sW6AvvDD4xFCavi4C2hsFEI8emNSevx6MZ8HqdqKQQlvyxyAUZ970kc7NfoBdzJUX6MiuJdRWTbEb1Q6xrxgjH9/7HhF/D6MD6adYaJJHFBx5C+asf2GGK3Ho0ob6zb7iwGbcvmEms4IotQrvReaK4fUaQhcWgY7zECEJKajFlktZNix+B8qPp0BVuAIHCDRNTkkgmTNYdejmc6JYlh8rgkYRFx0YS0660DtpudYlc1I5dbbWRylej8Iw9Mcf7ziWkbXujerwvtqNgRXjZzbgPC9of1L9wfSauang4C1c7WHDmeCVjnxmm Zb3/Hxrf a7/V5W42fDz2BN1w2PJAQsjluuW2HlkvmqgcMV4p/1hd2B19xPkNrKe3huQCyRmqM8eG6QP3sfgRrEYU5gCcUs/2rzQaEt/ir59U9I5M2w/uqZrRARqbUjrPIoruP3V6j3ueAxsSjBdxfdZgAqiYtNDXobcv2s2VkkbrXWnIwYQCgXWU5LSBDtz2zVMdIIiyKnRsNpBnYNl2BzmNVcJB9nxmIatsAX5H5J/b9ORd6DHS0hFEadKY8JMm0azJKrg1KSrRRmg7TchPgMZsVIi3dPIGSLsu3vh6I6qpRc6fK+t7OkHpWNNDGt5/ViqRD1lIrQdomiE4GJlqRDz+tQO9QvveAacoQfSk6gdvZagymcNO7N7ceGogh8RlTZZxFS9plq4DctC62bSA59QcfUI8fVz9LYiuLSaYbuGT9ygul5vm1Qm0NLbMa1CcRb1Br2eKT6250JFo96t37YzUxJtKSlRWAgNxqv96c85SYXKgUiip3bGovjEeZ8KdsZGIyZHJvpNSUizx0RisCJb2m7FJYYX01GkX2DnPiBNwgjxcG+4la9Cbeuk48uYuS/EvCjaOOm/B7t0ZLEMiDenvpnH05eU4I0g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.07.25 08:06, Aboorva Devarajan wrote: > From: Donet Tom > > In main(), the high address is stored in hptr, but for mark_range(), > the address passed is ptr, not hptr. Fixed this by changing ptr[i] to > hptr[i] in mark_range() function call. > > Fixes: b2a79f62133a ("selftests/mm: virtual_address_range: unmap chunks after validation") > Signed-off-by: Donet Tom > Signed-off-by: Aboorva Devarajan > --- > tools/testing/selftests/mm/virtual_address_range.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/virtual_address_range.c b/tools/testing/selftests/mm/virtual_address_range.c > index 169dbd692bf5..e24c36a39f22 100644 > --- a/tools/testing/selftests/mm/virtual_address_range.c > +++ b/tools/testing/selftests/mm/virtual_address_range.c > @@ -227,7 +227,7 @@ int main(int argc, char *argv[]) > if (hptr[i] == MAP_FAILED) > break; > > - mark_range(ptr[i], MAP_CHUNK_SIZE); > + mark_range(hptr[i], MAP_CHUNK_SIZE); > validate_addr(hptr[i], 1); > } > hchunks = i; Acked-by: David Hildenbrand -- Cheers, David / dhildenb