public inbox for linux-mm@kvack.org
 help / color / mirror / Atom feed
From: Gregory Price <gourry@gourry.net>
To: Ritesh Harjani <ritesh.list@gmail.com>
Cc: "Huang, Ying" <ying.huang@linux.alibaba.com>,
	Donet Tom <donettom@linux.ibm.com>,
	David Hildenbrand <david@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Ying Huang <huang.ying.caritas@gmail.com>,
	Juri Lelli <juri.lelli@redhat.com>, Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH v2] memory tiering: Do not allow promotion if NUMA_BALANCING_MEMORY_TIERING is disabled
Date: Thu, 9 Apr 2026 10:10:52 -0400	[thread overview]
Message-ID: <adezbGO3qQMbMEP8@gourry-fedora-PF4VCD3F> (raw)
In-Reply-To: <se94lry7.ritesh.list@gmail.com>

On Thu, Apr 09, 2026 at 09:12:56AM +0530, Ritesh Harjani wrote:
> "Huang, Ying" <ying.huang@linux.alibaba.com> writes:
> 
> >>>>> Donet Tom <donettom@linux.ibm.com> writes:
> >>
> >>
> >> Thanks for the clarification. I was running some experiments where I
> >> only required migration, not promotion. However, I observed that
> >> promotion was still occurring even when NUMA_BALANCING_MEMORY_TIERING
> >> was disabled, which led me to believe it might be a bug, so I reported
> >> it.
> >>
> >> As I understand it, enabling both NUMA_BALANCING_MEMORY_TIERING and
> >> NUMA_BALANCING_NORMAL results in both promotion and migration. Given
> >> this, do you see any concerns with modifying the behavior of
> >> NUMA_BALANCING_NORMAL?
> >>
> >> With this patch, we would have better control over enabling and
> >> disabling promotion independently. I would appreciate your thoughts on
> >> this.
> >
> > IIUC, we change the existing user visible behavior only with strong
> > enough practical reason.
> 
> So what I understood from this discussion so far is, we don't have any
> mechanism to do auto-numa base page migration between DRAM -to- DRAM w/o
> triggering promotions too from a lower tiers to higher tiers.
> 
> ... This to me sounds more like a broken interface.
> 

It only seems that way because the naming suggests tiering did not exist
prior to _TIERING - instead _NORMAL just operates in a suboptimal manner
when multiple tiers exist.

_NORMAL migrates a page when it detects the node it's on is not the
local node of the task doing the work.

_TIERING takes into account the liveliness of the pages with a
timestamp.

Going to agree with Ying here - this change should be dropped without
additional data.  If you can show _NORMAL would be better off not moving
low-tier pages for at least a handful of common benchmarks, or that
_NORMAL is causes incorrect placement - then I think this change is
warranted.

But as it is, this would just be a behavioral change without supporting
data to justify it.

~Gregory


      parent reply	other threads:[~2026-04-09 14:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-23  9:48 [PATCH v2] memory tiering: Do not allow promotion if NUMA_BALANCING_MEMORY_TIERING is disabled Donet Tom
2026-04-02  0:22 ` Andrew Morton
2026-04-02  3:31   ` Huang, Ying
2026-04-02  3:27 ` Huang, Ying
2026-04-02  4:59   ` Donet Tom
2026-04-02  6:24     ` Huang, Ying
2026-04-08 13:20       ` Donet Tom
2026-04-09  1:28         ` Huang, Ying
2026-04-09  3:42           ` Ritesh Harjani
2026-04-09  6:39             ` Huang, Ying
2026-04-09 14:10             ` Gregory Price [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adezbGO3qQMbMEP8@gourry-fedora-PF4VCD3F \
    --to=gourry@gourry.net \
    --cc=akpm@linux-foundation.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=david@kernel.org \
    --cc=donettom@linux.ibm.com \
    --cc=huang.ying.caritas@gmail.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=ritesh.list@gmail.com \
    --cc=ying.huang@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox