From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41071C48BF6 for ; Mon, 4 Mar 2024 20:17:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7ED886B0075; Mon, 4 Mar 2024 15:17:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 79D9C6B007B; Mon, 4 Mar 2024 15:17:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6167D6B007D; Mon, 4 Mar 2024 15:17:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 52E436B0075 for ; Mon, 4 Mar 2024 15:17:14 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 24F0AA0152 for ; Mon, 4 Mar 2024 20:17:14 +0000 (UTC) X-FDA: 81860465988.15.7138E20 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id BD7B240013 for ; Mon, 4 Mar 2024 20:17:11 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PS0NqiVC; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709583431; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XUyc8q6ByaqAn+t6YqnVNICc+5KdV2+c43xDgTSyudY=; b=mondsttu+m09onisYoEAsnFGLawAAXhFXeICubBfK1LZihhnqzQgEWu/+hKLVpTEkClDDW PZLVaUMipoWMpKNvBgTIIiZoY2a2uKbejCgl6J/tfMJMk7NgycoKlaGEimltCzR89tm7aU VeKUah0CnPMzEAu6qZ0tifUvcEWg8a4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709583431; a=rsa-sha256; cv=none; b=nlVzV8mR12sSG48/iMmuzwgv3Th+8ZycE8Ihkf08i9Q6XbtP3w0n9UIlcAaxDwUVufuxmA cw6OeykDMojY+yRzbfxlLJH1Qx7Ee1lZGVYnjS++RE/XY9itDPS4Y4i3B90ac4JT77b63i NOuPPsCksy9TQNBvMmFU/ITi4ziwpLA= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PS0NqiVC; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709583431; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=XUyc8q6ByaqAn+t6YqnVNICc+5KdV2+c43xDgTSyudY=; b=PS0NqiVC/U6tkZDDY64s5o2Z9XPVOXop5hcbJjFJAjjcfJI1/MRN7MPr/5lcmPo8DsHHlx HdIOGDUXOEBq7SwftfrVxNSjhpJWXtNTxGC0iLsF1MPFSxPowjUYMvhc9k+dxpLgYz9CeH TZsq+caJ0ntTTnl42fvNUkUGNAa/Ytc= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-635-XLYPWxE7Me6A0agMKP91Sg-1; Mon, 04 Mar 2024 15:17:09 -0500 X-MC-Unique: XLYPWxE7Me6A0agMKP91Sg-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-412e355e2abso7580015e9.2 for ; Mon, 04 Mar 2024 12:17:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709583429; x=1710188229; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XUyc8q6ByaqAn+t6YqnVNICc+5KdV2+c43xDgTSyudY=; b=l6pIKAKXEvLuvx24upwPBRvfNNjCU2doB4d2E2oB6VEW+jIumTUr90GJGzBablTf5B Zf23QMrIHgXi7uON8pRyUH5Y8CkaRlHSTWcyeqjIAqDQqY4QOQf6tjqhy0e9ztEJtobB QuYAtnoFpFaT1l9wHLsm1UvPPxqUT0n6/6ETy4aHKhxeOY2w07Zmhg7b3EZ+oy7XgKbT fUvX3V12rK6I2SNn0y8od2MN8uJED2Tim9xf0nn91OouKnNryC8x4jKSK1vwAhLlvd73 8cc1Q/u8SbPkh7I3eAgMozTyMhcGouVLzTwsjZsJWZBNihEVxv1gqc/Znp1TaGSDBY4z rjlA== X-Forwarded-Encrypted: i=1; AJvYcCVKXqNbZUya/s5r1VzYCrso27oVPWyEC31M/CJRqVDsKGX+aomLD619o6ZN7oMyKigvNOGtpIgQ7GCYCTQlDnsvzDg= X-Gm-Message-State: AOJu0YyaKtMd6SaAbQ2hvurj/JmHmHPj7SFu/xrKFb44UFi9B3jTSKAn HMIhlKAwQKNDsjSUaeT3Yr4unFNEjGL65tjazRiwcgblj2ywLriAvrKnCvGExDG7ZDKcZQWi7F3 kxs/VNHG6Vtb1Ka58J0E38x2oCK08IGU40k1ST2xPXXDGX5z9 X-Received: by 2002:a05:600c:34d6:b0:412:e784:1a6f with SMTP id d22-20020a05600c34d600b00412e7841a6fmr1653348wmq.17.1709583428634; Mon, 04 Mar 2024 12:17:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IHfjr46aXrQPoxi3kIb/H+ZC31GWzvVOt0EfNP9BwKX4senOARdvOEGngW08GAKIZ3m3XRF8A== X-Received: by 2002:a05:600c:34d6:b0:412:e784:1a6f with SMTP id d22-20020a05600c34d600b00412e7841a6fmr1653306wmq.17.1709583428189; Mon, 04 Mar 2024 12:17:08 -0800 (PST) Received: from ?IPV6:2003:cb:c733:f100:75e7:a0a4:9ac2:1abb? (p200300cbc733f10075e7a0a49ac21abb.dip0.t-ipconnect.de. [2003:cb:c733:f100:75e7:a0a4:9ac2:1abb]) by smtp.gmail.com with ESMTPSA id d16-20020a05600c34d000b00412eb0d455dsm266005wmq.41.2024.03.04.12.17.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Mar 2024 12:17:07 -0800 (PST) Message-ID: Date: Mon, 4 Mar 2024 21:17:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: folio_mmapped To: Sean Christopherson , Quentin Perret Cc: Matthew Wilcox , Fuad Tabba , kvm@vger.kernel.org, kvmarm@lists.linux.dev, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, viro@zeniv.linux.org.uk, brauner@kernel.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, yu.c.zhang@linux.intel.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, keirf@google.com, linux-mm@kvack.org References: <40a8fb34-868f-4e19-9f98-7516948fc740@redhat.com> <20240226105258596-0800.eberman@hu-eberman-lv.qualcomm.com> <925f8f5d-c356-4c20-a6a5-dd7efde5ee86@redhat.com> <755911e5-8d4a-4e24-89c7-a087a26ec5f6@redhat.com> <99a94a42-2781-4d48-8b8c-004e95db6bb5@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BD7B240013 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 1qdfm6dpkwk7hob9ype16pt6remq4qdy X-HE-Tag: 1709583431-311981 X-HE-Meta: U2FsdGVkX19Ec+Yv7V4frMaFgPM46CNPBwpeNm7PvNCWLuQFAuof/ysE1iwxeLN0NY9FZVstsSDRLoqp6cXlNG/bn1CybD7yy9ElTCcCxxiU+QHaAqQGgsP4Dj2cXqB05A25kin96QEXd6pQFVDVGfzeYquX67asPZJAsF5IHBiyT5uYmvUrA6jU0xeHQavT7JDOyaMoK9etnWSsF+ywCpf3W8BjcgVt/5vFslQaurvzVJbQKBePLjCg2gtu7a/Jvd7Ix0nzZ2tb6L+rDKLNa9zikERtIohBZ94wOwNimpfqnwPMfGuo+Hp/vNoL7yZ9P+IwQnoHBTp2cHavylmw4wGJ3Xir5m957npofTW4lpS8gv0aNvciN+3TH8zvBYaGYVpHD5orCaych+zAgqrKxcZL7T41EDexCkgT3pO0hhtFCZrRpzb6PQTw7dL0tBdilCdEAqZsRPw3jz6OiY6fcBog87c0u7gWhKz/D5HSUEXazaiyGoz5Qifx2SmsJ9VwEHdlK8HPN+0uLsRdMizOVYn29F9AFjQXAvfgDiL03S6+9H6VbpgOlVEXTAjaOVgCbM270sdGDJyWdCnc5OEtBrJw2VELy8xvYMDo35wB+Z45yiyczWrvqGrWOrM4wBH7wVaWjBShHlip9I3ypMMkVzSjmvS2PCw07tc7xCU2LWbWrwQD5CombMGIjW24QrLlBDAmfq8z91JJm3ZyEveGJ9kEfaO1TiDjvk2TBVZYUtpa9begT0sDWK+XsxgSYQttUEMQV/OK5x1dyS40jt+M8EioVTtL6da2S07qUcrvik4sD+60C+8nDGYCbG4wqQr3JYubr8uEF/Tla4Bo3tzxCVS/TxYsJWcrS5t8XINelIzguEm6ARPrRjH76UsDZcScw7wiTvUniW/V9l7a94xx/oY7D4UYF7lNTtTpAff37dOs/4uzMEFP1hI8xY0Jx5r+cSyI6VkRMGiFqFIt3YC ndtw2MvY T/wVJrDXKQOF2F1CPTOaCQDt+Whr9n1+RryMni3FStpxJn7I99qS3UaIqYjlGi8HIlzrP0CN9sefZwBQv28JAk/1DiVxuM7pMsl68hzTy8hBb9eE5Hb/ot5LN0UYNB2Ovnjzpmh8G7h2p4X5TvNWUyknjj0yGVHxNS2hNQLcxcQFaW4kLX9KOHiN3vxzCGj98QVLUBUGrnfJy8Yud9adsUPOrAOhUsjYp9NSiIsIcFbGwMIoiO+IvzlPiXKY3s7ok/hUKUsw6bDOUlE+gKgy3XIfAHwZA/YprX9EYU2v+Dzi5HN1p2177dgpK4c5RA1LB8+dpw5jAmEKJheS33E1W86ZHF4472Oc6PPOBHJVB09b1lBXXncUByQ0dKDAFX99M8pNI49DB+kFtxRhZE7R1jVfw+SCwWLlHn3c6Ha3Yll0iAIfQelRLh0iIO0S2fguLhyUTl+R6tJITU965EpSEhzOg0AjvCfzpwyTzngKYfF+sDCJk/J9l5ugB0cqKxJqtuo2gVJztX+TZBDMSldyXXHMSyJfoexd8qYWH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.03.24 20:04, Sean Christopherson wrote: > On Mon, Mar 04, 2024, Quentin Perret wrote: >>> As discussed in the sub-thread, that might still be required. >>> >>> One could think about completely forbidding GUP on these mmap'ed >>> guest-memfds. But likely, there might be use cases in the future where you >>> want to use GUP on shared memory inside a guest_memfd. >>> >>> (the iouring example I gave might currently not work because >>> FOLL_PIN|FOLL_LONGTERM|FOLL_WRITE only works on shmem+hugetlb, and >>> guest_memfd will likely not be detected as shmem; 8ac268436e6d contains some >>> details) >> >> Perhaps it would be wise to start with GUP being forbidden if the >> current users do not need it (not sure if that is the case in Android, >> I'll check) ? We can always relax this constraint later when/if the >> use-cases arise, which is obviously much harder to do the other way >> around. > > +1000. At least on the KVM side, I would like to be as conservative as possible > when it comes to letting anything other than the guest access guest_memfd. So we'll have to do it similar to any occurrences of "secretmem" in gup.c. We'll have to see how to marry KVM guest_memfd with core-mm code similar to e.g., folio_is_secretmem(). IIRC, we might not be able to de-reference the actual mapping because it could get free concurrently ... That will then prohibit any kind of GUP access to these pages, including reading/writing for ptrace/debugging purposes, for core dumping purposes etc. But at least, you know that nobody was able to optain page references using GUP that might be used for reading/writing later. -- Cheers, David / dhildenb