From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99F3EC433F5 for ; Thu, 14 Apr 2022 21:49:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 29CE06B0071; Thu, 14 Apr 2022 17:49:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 24AB36B0073; Thu, 14 Apr 2022 17:49:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0EBDF6B0074; Thu, 14 Apr 2022 17:49:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 01EEC6B0071 for ; Thu, 14 Apr 2022 17:49:52 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BF4A82396D for ; Thu, 14 Apr 2022 21:49:51 +0000 (UTC) X-FDA: 79356827382.04.48FE518 Received: from mail-il1-f172.google.com (mail-il1-f172.google.com [209.85.166.172]) by imf02.hostedemail.com (Postfix) with ESMTP id 477168000F for ; Thu, 14 Apr 2022 21:49:51 +0000 (UTC) Received: by mail-il1-f172.google.com with SMTP id x9so3936757ilc.3 for ; Thu, 14 Apr 2022 14:49:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=q0JHKXPIUQwXKIyQID2uNw8AWiNJuyCq0B2NuHEUdjw=; b=dv9D5fNYDGcObkc1VhdDNV3GXjucyxDSnq8AFxBOd4Ons3E2R04iKBRBObfrlte5Xd KWo1msVoXlM72zJxXJj9OjCnEHb5QPDwTL8l5vZsIwbhhOdEp0nriEZ20xAt/MT7H61x oPJ5/FMYlbmLuywl6Jyn2lT+zDeQzb5mhxNhY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=q0JHKXPIUQwXKIyQID2uNw8AWiNJuyCq0B2NuHEUdjw=; b=FjOslLEwKXZiy6ptRwk+kcQa84hu0wkuJOLJuwgr4NqjLW5Iw22VOT9QFznfVOrLT+ eCz+/QIq4jHQIiZgAXXIeSzpGVYZFCuPtvua2fPPgkDf4qcI8hEy3a3d+uuBZwvfUEqe Uf6ftK4OhGWY4Jw5PlfDgY8YRejHEDrOFLLDy1fT+BbxGeGhNywOGENJJSvfRXJroUzT n+Ql5Gus7VW8mddq1Z/b1ky2xyz7eMnX5vHhWq3wOuoN0FGKHGf4nSi9crxfwKCmMq17 iE2WP6srtacKP3FL4p3gTJsAPwBVtLpV0afZpUR/cz7Xn25mnuurgyv6NJz6nlj0FnZM VXIg== X-Gm-Message-State: AOAM531RO186D8sjZjqNE8C+j9WW7LJtSScpErLviMb3eztR4+p3iDD4 rWNKBbhEdeX39zxOGGCOIi5aTaOKFSBNpA== X-Google-Smtp-Source: ABdhPJxzMy3EDhRCosc7hcDTPIL3RBmm5BQ8HqWic0WC9oy4qeJYkXOIMPf9IS63ZcjhoaqKzpnvXg== X-Received: by 2002:a92:6c08:0:b0:2c6:123f:48c9 with SMTP id h8-20020a926c08000000b002c6123f48c9mr1972848ilc.22.1649972990653; Thu, 14 Apr 2022 14:49:50 -0700 (PDT) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id v11-20020a92d24b000000b002caacf87598sm1657423ilg.1.2022.04.14.14.49.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Apr 2022 14:49:50 -0700 (PDT) Subject: Re: [PATCH 4/4] selftest/vm: add skip support to mremap_test To: Sidhartha Kumar , shuah@kernel.org, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20220414171529.62058-1-sidhartha.kumar@oracle.com> <20220414171529.62058-5-sidhartha.kumar@oracle.com> From: Shuah Khan Message-ID: Date: Thu, 14 Apr 2022 15:49:49 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220414171529.62058-5-sidhartha.kumar@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 477168000F X-Rspam-User: Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=dv9D5fNY; spf=pass (imf02.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.172 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org X-Stat-Signature: t6jk8pdiy7brny6nia4ypxr7z76ddjjy X-HE-Tag: 1649972991-875553 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000014, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/14/22 11:15 AM, Sidhartha Kumar wrote: > Allow the mremap test to be skipped due to errors > such as failing to find a valid remap region and > failure to parse the mmap_min_addr sysctl. > > Signed-off-by: Sidhartha Kumar > --- > tools/testing/selftests/vm/run_vmtests.sh | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/vm/run_vmtests.sh b/tools/testing/selftests/vm/run_vmtests.sh > index 88e15fbb5027..eae98f5de2cc 100755 > --- a/tools/testing/selftests/vm/run_vmtests.sh > +++ b/tools/testing/selftests/vm/run_vmtests.sh > @@ -272,11 +272,16 @@ echo "-------------------" > echo "running mremap_test" > echo "-------------------" > ./mremap_test > -if [ $? -ne 0 ]; then > +ret_val=$? > + > +if [ $ret_val -eq 0 ]; then > + echo "[PASS]" > +elif [ $ret_val -eq $ksft_skip ]; then > + echo "[SKIP]" > + exitcode=$ksft_skip > +else > echo "[FAIL]" > exitcode=1 > -else > - echo "[PASS]" > fi > > echo "-----------------" > Thank you. Looks good to me. Reviewed-by: Shuah Khan thanks, -- Shuah