From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BBADC77B7C for ; Tue, 24 Jun 2025 01:49:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2AD266B00A8; Mon, 23 Jun 2025 21:49:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 25D206B00C8; Mon, 23 Jun 2025 21:49:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1737A6B00C9; Mon, 23 Jun 2025 21:49:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0512F6B00A8 for ; Mon, 23 Jun 2025 21:49:00 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9B9AF1229D9 for ; Tue, 24 Jun 2025 01:48:59 +0000 (UTC) X-FDA: 83588610798.13.EE6F009 Received: from out30-113.freemail.mail.aliyun.com (out30-113.freemail.mail.aliyun.com [115.124.30.113]) by imf28.hostedemail.com (Postfix) with ESMTP id 68C79C000D for ; Tue, 24 Jun 2025 01:48:57 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=RMjaKuue; spf=pass (imf28.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.113 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750729737; a=rsa-sha256; cv=none; b=HjWQekl/QYxTb0WKKsozN8SMKKsVXfFXNMSxFFZWOwtCbpZswlco68OMXcl+81xgP6C1K6 L980I0c1DM7QTuCcV+ntJOj5gPzJF0kLhSREY6vkXsieOcF3uNorBYqFL4xCXo+TY4qtWo m+N/fVWL3ZegY6rBxuRD00U2WSC8xSA= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=RMjaKuue; spf=pass (imf28.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.113 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750729737; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JGJ5GFOHEsME24UlCT9tOsuTHYhBxxkoMWmuCUFx++w=; b=qFCQwbDDdmKj4bXWb2XMa/7BkV1mFNn29GVTslCCiEzLSG8ByWCPKxHgPBDxctvaTu7XDl n2tz8RI6poxbpiBToxOvzLDkEsbizViVNxyXXMMKhwUJa1GaY0MFkqdin+ronzl2eGLhCI BgJ1Yo/d4NPmab8vaBztqN9hn1zA1ts= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1750729734; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=JGJ5GFOHEsME24UlCT9tOsuTHYhBxxkoMWmuCUFx++w=; b=RMjaKuuen+F30wEdBTaAVzNA3LbE/TCK3WyQ0R0ZbIcF+X10l36Bu9ua0gYkh+A3zjvCMZleLJlWadL5Aqj6lQtV8ERmNh7UXA8K0v0ue3M4mA3OXCyXgWPO1SswHwYU8+8WJa+TQONtWoTS2xNVzcgAaVfcIGFSxbXZ/HTB6EU= Received: from 30.74.144.102(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WeeLBR6_1750729732 cluster:ay36) by smtp.aliyun-inc.com; Tue, 24 Jun 2025 09:48:53 +0800 Message-ID: Date: Tue, 24 Jun 2025 09:48:52 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] mm: huge_memory: disallow hugepages if the system-wide THP sysfs settings are disabled To: David Hildenbrand , akpm@linux-foundation.org, hughd@google.com Cc: ziy@nvidia.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: nxppkqaar1yk9goausytmusohj13ai6s X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 68C79C000D X-Rspam-User: X-HE-Tag: 1750729737-829019 X-HE-Meta: U2FsdGVkX19Q53I+BIJerk9O2dxfr4+sSSymoYesLYzsfLl1pZw/Mliwk5OA7yTCUDhv00HDwZsbLXBeB4LiOwgEraEs8LPyVMLumAEfeqsIMAQv2kYhb+qvt+B+Jp7H9YxdW05jjT9NOWDJyBv3jPb7za879CSdRUlNgp26an4M0POIC4XvdHWfKvAqUpsFWFgNXgHQbUcSjQwYlT5KDtP+nugYZfgiHF+BXLpnwSEeTSgsLR0lYRhQY9iWXM7AcUavdCmlKGNeBgwPuVqpLwWf9AtZ717ltXNGuZR+SWeHJbTzeQJMXMlpK2bNbTN9nSg1hKlak4qPDofPiDZmgafG6zkxaeqDtaqDVKEwYA1JLf2qaPW6wq6yjSW6lgcsKAGuAanSztE4DpbIQurBmsZZKSmvULJ9KiUL34an2f86VKjK0TDDb6z8szBcE/XjKIE63I0YC/Rj0IsukoFabrTMvLMSR61az0cjjoujhdWPYp7F5/SEz/RKjkHAhPUO3/InmawOfzhvZaHjKWp74Z5pvTvzqV1i/Sr3oSO+2ouUvwjFvL2B/R9l99oYExPhx3QNwp/s9gNY9YFciSdEpE3OWjWY8Qnv625/5jdqReZdV/MvALLJWwSw9inhR0Zo3vBxmNFNxc5bPlUijauZytHbQO59bvcCQ62VZv5W2HzZEZ6k5d78Z4x29yL3+dpsJO5MI/Kqp65UgXQwZ/f4HRNiLiYZjCnV4ZvTQ1wKmIUG1rAIsJl3LHt5Eo1vm9fKwDpfNDvd78QwCQwOiHEqDpUaOYEls/jvMwJIXXccXRTL1vMLDZmp6ymvYHFiyARrqtc1lBQuLuYmdtsXfgoE+MQux4drWed9slcSrhp+EJMZ2whkn2jWdsyKaXax0cUrl8K15h8oTikgKGS+neu84X7oZEmxuBj0GVRvlC/t8BLl7tF1gFkZly6WdVwP9mZUBaCy0Y36BaRPO2quJi1 BASHLKnB O9PK1DK20ruUpu8OB1RjsuB5EHDLwkmbKAP4/RiGMl4TMCbGQvt6TodtJJR90YuPjBLATBfGRyGs7nq4VH3VgwBfPyr3PdUrcnyQ4THm2UOKgzURCZ2QIJZAfyLRHY+V1NDjnQKi0NBrcLDfS0vamGTE8NeD5trsP6DppZq2gN3nDhH/2cDp/HJUjq4q+fHs3u8Q7mUSdXtVxK3IX4Gi+ShM/dLPH/QQBGkeKq39YiPI3K20BLFyd8QeR3GzH1FVquUYK8j/m3TOAJ4qnqeughOmjGkMlI5jmj/NOjHKCPQfav5D/+cdmFgY/hs892iY9gySZKQG0QWqdycmBpT01s3hfjqkK/99kHvB4K39koXvjcNDIN1qKc28ybzI5EmcDGD5UGuTbw/xOBEM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/6/23 21:54, David Hildenbrand wrote: > >> diff --git a/tools/testing/selftests/mm/khugepaged.c b/tools/testing/ >> selftests/mm/khugepaged.c >> index 4341ce6b3b38..85bfff53dba6 100644 >> --- a/tools/testing/selftests/mm/khugepaged.c >> +++ b/tools/testing/selftests/mm/khugepaged.c >> @@ -501,11 +501,7 @@ static void __madvise_collapse(const char *msg, >> char *p, int nr_hpages, >>       printf("%s...", msg); >> -    /* >> -     * Prevent khugepaged interference and tests that MADV_COLLAPSE >> -     * ignores /sys/kernel/mm/transparent_hugepage/enabled >> -     */ >> -    settings.thp_enabled = THP_NEVER; >> +    settings.thp_enabled = THP_ALWAYS; > > > Would MADVISE mode also work here? If we don't set MADV_HUGEPAGE, then > khugepaged should be excluded, correct? I tried this, but some test cases failed. As I replied to Barry, it's because some tests previously set MADV_NOHUGEPAGE, and now there is no way to clear the MADV_NOHUGEPAGE flag except by setting MADV_HUGEPAGE.