Re: [PATCH RFC v3 1/4] x86/mm: Use proper page table helpers for huge page generation

Yin Tirui
2026-03-10T03:23:47Z

On 3/6/2026 5:29 PM, Jonathan Cameron wrote:
> Whilst you are here, can we make that a one liner.
> entry = pfn_pmd(__pa(p) >> PAGE_SHIFT, PAGE_KERNEL_LARGE);
>
> Could even do
>
> pmd_t entry = pfn_pmd(__pa(p) >> PAGE_SHIFT, PAGE_KERNEL_LARGE);
> but that's more of a question of taste.
Hi Jonathan,

Thanks for the suggestion, I will fold this one-liner cleanup into the
next respin.

--
Yin Tirui