From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C409C001DE for ; Wed, 26 Jul 2023 09:04:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C8428D0001; Wed, 26 Jul 2023 05:04:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 978A76B0074; Wed, 26 Jul 2023 05:04:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F2DA8D0001; Wed, 26 Jul 2023 05:04:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6A84D6B0071 for ; Wed, 26 Jul 2023 05:04:38 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2EF49B2707 for ; Wed, 26 Jul 2023 09:04:38 +0000 (UTC) X-FDA: 81053177436.12.A04F5C9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 83BE6140024 for ; Wed, 26 Jul 2023 09:04:34 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=f0xUxVnj; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690362274; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kQM+PipHAXSY7x2vlq6C7GWwn6O4D5U4rBQcpyXO4L8=; b=MI/a2Hy38PEeKfWHLaKymJHup6aoKqJXGO7lTV20ZzE+NzM0Z2ZsXetl3JA76JaWsFz5s4 WPkw2C5J7lU9y2pTJ5iLhfRQVJDJ52LUaSCS+CoUT/ki2SViXJUooZ3x1MJ0LjvoQWPxI+ z8YGeZsOqqGOrKfBtnS0S+aXS4Ws4dg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690362274; a=rsa-sha256; cv=none; b=KipdzVqxxrJ/6AzwzFXd3wXflbmyoDUBnb7HlI4r0UB5JyNh6tgR729RTowWtBefw2nyCA G2NT8GD+f0E4NmQM60PTD/3FycA/cAoR5O6bFd6B06szqEYZ9KaZhylsyPsoGlG234mxsX ysYwSWkQ3bMkmC45vGXb778Ys73pAbA= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=f0xUxVnj; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690362273; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kQM+PipHAXSY7x2vlq6C7GWwn6O4D5U4rBQcpyXO4L8=; b=f0xUxVnjXlDyagC979iY+Jq51vge+XElef+Ujw3WeoXK5FtKM361e0nEGZ7QRTelEL0sM0 4BsMfRq139MNH6mGQVbL8ijBDc0vyqkhGZjUOMlJ8fA2rS35BLNhEHFdXEj9aXm/Zs09oP How9NkuHVuco5vlngUyoxQZ6THxjMdA= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-473-CrdOBexIP4OORuAZPPhdqg-1; Wed, 26 Jul 2023 05:04:32 -0400 X-MC-Unique: CrdOBexIP4OORuAZPPhdqg-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3fd2d331e1eso18701845e9.3 for ; Wed, 26 Jul 2023 02:04:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690362271; x=1690967071; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kQM+PipHAXSY7x2vlq6C7GWwn6O4D5U4rBQcpyXO4L8=; b=I7FivjkIXc7G7xCfVfqNlqTuABJ6BZ+SXLB13/kglzDkxmMqA3o6nt4vbMVhUOlsqj +5nJnEH/lTSn67PEIeDDvNbJ3JfIWc8fZq1+qzme1N+ZakmlgPt2ab2VvgCMK7AMqvnX f4kS5JmrO5rxSSXma8Oq8bBorsEN2NjLyHcOfeCngG9vkOaojjzL7J9Cb4bPqXfPM683 fxVn61yjtJvCv20Tk0M1w5+gQ/xHn6sajk1jLw0/48g3YDgXBNXvJO/1uC1Z9h8LErJf AjY2CvEp2wBXWoW5uvE7mvrXPDS9pnHVZZGzliEoV34NJpWmBlb6KQP+8jXwWWTAEWjc 0rDA== X-Gm-Message-State: ABy/qLarxiD+2vAp6RcBhN55frgSdwUBLaNQ1r7OlP/b0ryD9jp1JEB2 y9NRLkXhbtGuMfryz+LKn5rJCwuDsF1rvdIfr8dq30ziTaj2yk2mt/dWVF79edH4mhzRx0ZQBfC wqsAGEoZ63yE= X-Received: by 2002:a05:600c:11d2:b0:3f9:b19c:aab4 with SMTP id b18-20020a05600c11d200b003f9b19caab4mr893097wmi.6.1690362271304; Wed, 26 Jul 2023 02:04:31 -0700 (PDT) X-Google-Smtp-Source: APBJJlE0lzo2lrby4qhNhn+e2opJ7XFXzbxGfEajZ3lSim6VbbTZL0Zxf/A3kuImL0dfRNig2Uim0w== X-Received: by 2002:a05:600c:11d2:b0:3f9:b19c:aab4 with SMTP id b18-20020a05600c11d200b003f9b19caab4mr893080wmi.6.1690362270894; Wed, 26 Jul 2023 02:04:30 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:f600:a519:c50:799b:f1e3? (p200300cbc705f600a5190c50799bf1e3.dip0.t-ipconnect.de. [2003:cb:c705:f600:a519:c50:799b:f1e3]) by smtp.gmail.com with ESMTPSA id h14-20020a05600c260e00b003fbca942499sm1434784wma.14.2023.07.26.02.04.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jul 2023 02:04:30 -0700 (PDT) Message-ID: Date: Wed, 26 Jul 2023 11:04:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: "Aneesh Kumar K.V" , linux-mm@kvack.org, akpm@linux-foundation.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, npiggin@gmail.com, christophe.leroy@csgroup.eu Cc: Oscar Salvador , Michal Hocko , Vishal Verma References: <20230725100212.531277-1-aneesh.kumar@linux.ibm.com> <20230725100212.531277-5-aneesh.kumar@linux.ibm.com> <875y67xpsi.fsf@linux.ibm.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH v5 4/7] mm/hotplug: Support memmap_on_memory when memmap is not aligned to pageblocks In-Reply-To: <875y67xpsi.fsf@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: fs4ieskrqmoynnu7i4wa4are75ckn1c1 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 83BE6140024 X-Rspam-User: X-HE-Tag: 1690362274-785319 X-HE-Meta: U2FsdGVkX1/GGmOmE4RJdvblrdyMAsFxaQvwPMqlEdLN9cEehLxauzXDpM5HhWRljOnU9CbJEMai6l2l5/DElw8xevs9e/QJb9nETyxqnftvGVZeP3T5+h4X+LbcSrLcKMl3V4cgR+cGd6sFRVdNKZFwxe+0mr5Z98J0kd/U4TinlnZW306X4ECMkxx3x1KQDF48xCSQL4lvF8qGy7ihEhTga2TZZ9rJKeXLV2+N6pwAksFQTLCXOzkSnfqGirq2YjkE41KFFx91WS8pbuFMRYeK37orzez78wWMFCdILgRVkp65bzB4Z21XJ8E94v8KYgpjtlALcBtjh0+EQU76L6AM3p2goa+ZgQVaOqVf4/rssZi3A5L916ifldE9rQDoSGKWMc8dUc3CgbGOn0IiyUsQ17XYGkcu1a8u31DE9AKxY6jRRDtb9BQs3xSTVkE6mpr1i2RkJmUauNB9O940d5uoA/okjUU9EQH93k2LRPIzt9WiuNvNRUEe03Szyo/PIjxMrmVozHONtXwEzs3/0K7ZW/V0Vu3++JAJwrhgcFDPvuu7vK4gpYABoatWN96LZdorH5Za6IUuBGThgF8StFdSMnNIMNAxCzWxFLuyg6b8dq2Pl5euADgtYqerhKMAqdr9Pnce4keSeqjAhnu42T/6inPbsiuknits8Ot0H7iiJAMsCjPKMszZXKciGtHaz7Z3mre3MSp0pNERXcS/CRDo74k2Sgtk2uSodQnY+JxlGN6yryUxKMCtwdhD42DEOPMPY9UXab/Y1Efr/uIjANty8Ao8fVtTzr6g7SIx9WtgTFE7rrbVPaoQ+h3/VH9xC1YZ9GfwI7Z9MDSbRFEPcVVBCXdPfnLgc3E3yEFpcjX2InyrhVaRApIgyFo4PaYb6zU4voiUF8Ssr1q9APQJ1g6H0pEfqY0f6fhL5NUnk0sWGxOOJNPbDkanCurNYq0jZ0RzPt5g+NeHP+5IQ/Y 074jWYZA LkPJGwmfQColCT8h05bWJrq8lY0jVMCP2S84NV0mAHd/ZhRqAGwqjMq7DN0A37Qu6iB8hR4G5FpcjmdLVtjiAxYYFazqDMV/YBGmGNumUPoBNBfZmFBrhxqJpAi4QwfcLVQ6kucxN3QtXwj6IUflOsXWqrVnLbxnECuzHvF57fFC+L49OpP5Qsh5PFb0Iend7oEbL862AXISICAlY1Q605+cGjejSw+/Gui1iauY2q3d95O1N55UEXtjBZn4v9Hka+bONBfh7eZ1fEV6L606o8/LK5sSN1LsI3jHdv4CYyEQn54dRzTwWU8jvJPqral3KegWjll/QG9N6GBGkv1dulPNDUP9MMlXVcqbm+NkMpTuoYRpu0+PleuCL3n8Yb6471C6bwUMwLWe39it/wIow9vdufXbAeV3Lwc4YifnPuF9ye0w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >>> /* >>> @@ -1310,7 +1400,10 @@ int __ref add_memory_resource(int nid, struct resource *res, mhp_t mhp_flags) >>> { >>> struct mhp_params params = { .pgprot = pgprot_mhp(PAGE_KERNEL) }; >>> enum memblock_flags memblock_flags = MEMBLOCK_NONE; >>> - struct vmem_altmap mhp_altmap = {}; >>> + struct vmem_altmap mhp_altmap = { >>> + .base_pfn = PHYS_PFN(res->start), >>> + .end_pfn = PHYS_PFN(res->end), >> >> Is it required to set .end_pfn, and if so, shouldn't we also set it to >> base_pfn + memory_block_memmap_on_memory_pages()) ? >> > > We use that in ppc64 for checking altmap boundary condition. As we > discussed earlier, ppc64 due to vmemmap mapping size restrictions can't > always allocate vmemmap pages from altmap area even if requested. We > fallback to regular memory alocation in that case (only used now with > pmem). We use altmap.end_pfn for that boundary check. You can refer to > altmap_cross_boundary() for more details. But even then, setting the end to the end of the resource size is wrong, no? We don't want anybody to allocate beyond base_pfn + memory_block_memmap_on_memory_pages(). Apart from that, LGTM. -- Cheers, David / dhildenb