Re: [PATCH v6 1/6] mm/page_alloc: pageblock flags functions clean up.

[David Hildenbrand <david@redhat.com>]

On 30.05.25 18:22, Zi Yan wrote:
> No functional change is intended.
> 
> 1. Add __NR_PAGEBLOCK_BITS for the number of pageblock flag bits and use
>     roundup_pow_of_two(__NR_PAGEBLOCK_BITS) as NR_PAGEBLOCK_BITS to take
>     right amount of bits for pageblock flags.
> 2. Rename PB_migrate_skip to PB_compact_skip.
> 3. Add {get,set,clear}_pfnblock_bit() to operate one a standalone bit,
>     like PB_compact_skip.
> 3. Make {get,set}_pfnblock_flags_mask() internal functions and use
>     {get,set}_pfnblock_migratetype() for pageblock migratetype operations.
> 4. Move pageblock flags common code to get_pfnblock_bitmap_bitidx().
> 3. Use MIGRATETYPE_MASK to get the migratetype of a pageblock from its
>     flags.
> 4. Use PB_migrate_end in the definition of MIGRATETYPE_MASK instead of
>     PB_migrate_bits.
> 5. Add a comment on is_migrate_cma_folio() to prevent one from changing it
>     to use get_pageblock_migratetype() and causing issues.
> 

I would have further split this up. If your patch description is a list, 
it's usually a good indication that each item should be a separate patch.

In any case, nothing jumped at me

Acked-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb