public inbox for linux-mm@kvack.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: "Mika Penttilä" <mpenttil@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
	<linux-kernel@vger.kernel.org>,
	David Hildenbrand <david@kernel.org>,
	"Jason Gunthorpe" <jgg@nvidia.com>,
	Leon Romanovsky <leonro@nvidia.com>,
	"Alistair Popple" <apopple@nvidia.com>,
	Balbir Singh <balbirs@nvidia.com>, Zi Yan <ziy@nvidia.com>,
	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	"Mike Rapoport" <rppt@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	"Michal Hocko" <mhocko@suse.com>
Subject: Re: [PATCH v8 0/5] Migrate on fault for device pages
Date: Fri, 24 Apr 2026 14:23:04 -0700	[thread overview]
Message-ID: <aevfOMdaANt0lAUo@gsse-cloud1.jf.intel.com> (raw)
In-Reply-To: <3faef07e-5093-4d9f-bb1f-e9a1f2dc6100@redhat.com>

On Fri, Apr 24, 2026 at 07:50:37PM +0300, Mika Penttilä wrote:
> On 4/24/26 19:23, Andrew Morton wrote:
> 
> > On Tue, 14 Apr 2026 07:12:21 +0300 mpenttil@redhat.com wrote:
> >
> >> From: Mika Penttilä <mpenttil@redhat.com>
> >>
> >> Currently, the way device page faulting and migration works
> >> is not optimal, if you want to do both fault handling and
> >> migration at once.
> >>
> >> Being able to migrate not present pages (or pages mapped with incorrect
> >> permissions, eg. COW) to the GPU requires doing either of the
> >> following sequences:
> >>
> >> ...
> >>
> > Via which tree would it be best to upstream this?
> >
> >>  include/linux/hmm.h                    |  19 +-
> >>  include/linux/migrate.h                |  26 +-
> >>  lib/test_hmm.c                         | 101 ++-
> >>  lib/test_hmm_uapi.h                    |  19 +-
> >>  mm/Kconfig                             |   2 +
> >>  mm/hmm.c                               | 821 +++++++++++++++++++++++--
> >>  mm/migrate_device.c                    | 589 +++---------------
> >>  tools/testing/selftests/mm/hmm-tests.c |  54 ++
> >>  8 files changed, 1053 insertions(+), 578 deletions(-)
> > Looks like mm.git.
> >
> > It might be more useful to add it to a DRM tree if there's ongoing
> > development against this.  But please no upstreaming without good
> > review!
> >
> > Anyway, this is a bit dated and Sashiko AI review wasn't able to apply
> > the patches.  Nor was it able to apply v7 or v6.  So please refresh,
> > retest, resend?
> 
> It is against Linus tree v7.0, base-commit: 028ef9c96e96197026887c0f092424679298aae8,
> but applies and passes hmm selftests on mm trees as is.
> 
> I plan to do v9 refresh and maybe minor updates in week or so.
> 

It might be good to send a version which applies to drm-tip to
intel-xe@lists.freedesktop.org to trigger our CI too. I know tested an
earlier rev and everything seemed to be working but another round of
testing before merging is likely a good idea.

Matt

> --Mika
> 


  reply	other threads:[~2026-04-24 21:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-14  4:12 [PATCH v8 0/5] Migrate on fault for device pages mpenttil
2026-04-14  4:12 ` [PATCH v8 1/5] mm/Kconfig: changes for migrate " mpenttil
2026-04-14  4:12 ` [PATCH v8 2/5] mm: Add helper to convert HMM pfn to migrate pfn mpenttil
2026-04-14  4:12 ` [PATCH v8 3/5] mm/hmm: do the plumbing for HMM to participate in migration mpenttil
2026-04-14  4:12 ` [PATCH v8 4/5] mm: setup device page migration in HMM pagewalk mpenttil
2026-04-14  4:12 ` [PATCH v8 5/5] lib/test_hmm:: add a new testcase for the migrate on fault mpenttil
2026-04-24 16:23 ` [PATCH v8 0/5] Migrate on fault for device pages Andrew Morton
2026-04-24 16:50   ` Mika Penttilä
2026-04-24 21:23     ` Matthew Brost [this message]
2026-04-24 21:28       ` Mika Penttilä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aevfOMdaANt0lAUo@gsse-cloud1.jf.intel.com \
    --to=matthew.brost@intel.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=apopple@nvidia.com \
    --cc=balbirs@nvidia.com \
    --cc=david@kernel.org \
    --cc=jgg@nvidia.com \
    --cc=leonro@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mhocko@suse.com \
    --cc=mpenttil@redhat.com \
    --cc=rppt@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox