Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <baoquan.he@linux.dev>
To: Zijiang Huang <huangzjsmile@gmail.com>
Cc: chrisl@kernel.org, albinwyang@tencent.com, bhe@redhat.com,
	flyingpeng@tencent.com, kasong@tencent.com,
	kerayhuang@tencent.com, linux-mm@kvack.org
Subject: Re: [PATCH v2] mm/swap: Add cond_resched() in swap_reclaim_full_clusters to prevent softlockup
Date: Fri, 8 May 2026 21:49:31 +0800	[thread overview]
Message-ID: <af3p64XUDKCAv1Kn@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20260508113300.3977280-1-kerayhuang@tencent.com>

On 05/08/26 at 07:33pm, Zijiang Huang wrote:
> >On Wed, May 6, 2026 at 4:56=E2=80=AFPM Zijiang Huang <huangzjsmile@gmail.co=
> >m> wrote:
> >>
> >> We hit a real softlockup in an internal stress test environment.
> >> The workload was LTP memory/swap stress on a large arm64 machine,
> >> with 320 CPUs, about 1TB memory and an 8.6GB swap device.
> >> The system was under heavy load and the swap device had a large
> >> number of full clusters. The softlockup was triggered during
> >> a stress test after about 3 days.
> >>
> >> So, add periodic cond_resched() calls during large full_clusters
> >> reclaim operations to prevent softlockup issues.
> >Thank you for reporting and fixing this issue.
> > 
> >Can you add that to the patch commit log? This background information
> >is very important for the reader why this change is needed.
> > 
> >Assume you will update the commit log. 
> > 
> >Acked-by: Chris Li <chrisl@kernel.org>
> > 
> >Chris
> 
> Hi Chris, I've updated the commit log with the background information in v2. Thanks!

From my mail client, I see your v2 is in the same thread as v1. People
may mistaken it as a discussion reply. It's better to post v2
separately. You can resend v2 with reviewers' ack tag collected.



  reply	other threads:[~2026-05-08 13:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-24 12:37 [PATCH] mm/swap: Add cond_resched() in swap_reclaim_full_clusters to prevent softlockup kerayhuang
2026-04-24 15:39 ` Baoquan He
2026-04-29 12:49   ` kerayhuang
2026-05-01  2:43     ` Baoquan He
2026-05-06 13:09       ` [PATCH v2] " Zijiang Huang
2026-05-07  1:35         ` Baoquan He
2026-05-07  4:02         ` Chris Li
2026-05-08 11:33           ` Zijiang Huang
2026-05-08 13:49             ` Baoquan He [this message]
2026-05-08 21:29         ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af3p64XUDKCAv1Kn@MiWiFi-R3L-srv \
    --to=baoquan.he@linux.dev \
    --cc=albinwyang@tencent.com \
    --cc=bhe@redhat.com \
    --cc=chrisl@kernel.org \
    --cc=flyingpeng@tencent.com \
    --cc=huangzjsmile@gmail.com \
    --cc=kasong@tencent.com \
    --cc=kerayhuang@tencent.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox