Re: [PATCH 12/49] mm: make set_pageblock_order() static

Muchun Song
2026-04-29T03:02:33Z

> On Apr 28, 2026, at 15:17, Mike Rapoport <rppt@kernel.org> wrote:
>
> On Sun, Apr 05, 2026 at 08:52:03PM +0800, Muchun Song wrote:
>> Since set_pageblock_order() is only used in mm/mm_init.c now, make it
>> static and remove its declaration from mm/internal.h.
>> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
>
> The removal of set_pageblock_order() from sparse.c should be moved here as
> well :)

Will do.

> With that
>
> Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>

Thanks.

>
>> ---
>> mm/internal.h | 1 -
>> mm/mm_init.c | 4 ++--
>> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> --
> Sincerely yours,
> Mike.