From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71D42C54E49 for ; Thu, 7 Mar 2024 06:01:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E8A336B010B; Thu, 7 Mar 2024 01:01:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E3A536B010C; Thu, 7 Mar 2024 01:01:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D28DF6B010D; Thu, 7 Mar 2024 01:01:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C19A56B010B for ; Thu, 7 Mar 2024 01:01:24 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9069B404C3 for ; Thu, 7 Mar 2024 06:01:24 +0000 (UTC) X-FDA: 81869195688.07.63739CF Received: from out-177.mta1.migadu.com (out-177.mta1.migadu.com [95.215.58.177]) by imf15.hostedemail.com (Postfix) with ESMTP id 1917FA0019 for ; Thu, 7 Mar 2024 06:01:19 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=UdrEz7Ip; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf15.hostedemail.com: domain of yanjun.zhu@linux.dev designates 95.215.58.177 as permitted sender) smtp.mailfrom=yanjun.zhu@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709791282; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=60EtCnJ2FcNiwpYPsbvwvWYPwkzfqNpyu9Z59YrAUNk=; b=ALh1VJkKcx4z3pNvN7oxS+3kA7TQjw5sfVm1ZryfL3IKjwsjBjXO1o9hWH45Nm14wAbFlO mQRv2xG8A6qrOMPa9Y4Ua98E2vb35bxDauVLuHvFBP18IZGKXeC6Gdo+VbMnGevrQu1Trh zLbhv8pCuzkKbfOSP5f0ptKR0xujmp8= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=UdrEz7Ip; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf15.hostedemail.com: domain of yanjun.zhu@linux.dev designates 95.215.58.177 as permitted sender) smtp.mailfrom=yanjun.zhu@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709791282; a=rsa-sha256; cv=none; b=IRl1AKHuSPYXJzcJsyCCEp/qvzpXjzkM94CyGo+w8Gb14qhcDZu+Oh1boMGAbDCEOHad7p Cx2Em6/lKicagRqTqlRMMtcvHyvj9R5RL5Bi20e4y5mWUFl62G+cgeqS6vR1cqYCGuElzO aqASV2iZz+cTYc45xN33grCym/TWXw0= Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1709791277; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=60EtCnJ2FcNiwpYPsbvwvWYPwkzfqNpyu9Z59YrAUNk=; b=UdrEz7IpJ/hQTxYW/BcPojv+mE+JtKstiGC5/ykSqHqvqIVDyZD9EJtSOWlo6ETYFVgqq8 fosDmVE2Q9bLFrmKiozlqtdTnlwbbSCfR4CsiQiKbX+TKJa6MWcCol072W3TBMYup5s85G WD3PQttcSGwrC7B3Ln676VsoeTLnDmg= Date: Thu, 7 Mar 2024 07:01:10 +0100 MIME-Version: 1.0 Subject: Re: [RFC RESEND 00/16] Split IOMMU DMA mapping operation to two steps To: Leon Romanovsky , Christoph Hellwig , Robin Murphy , Marek Szyprowski , Joerg Roedel , Will Deacon , Jason Gunthorpe , Chaitanya Kulkarni Cc: Jonathan Corbet , Jens Axboe , Keith Busch , Sagi Grimberg , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Andrew Morton , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, kvm@vger.kernel.org, linux-mm@kvack.org, Bart Van Assche , Damien Le Moal , Amir Goldstein , "josef@toxicpanda.com" , "Martin K. Petersen" , "daniel@iogearbox.net" , Dan Williams , "jack@suse.com" , Leon Romanovsky , Zhu Yanjun References: X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Zhu Yanjun In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 1917FA0019 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 7hzwr68g5gm9oaruocrqcsyb5i775tqf X-HE-Tag: 1709791279-93223 X-HE-Meta: U2FsdGVkX18HdgJaOcyorQuQ6ZoncgwgL4z3XPxkESdcJHEK7bY/XrntAFIYXv6F+0bLWFLX3OpnTMHaTT6GrzD/ka/wMRv1URqgQqcWV3NUQfNatjn3y67IPUn4c2yXRC717s2oqIk9Ibmy3gPxlODi0dk+dvUKwYk9BfxALcH3EtFm9n3DLV59D+MqYZN4OOKUnglV8BYxneHSayxe/jq10zX6++ThJuSIaBond5XqqpvPa2ZJhX5sw9UfapkYnKoLnxjTHa8O8VPvXznVrIAId6tk3qYdCRCTQROVORYJjb1d+TfDsvI9Pnck5DiXz44hcC+pFQFibuojknXyWIoB7qijxazbD7mav1fokyuXsJYBJmgQSZ+DQQ+2J+Q493YXhYjtNECHPWVTglhiQT7nk0fpIsBjXsEunD2+qECf9hkImXVuhhmVFEj9FfvG3MncGjgsVBK3FjngJHzd2VM1PALEkJxNaG3RHc76rISQBOTP15rJ2hc46Y2JJ7EFfWTWRwVIbNrgTOKyjVKRlLuBadd/ouYqTehlNWQxSybBhnI7W9zuVk0/Eirf2XeaadS/t/hD9XrgWTphUonWQE+wlawfhYkwvxxKE5zcGgQxaRbf1g77h/jNPO+sa3aPCm2e/Y4CdoBxHFNzqlwbwXcdnRd5OJSOBFrYUB3VzZG4zT0l9hZORiiPu2VHRwMlyDC7w3BsH86Q7oIZPnkwodQjW2XwTjlTumaYWNT0miywbxRA9lqUbCuHjy8V9ePR3/z5lr9k5VXA9LDXjJsfSI5KaPes484YxQIrn+Crmi6H3wdjT3YDMqtS2jzm9FwfHjLs66e2dxh5JzFzRQSOP8jSTBEiIG1bQB41zTG2YBx3UromqMopW38g9Fd25Ahl3wy4wFopdwJ/odPlNwQAJMdnLT9HF4ACOA1p1MOw4H97rh7dpSeuvht0VACZOHS7Ob04XL5JtsFOeZN7/eK N3SJsWNy ZJnBCCE/ydDiVWRpK4CckRbgylNzrSml616W5SHlb8HNmoRtiOwV0aM/9RGyo7BYnbO3mSZUH01SbBaSK9oCmBH2g3cBYlJUDNvqjctLWWP6SY4LHS15Z6fSVMtX/eJ86eKreIJpgAAEA6d2cSUvs7bxcFaJiaLWWUHVlQwX9+PbP7lumpfhuUJEB7o7+Etfte7CzJJsvog7tGQVFS1drftdc5vYNcwuxNJ01YkMOS10ts/oYyAvcHOdwYh3NY9qslJqGnimkBEJf8E9wOVZAgfZgTQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2024/3/5 12:18, Leon Romanovsky 写道: > This is complimentary part to the proposed LSF/MM topic. > https://lore.kernel.org/linux-rdma/22df55f8-cf64-4aa8-8c0b-b556c867b926@linux.dev/T/#m85672c860539fdbbc8fe0f5ccabdc05b40269057 I am interested in this topic. Hope I can join the meeting to discuss this topic. Zhu Yanjun > > This is posted as RFC to get a feedback on proposed split, but RDMA, VFIO and > DMA patches are ready for review and inclusion, the NVMe patches are still in > progress as they require agreement on API first. > > Thanks > > ------------------------------------------------------------------------------- > The DMA mapping operation performs two steps at one same time: allocates > IOVA space and actually maps DMA pages to that space. This one shot > operation works perfectly for non-complex scenarios, where callers use > that DMA API in control path when they setup hardware. > > However in more complex scenarios, when DMA mapping is needed in data > path and especially when some sort of specific datatype is involved, > such one shot approach has its drawbacks. > > That approach pushes developers to introduce new DMA APIs for specific > datatype. For example existing scatter-gather mapping functions, or > latest Chuck's RFC series to add biovec related DMA mapping [1] and > probably struct folio will need it too. > > These advanced DMA mapping APIs are needed to calculate IOVA size to > allocate it as one chunk and some sort of offset calculations to know > which part of IOVA to map. > > Instead of teaching DMA to know these specific datatypes, let's separate > existing DMA mapping routine to two steps and give an option to advanced > callers (subsystems) perform all calculations internally in advance and > map pages later when it is needed. > > In this series, three users are converted and each of such conversion > presents different positive gain: > 1. RDMA simplifies and speeds up its pagefault handling for > on-demand-paging (ODP) mode. > 2. VFIO PCI live migration code saves huge chunk of memory. > 3. NVMe PCI avoids intermediate SG table manipulation and operates > directly on BIOs. > > Thanks > > [1] https://lore.kernel.org/all/169772852492.5232.17148564580779995849.stgit@klimt.1015granger.net > > Chaitanya Kulkarni (2): > block: add dma_link_range() based API > nvme-pci: use blk_rq_dma_map() for NVMe SGL > > Leon Romanovsky (14): > mm/hmm: let users to tag specific PFNs > dma-mapping: provide an interface to allocate IOVA > dma-mapping: provide callbacks to link/unlink pages to specific IOVA > iommu/dma: Provide an interface to allow preallocate IOVA > iommu/dma: Prepare map/unmap page functions to receive IOVA > iommu/dma: Implement link/unlink page callbacks > RDMA/umem: Preallocate and cache IOVA for UMEM ODP > RDMA/umem: Store ODP access mask information in PFN > RDMA/core: Separate DMA mapping to caching IOVA and page linkage > RDMA/umem: Prevent UMEM ODP creation with SWIOTLB > vfio/mlx5: Explicitly use number of pages instead of allocated length > vfio/mlx5: Rewrite create mkey flow to allow better code reuse > vfio/mlx5: Explicitly store page list > vfio/mlx5: Convert vfio to use DMA link API > > Documentation/core-api/dma-attributes.rst | 7 + > block/blk-merge.c | 156 ++++++++++++++ > drivers/infiniband/core/umem_odp.c | 219 +++++++------------ > drivers/infiniband/hw/mlx5/mlx5_ib.h | 1 + > drivers/infiniband/hw/mlx5/odp.c | 59 +++-- > drivers/iommu/dma-iommu.c | 129 ++++++++--- > drivers/nvme/host/pci.c | 220 +++++-------------- > drivers/vfio/pci/mlx5/cmd.c | 252 ++++++++++++---------- > drivers/vfio/pci/mlx5/cmd.h | 22 +- > drivers/vfio/pci/mlx5/main.c | 136 +++++------- > include/linux/blk-mq.h | 9 + > include/linux/dma-map-ops.h | 13 ++ > include/linux/dma-mapping.h | 39 ++++ > include/linux/hmm.h | 3 + > include/rdma/ib_umem_odp.h | 22 +- > include/rdma/ib_verbs.h | 54 +++++ > kernel/dma/debug.h | 2 + > kernel/dma/direct.h | 7 +- > kernel/dma/mapping.c | 91 ++++++++ > mm/hmm.c | 34 +-- > 20 files changed, 870 insertions(+), 605 deletions(-) >