From: Oscar Salvador <osalvador@suse.de>
To: Sang-Heon Jeon <ekffu200098@gmail.com>
Cc: muchun.song@linux.dev, david@kernel.org,
akpm@linux-foundation.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm/hugetlb_cma: restrict hugetlb_cma parameter to gigantic-page alignment
Date: Mon, 11 May 2026 10:23:21 +0200 [thread overview]
Message-ID: <agGR-YfOK0hh1YEX@localhost.localdomain> (raw)
In-Reply-To: <20260503084225.415980-1-ekffu200098@gmail.com>
On Sun, May 03, 2026 at 05:42:25PM +0900, Sang-Heon Jeon wrote:
> Existing hugetlb_cma parameter handling logic rejects sizes smaller than
> one gigantic page, but rounds up larger sizes that are not a multiple
> of it. The two behaviors are inconsistent and neither is documented.
>
> To remove existing inconsistent and undefined behavior, restrict
> hugetlb_cma parameter to only accept multiples of the gigantic page size.
>
> After this restriction, the redundant round_up() in the allocation loop
> can be removed.
>
> The new restriction is also documented in kernel-parameters.txt.
>
> Also, including other minor changes for readability improvement with no
> functional change.
>
> Suggested-by: Muchun Song <muchun.song@linux.dev>
> Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
Acked-by: Oscar Salvador <osalvador@suse.de>
--
Oscar Salvador
SUSE Labs
prev parent reply other threads:[~2026-05-11 8:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-03 8:42 [PATCH] mm/hugetlb_cma: restrict hugetlb_cma parameter to gigantic-page alignment Sang-Heon Jeon
2026-05-11 2:52 ` Muchun Song
2026-05-11 8:23 ` Oscar Salvador [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agGR-YfOK0hh1YEX@localhost.localdomain \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=ekffu200098@gmail.com \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox