Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Pasha Tatashin <pasha.tatashin@soleen.com>
To: Pratyush Yadav <pratyush@kernel.org>
Cc: Pasha Tatashin <pasha.tatashin@soleen.com>,
	rppt@kernel.org,  sourabhjain@linux.ibm.com, jbouron@amazon.com,
	akpm@linux-foundation.org,  linux-mm@kvack.org, bhe@redhat.com,
	linux-kernel@vger.kernel.org,  dan.carpenter@linaro.org,
	rafael.j.wysocki@intel.com, piliu@redhat.com,
	 kexec@lists.infradead.org, graf@amazon.com,
	changyuanl@google.com,  mario.limonciello@amd.com
Subject: Re: [PATCH v2 3/3] liveupdate: block outgoing session mutations
Date: Mon, 11 May 2026 09:44:08 -0400	[thread overview]
Message-ID: <agHcu9_eSolgNZFT@google.com> (raw)
In-Reply-To: <2vxzv7cucint.fsf@kernel.org>

On 05-11 13:03, Pratyush Yadav wrote:
> On Wed, May 06 2026, Pasha Tatashin wrote:
> 
> > During the reboot() syscall, user processes may still be running
> > concurrently and attempting to mutate sessions (e.g., adding files or
> > closing sessions). To prevent this, hold the session header's rwsem and
> > each session's mutex indefinitely on successful serialization.
> >
> > If serialization succeeds, these locks will never be released as the
> > system transitions to the new kernel, effectively blocking any
> > concurrent task attempting to modify or release a session. If
> > liveupdate_reboot() fails, the locks are released in the error path,
> > allowing normal operation to resume.
> >
> > Fixes: 0153094d03df ("liveupdate: luo_session: add sessions support")
> > Reported-by: Oskar Gerlicz Kowalczuk <oskar@gerlicz.space>
> > Signed-off-by: Pasha Tatashin <pasha.tatashin@soleen.com>
> 
> Reviewed-by: Pratyush Yadav (Google) <pratyush@kernel.org>

Sashiko also provided a good comment about this patch: We run over 
MAX_LOCK_DEPTH limit with this patch. I am going to refactor to not take 
every session lock simultaneously during serialization.

> 
> [...]
> 
> -- 
> Regards,
> Pratyush Yadav


      reply	other threads:[~2026-05-11 13:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-06 18:20 [PATCH v2 0/3] liveupdate: serialization safety and race fixes Pasha Tatashin
2026-05-06 18:20 ` [PATCH v2 1/3] kho: skip KHO data for context-preserving kexec Pasha Tatashin
2026-05-11 10:38   ` Mike Rapoport
2026-05-11 11:16     ` Pratyush Yadav
2026-05-11 13:11     ` Pasha Tatashin
2026-05-11 11:00   ` Pratyush Yadav
2026-05-06 18:20 ` [PATCH v2 2/3] liveupdate: skip serialization " Pasha Tatashin
2026-05-06 18:20 ` [PATCH v2 3/3] liveupdate: block outgoing session mutations Pasha Tatashin
2026-05-11 11:03   ` Pratyush Yadav
2026-05-11 13:44     ` Pasha Tatashin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=agHcu9_eSolgNZFT@google.com \
    --to=pasha.tatashin@soleen.com \
    --cc=akpm@linux-foundation.org \
    --cc=bhe@redhat.com \
    --cc=changyuanl@google.com \
    --cc=dan.carpenter@linaro.org \
    --cc=graf@amazon.com \
    --cc=jbouron@amazon.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mario.limonciello@amd.com \
    --cc=piliu@redhat.com \
    --cc=pratyush@kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=rppt@kernel.org \
    --cc=sourabhjain@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox