Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <baoquan.he@linux.dev>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org, chrisl@kernel.org,
	usama.arif@linux.dev, baohua@kernel.org, kasong@tencent.com,
	nphamcs@gmail.com, shikemeng@huaweicloud.com,
	youngjun.park@lge.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/3] mm/swap: use swap_ops to register swap device's methods
Date: Wed, 13 May 2026 23:38:22 +0800	[thread overview]
Message-ID: <agSa7j_6iODbMsmo@MiWiFi-R3L-srv> (raw)
In-Reply-To: <agQQCeJSAjBkg5FW@infradead.org>

On 05/12/26 at 10:45pm, Christoph Hellwig wrote:
> Looking a bit more I also think this abastraction is still leaky because
> the unplug calls for fs based swap aren't properly abstracted out.

Right, and this can be easily done by adding a unplug callback in
swap_ops.

> 
> (note that it would make sense to use them for block based swap as well,
> as building a single bio will be a lot more efficient than relying on
> block layer plugging, but that's a separate issue)

OK, look forward to seeing it from your post.



  reply	other threads:[~2026-05-13 15:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 10:41 [PATCH v6 0/3] mm/swap: use swap_ops to register swap device's methods Baoquan He
2026-05-12 10:41 ` [PATCH v6 1/3] mm/swap: rename mm/page_io.c to mm/swap_io.c Baoquan He
2026-05-13  0:27   ` Chris Li
2026-05-13  5:21   ` Christoph Hellwig
2026-05-13  7:10     ` Baoquan He
2026-05-12 10:42 ` [PATCH v6 2/3] mm/swap: use swap_ops to register swap device's methods Baoquan He
2026-05-12 17:53   ` Kairui Song
2026-05-13  5:32   ` Christoph Hellwig
2026-05-13 15:33     ` Baoquan He
2026-05-13  5:45   ` Christoph Hellwig
2026-05-13 15:38     ` Baoquan He [this message]
2026-05-12 10:42 ` [PATCH v6 3/3] mm/swap_io.c: rename swap_writepage_* to swap_write_folio_* Baoquan He
2026-05-12 17:54   ` Kairui Song
2026-05-13  0:31   ` Chris Li
2026-05-13  5:36   ` Christoph Hellwig
2026-05-13 15:44     ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=agSa7j_6iODbMsmo@MiWiFi-R3L-srv \
    --to=baoquan.he@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=chrisl@kernel.org \
    --cc=hch@infradead.org \
    --cc=kasong@tencent.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nphamcs@gmail.com \
    --cc=shikemeng@huaweicloud.com \
    --cc=usama.arif@linux.dev \
    --cc=youngjun.park@lge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox