From: Mike Rapoport <rppt@kernel.org>
To: Li Zhe <lizhe.67@bytedance.com>
Cc: tglx@kernel.org, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, arnd@arndb.de,
akpm@linux-foundation.org, david@kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 0/4] mm: speed up ZONE_DEVICE memmap initialization
Date: Mon, 18 May 2026 09:23:33 +0300 [thread overview]
Message-ID: <agqwZaEtwXg4-O9z@kernel.org> (raw)
In-Reply-To: <20260515082045.63029-1-lizhe.67@bytedance.com>
Hi,
On Fri, May 15, 2026 at 04:20:41PM +0800, Li Zhe wrote:
> memmap_init_zone_device() can spend a substantial amount of time
> initializing large ZONE_DEVICE ranges because it repeats nearly
> identical struct page setup for every PFN.
>
> This series reduces that overhead in four steps.
>
> Testing
> =======
>
> Tests were run in a VM on an Intel Ice Lake server.
>
> Two PMEM configurations were used:
> - a 100 GB fsdax namespace configured with map=dev, which exercises
> the nd_pmem rebind path (pfns_per_compound == 1)
> - a 100 GB devdax namespace configured with align=2097152, which
> exercises the dax_pmem rebind path (pfns_per_compound > 1)
>
> For each configuration, the corresponding driver was unbound and
> rebound 30 times. Memmap initialization latency was collected from the
> pr_debug() output of memmap_init_zone_device().
>
> The first bind is reported separately, and the average of subsequent
> rebinds is used as the steady-state result.
>
> Performance
> ===========
> nd_pmem rebind, 100 GB fsdax namespace, map=dev
> Base(v7.1-rc3):
> First binding: 1486 ms
> Average of subsequent rebinds: 273.52 ms
> Full series:
> First binding: 1272 ms
> Average of subsequent rebinds: 104.59 ms
>
> dax_pmem rebind, 100 GB devdax namespace, align=2097152
> Base(v7.1-rc3):
> First binding: 1515 ms
> Average of subsequent rebinds: 313.45 ms
> Full series:
> First binding: 1286 ms
> Average of subsequent rebinds: 116.93 ms
This is really good improvement!
It would be also interesting to see how the template approach would improve
"normal" memory map initialization.
> Li Zhe (4):
> mm: factor zone-device page init helpers out of
> __init_zone_device_page
> mm: add a template-based fast path for zone-device page init
> mm: extend the template fast path to zone-device compound tails
> mm: use arch store helpers in zone-device template copies
>
> arch/x86/include/asm/struct_page_init.h | 28 +++
> include/asm-generic/Kbuild | 1 +
> include/asm-generic/struct_page_init.h | 17 ++
> mm/mm_init.c | 260 +++++++++++++++++++++---
> 4 files changed, 280 insertions(+), 26 deletions(-)
> create mode 100644 arch/x86/include/asm/struct_page_init.h
> create mode 100644 include/asm-generic/struct_page_init.h
>
> --
> 2.20.1
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2026-05-18 6:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 8:20 [PATCH 0/4] mm: speed up ZONE_DEVICE memmap initialization Li Zhe
2026-05-15 8:20 ` [PATCH 1/4] mm: factor zone-device page init helpers out of __init_zone_device_page Li Zhe
2026-05-18 6:32 ` Mike Rapoport
2026-05-18 9:11 ` Li Zhe
2026-05-15 8:20 ` [PATCH 2/4] mm: add a template-based fast path for zone-device page init Li Zhe
2026-05-18 6:51 ` Mike Rapoport
2026-05-18 9:54 ` Li Zhe
2026-05-18 11:42 ` Mike Rapoport
2026-05-15 8:20 ` [PATCH 3/4] mm: extend the template fast path to zone-device compound tails Li Zhe
2026-05-15 8:20 ` [PATCH 4/4] mm: use arch store helpers in zone-device template copies Li Zhe
2026-05-18 0:32 ` Alistair Popple
2026-05-18 6:42 ` Li Zhe
2026-05-19 3:09 ` Balbir Singh
2026-05-18 6:23 ` Mike Rapoport [this message]
2026-05-18 8:57 ` [PATCH 0/4] mm: speed up ZONE_DEVICE memmap initialization Li Zhe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agqwZaEtwXg4-O9z@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=david@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizhe.67@bytedance.com \
--cc=mingo@redhat.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox