From: Dan Carpenter <error27@gmail.com>
To: "kasong(宋恺睿)" <kasong@tencent.com>
Cc: Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: 回复：[Internet][bug report] mm, swap: add support for stable large allocation in swap cache directly
Date: Tue, 2 Jun 2026 11:38:49 +0300 [thread overview]
Message-ID: <ah6WmXpArORmRcbd@stanley.mountain> (raw)
In-Reply-To: <tencent_563412614416DBC00F511C21@qq.com>
On Tue, Jun 02, 2026 at 04:21:40PM +0800, kasong(宋恺睿) wrote:
> Hello Dan
>
>
> Currently, no caller in kernel will pass NULL mpol with NULL vmf with CONFIG_NUMA. Do do_swap_page always have vmf set, and shmem always have either vmf or mpol set (unless !CONFIG_NUMA).
>
>
> I used to have a WARN_ON for this but some AI reviewers complained that the WARN_ON is redundant so I removed it. I can add that back later just to be safer, I will add a Reported-by for you. Is that OK?
>
Nah, don't worry. If it's a non-NUMA thing then that makes sense.
I was hoping we could just remove the !vmf part fo the check.
regards,
dan carpenter
prev parent reply other threads:[~2026-06-02 8:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 8:21 回复：[Internet][bug report] mm, swap: add support for stable large allocation in swap cache directly kasong(宋恺睿)
2026-06-02 8:38 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ah6WmXpArORmRcbd@stanley.mountain \
--to=error27@gmail.com \
--cc=kasong@tencent.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox