From: Lorenzo Stoakes <ljs@kernel.org>
To: Barry Song <baohua@kernel.org>
Cc: ranxiaokai627@163.com, hughd@google.com,
baolin.wang@linux.alibaba.com, akpm@linux-foundation.org,
leitao@debian.org, ziy@nvidia.com, liam@infradead.org,
npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com,
lance.yang@linux.dev, david@kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, ran.xiaokai@zte.com.cn
Subject: Re: [PATCH v3 2/2] mm: shmem: refactor thpsize_shmem_enabled_show() with helper arrays
Date: Fri, 22 May 2026 11:56:31 +0100 [thread overview]
Message-ID: <ahA2QHD439djStXc@lucifer> (raw)
In-Reply-To: <CAGsJ_4xCDhj97=4pFrwg1-Cfh5MMpBn=yV=VLrCf1PYcjY+EOg@mail.gmail.com>
On Fri, May 22, 2026 at 06:44:18PM +0800, Barry Song wrote:
> On Fri, May 22, 2026 at 6:35 PM Lorenzo Stoakes <ljs@kernel.org> wrote:
> >
> > On Mon, May 18, 2026 at 12:32:38PM +0000, ranxiaokai627@163.com wrote:
> > > From: Ran Xiaokai <ran.xiaokai@zte.com.cn>
> > >
> > > Replace the hardcoded if/else chain of test_bit() calls and string
> > > literals in thpsize_shmem_enabled_show() with a loop over
> > > huge_shmem_orders_by_mode[] and huge_shmem_enabled_mode_strings[] arrays.
> > >
> > > This makes thpsize_shmem_enabled_show() consistent with
> > > thpsize_shmem_enabled_store() and eliminates duplicated mode name strings.
> > >
> > > Signed-off-by: Ran Xiaokai <ran.xiaokai@zte.com.cn>
> >
> > From: ranxiaokai627@163.com
> >
> > This does not match the From: field of the email.
> >
> > This is violating kernel process. See
> > https://docs.kernel.org/process/submitting-patches.html
>
> I’m not aware of this rule, since I usually see From matching
> Signed-off-by. Do we really have such a rule? Sorry, I might be a
> bit ignorant about this 🙂
We do yes.
But I was wrong here, as the From: field was provided inline (doing that and
including the From: field in the To/Cc I think suffices).
>
> >
> > Please either update this to your 163 email account or resend from your
> > zte.com.cn address, otherwise we can't take this.
> >
> > Cheers, Lorenzo
> >
Cheers, Lorenzo
next prev parent reply other threads:[~2026-05-22 10:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260518123238.56344-1-ranxiaokai627@163.com>
[not found] ` <20260518123238.56344-3-ranxiaokai627@163.com>
2026-05-21 13:18 ` [PATCH v3 2/2] mm: shmem: refactor thpsize_shmem_enabled_show() with helper arrays Lance Yang
2026-05-22 10:34 ` Lorenzo Stoakes
2026-05-22 10:44 ` Barry Song
2026-05-22 10:56 ` Lorenzo Stoakes [this message]
2026-05-22 10:54 ` Lorenzo Stoakes
2026-05-22 11:36 ` Barry Song
[not found] ` <20260518123238.56344-2-ranxiaokai627@163.com>
2026-05-19 2:22 ` [PATCH v3 1/2] mm: shmem: refactor thpsize_shmem_enabled_store() with sysfs_match_string() Baolin Wang
2026-05-21 13:17 ` Lance Yang
2026-05-22 8:07 ` Barry Song
2026-05-22 10:39 ` Lorenzo Stoakes
2026-05-22 10:55 ` Lorenzo Stoakes
2026-05-25 7:52 ` ranxiaokai627
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahA2QHD439djStXc@lucifer \
--to=ljs@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=hughd@google.com \
--cc=lance.yang@linux.dev \
--cc=leitao@debian.org \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npache@redhat.com \
--cc=ran.xiaokai@zte.com.cn \
--cc=ranxiaokai627@163.com \
--cc=ryan.roberts@arm.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox