From: Mike Rapoport <rppt@kernel.org>
To: Hongfu Li <lihongfu@kylinos.cn>
Cc: akpm@linux-foundation.org, david@kernel.org, liam@infradead.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-mm@kvack.org, ljs@kernel.org, mhocko@suse.com,
shuah@kernel.org, surenb@google.com, vbabka@kernel.org
Subject: Re: [PATCH v3 1/2] selftests/mm: refactor pkey test helpers and unify assertions
Date: Thu, 28 May 2026 14:11:28 +0300 [thread overview]
Message-ID: <ahgi4I3_hHZK4HdY@kernel.org> (raw)
In-Reply-To: <20260528091300.2082967-1-lihongfu@kylinos.cn>
On Thu, May 28, 2026 at 05:13:00PM +0800, Hongfu Li wrote:
> Hi Mike,
> Thanks for the review comments.
>
> > > Move shared tracing and assertion helpers to a common file, then
> > > convert the sighandler test to use pkey_assert() for consistent
> > > diagnostic output, and add per-test tracing around test execution.
> >
> > This sounds like three patches to me.
>
> Got it, should I split this into three individual patches?
Yes please.
> Best regards,
> Hongfu
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2026-05-28 11:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 1:38 [PATCH v3 0/2] selftests/mm: refactor pkey helpers and fix mmap error handling Hongfu Li
2026-05-27 1:38 ` [PATCH v3 1/2] selftests/mm: refactor pkey test helpers and unify assertions Hongfu Li
2026-05-27 11:32 ` Mike Rapoport
2026-05-28 9:13 ` Hongfu Li
2026-05-28 11:11 ` Mike Rapoport [this message]
2026-05-27 1:38 ` [PATCH v3 2/2] selftests/mm: add missing mmap() return checks in pkey tests Hongfu Li
2026-05-27 11:36 ` Mike Rapoport
2026-05-28 8:57 ` Hongfu Li
2026-05-28 11:15 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahgi4I3_hHZK4HdY@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=liam@infradead.org \
--cc=lihongfu@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox