Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Rapoport <rppt@kernel.org>
To: Hongfu Li <lihongfu@kylinos.cn>
Cc: akpm@linux-foundation.org, david@kernel.org, ljs@kernel.org,
	liam@infradead.org, vbabka@kernel.org, surenb@google.com,
	mhocko@suse.com, shuah@kernel.org, linux-mm@kvack.org,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 0/5] selftests/mm: refactor pkey helpers and fix mmap error handling
Date: Fri, 5 Jun 2026 09:18:44 +0300	[thread overview]
Message-ID: <aiJqRNerYkMIo8kV@kernel.org> (raw)
In-Reply-To: <20260602070119.1452308-1-lihongfu@kylinos.cn>

Hi,

On Tue, Jun 02, 2026 at 03:01:14PM +0800, Hongfu Li wrote:
> The main changes in this series are to refactor shared tracing and assertion
> helpers into a common file, unify both pkey selftests on pkey_assert() and 
> per-test tracing for consistent diagnostics, and add missing mmap() return 
> checks with MAP_FAILED used throughout for readability and consistency.

We are too close to the merge window and this is not an urgent fix.
Please wait until -rc1 and then rebase and resend you patches.

Thanks!
 
> Hongfu Li (5):
>   selftests/mm: move pkey selftest helpers to pkey_util.c
>   selftests/mm: unify pkey sighandler selftest assertions and tracing
>   selftests/mm: use pkey_assert on clone_raw failure in pkey test
>   selftests/mm: add missing mmap() return checks in pkey tests
>   selftests/mm: add missing pthread_create() return checks in pkey tests
> 
>  tools/testing/selftests/mm/pkey-helpers.h     |  4 +-
>  tools/testing/selftests/mm/pkey-powerpc.h     |  2 +-
>  .../selftests/mm/pkey_sighandler_tests.c      | 81 ++++++++--------
>  tools/testing/selftests/mm/pkey_util.c        | 86 +++++++++++++++++
>  tools/testing/selftests/mm/protection_keys.c  | 95 ++-----------------
>  5 files changed, 141 insertions(+), 127 deletions(-)

-- 
Sincerely yours,
Mike.


  parent reply	other threads:[~2026-06-05  6:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-02  7:01 [PATCH v6 0/5] selftests/mm: refactor pkey helpers and fix mmap error handling Hongfu Li
2026-06-02  7:01 ` [PATCH v6 1/5] selftests/mm: move pkey selftest helpers to pkey_util.c Hongfu Li
2026-06-02  7:01 ` [PATCH v6 2/5] selftests/mm: unify pkey sighandler selftest assertions and tracing Hongfu Li
2026-06-02  7:01 ` [PATCH v6 3/5] selftests/mm: use pkey_assert on clone_raw failure in pkey test Hongfu Li
2026-06-02  7:01 ` [PATCH v6 4/5] selftests/mm: add missing mmap() return checks in pkey tests Hongfu Li
2026-06-02  7:01 ` [PATCH v6 5/5] selftests/mm: add missing pthread_create() " Hongfu Li
2026-06-05  6:18 ` Mike Rapoport [this message]
2026-06-05  7:32   ` [PATCH v6 0/5] selftests/mm: refactor pkey helpers and fix mmap error handling Hongfu Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aiJqRNerYkMIo8kV@kernel.org \
    --to=rppt@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=david@kernel.org \
    --cc=liam@infradead.org \
    --cc=lihongfu@kylinos.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=shuah@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox