From: Lorenzo Stoakes <ljs@kernel.org>
To: Zi Yan <ziy@nvidia.com>
Cc: Gregory Price <gourry@gourry.net>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org, kernel-team@meta.com,
longman@redhat.com, chenridong@huaweicloud.com,
akpm@linux-foundation.org, david@kernel.org, liam@infradead.org,
vbabka@kernel.org, rppt@kernel.org, surenb@google.com,
mhocko@suse.com, kasong@tencent.com, qi.zheng@linux.dev,
shakeel.butt@linux.dev, baohua@kernel.org,
axelrasmussen@google.com, yuanchu@google.com,
weixugc@google.com, rientjes@google.com, chrisl@kernel.org,
shikemeng@huaweicloud.com, nphamcs@gmail.com,
baoquan.he@linux.dev, youngjun.park@lge.com, tj@kernel.org,
hannes@cmpxchg.org, mkoutny@suse.com, jackmanb@google.com
Subject: Re: [PATCH] mm: constify oom_control, scan_control, and alloc_context nodemask
Date: Tue, 9 Jun 2026 08:39:22 +0100 [thread overview]
Message-ID: <aifC9s9X6hLWdKkd@lucifer> (raw)
In-Reply-To: <8C4E5377-F5CF-458E-BA49-3D962CB75477@nvidia.com>
On Mon, Jun 08, 2026 at 09:44:42PM -0400, Zi Yan wrote:
> On 8 Jun 2026, at 20:29, Gregory Price wrote:
>
> > The nodemasks in these structures may come from a variety of sources,
> > including tasks and cpusets - and should never be modified by any code
> > when being passed around inside another context.
> >
> > Signed-off-by: Gregory Price <gourry@gourry.net>
> > ---
> > include/linux/cpuset.h | 4 ++--
> > include/linux/mm.h | 4 ++--
> > include/linux/mmzone.h | 6 +++---
> > include/linux/oom.h | 2 +-
> > include/linux/swap.h | 2 +-
> > kernel/cgroup/cpuset.c | 2 +-
> > mm/internal.h | 2 +-
> > mm/mmzone.c | 5 +++--
> > mm/page_alloc.c | 6 +++---
> > mm/show_mem.c | 9 ++++++---
> > mm/vmscan.c | 6 +++---
> > 11 files changed, 26 insertions(+), 22 deletions(-)
> >
>
> LGTM and it compiles. As long as Sashiko does not complain, feel free to
> add:
I would add caveats of:
- Complains legitimately
- And it's about this actual patch not something unrelated
:P
(Not speaking for Zi of course, but I mean just in general I feel these caveats
should be implicit :))
>
> Acked-by: Zi Yan <ziy@nvidia.com>
>
> Best Regards,
> Yan, Zi
Cheers, Lorenzo
next prev parent reply other threads:[~2026-06-09 7:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 0:29 [PATCH] mm: constify oom_control, scan_control, and alloc_context nodemask Gregory Price
2026-06-09 1:44 ` Zi Yan
2026-06-09 7:39 ` Lorenzo Stoakes [this message]
2026-06-09 14:43 ` Zi Yan
2026-06-09 15:41 ` Gregory Price
2026-06-09 7:41 ` Lorenzo Stoakes
2026-06-09 9:37 ` David Hildenbrand (Arm)
2026-06-09 15:42 ` Gregory Price
2026-06-09 7:48 ` Barry Song
2026-06-09 9:59 ` Vlastimil Babka (SUSE)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aifC9s9X6hLWdKkd@lucifer \
--to=ljs@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=baohua@kernel.org \
--cc=baoquan.he@linux.dev \
--cc=cgroups@vger.kernel.org \
--cc=chenridong@huaweicloud.com \
--cc=chrisl@kernel.org \
--cc=david@kernel.org \
--cc=gourry@gourry.net \
--cc=hannes@cmpxchg.org \
--cc=jackmanb@google.com \
--cc=kasong@tencent.com \
--cc=kernel-team@meta.com \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=longman@redhat.com \
--cc=mhocko@suse.com \
--cc=mkoutny@suse.com \
--cc=nphamcs@gmail.com \
--cc=qi.zheng@linux.dev \
--cc=rientjes@google.com \
--cc=rppt@kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=shikemeng@huaweicloud.com \
--cc=surenb@google.com \
--cc=tj@kernel.org \
--cc=vbabka@kernel.org \
--cc=weixugc@google.com \
--cc=youngjun.park@lge.com \
--cc=yuanchu@google.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox