Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Rapoport <rppt@kernel.org>
To: Muchun Song <songmuchun@bytedance.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Oscar Salvador <osalvador@suse.de>,
	David Hildenbrand <david@kernel.org>,
	linux-mm@kvack.org, Vlastimil Babka <vbabka@kernel.org>,
	Lorenzo Stoakes <ljs@kernel.org>, Michal Hocko <mhocko@suse.com>,
	linux-kernel@vger.kernel.org, muchun.song@linux.dev
Subject: Re: [PATCH 08/17] mm/sparse: mark memory sections present earlier
Date: Thu, 9 Jul 2026 13:54:35 +0300	[thread overview]
Message-ID: <ak996_21b-jxYLGV@kernel.org> (raw)
In-Reply-To: <20260702093821.2740183-9-songmuchun@bytedance.com>

On Thu, Jul 02, 2026 at 05:38:12PM +0800, Muchun Song wrote:
> Upcoming HugeTLB bootmem changes need sparsemem section metadata before
> the HugeTLB bootmem allocation path runs. The memblock ranges are marked
> present from sparse_init(), which is called too late for that setup.

It's not only that memblock regions are marked present, but it actually
initializes mem_section's for the present memory ...
 
> Move the code that marks memblock ranges present into
> mm_core_init_early(), before free_area_init() and the HugeTLB bootmem
> setup. Rename the helper to sparse_memblock_present() to make the new

... so let's name this function to reflect that.

How about sparse_sections_init()?

> caller describe the sparsemem-specific initialization step.
> 
> This is a preparatory change.
> 
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> ---
>  mm/internal.h | 2 ++
>  mm/mm_init.c  | 1 +
>  mm/sparse.c   | 4 +---
>  3 files changed, 4 insertions(+), 3 deletions(-)

-- 
Sincerely yours,
Mike.


  parent reply	other threads:[~2026-07-09 10:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260702093821.2740183-1-songmuchun@bytedance.com>
     [not found] ` <20260702093821.2740183-5-songmuchun@bytedance.com>
2026-07-09 10:45   ` [PATCH 04/17] mm/mm_init: skip initializing shared vmemmap tail pages Mike Rapoport
2026-07-09 12:31     ` Muchun Song
2026-07-09 13:05       ` Mike Rapoport
2026-07-09 13:23         ` Muchun Song
     [not found] ` <20260702093821.2740183-9-songmuchun@bytedance.com>
2026-07-09 10:54   ` Mike Rapoport [this message]
2026-07-09 12:35     ` [PATCH 08/17] mm/sparse: mark memory sections present earlier Muchun Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ak996_21b-jxYLGV@kernel.org \
    --to=rppt@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=david@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=muchun.song@linux.dev \
    --cc=osalvador@suse.de \
    --cc=songmuchun@bytedance.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox