From: Mike Rapoport <rppt@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Brian Norris <briannorris@chromium.org>,
Edward Cree <ecree.xilinx@gmail.com>,
Francesco Dolcini <francesco@dolcini.it>,
Manish Chopra <manishc@marvell.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Sudarsana Kalluru <skalluru@marvell.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
b43-dev@lists.infradead.org, intel-wired-lan@lists.osuosl.org,
libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-net-drivers@amd.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 0/8] drivers/net: replace __get_free_pages() with kmalloc()
Date: Tue, 30 Jun 2026 17:40:34 +0300 [thread overview]
Message-ID: <akPVYpzxwP8CIQxu@kernel.org> (raw)
In-Reply-To: <20260630072344.159b5d99@kernel.org>
On Tue, Jun 30, 2026 at 07:23:44AM -0700, Jakub Kicinski wrote:
> On Tue, 30 Jun 2026 13:59:19 +0300 Mike Rapoport (Microsoft) wrote:
> > drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c | 6 +--
> > drivers/net/ethernet/intel/ice/ice_gnss.c | 5 +-
> > drivers/net/ethernet/sfc/mcdi.c | 7 +--
> > drivers/net/ethernet/sfc/siena/mcdi.c | 7 +--
> > drivers/net/wireless/broadcom/b43/debugfs.c | 12 ++---
> > drivers/net/wireless/broadcom/b43legacy/debugfs.c | 11 ++--
> > drivers/net/wireless/marvell/libertas/debugfs.c | 39 ++++++--------
> > drivers/net/wireless/marvell/mwifiex/debugfs.c | 62 ++++++++++-------------
> > drivers/net/wireless/ti/wlcore/main.c | 14 +++--
>
> You gotta split this, wireless and ethernet go via separate trees.
Sure.
> BTW cocci also suggests folding in a memset, IDK if it's worth it.
Same churn, less lines :)
> drivers/net/wireless/broadcom/b43legacy/debugfs.c:217:8-15: WARNING: kzalloc should be used for buf, instead of kmalloc/memset
> --
> pw-bot: cr
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2026-06-30 14:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 10:59 [PATCH net-next 0/8] drivers/net: replace __get_free_pages() with kmalloc() Mike Rapoport (Microsoft)
2026-06-30 10:59 ` [PATCH net-next 1/8] b43, b43legacy: debugfs: use kmalloc() to allocate formatting buffers Mike Rapoport (Microsoft)
2026-06-30 10:59 ` [PATCH net-next 2/8] bnx2x: use kzalloc() to allocate mac filtering list Mike Rapoport (Microsoft)
2026-06-30 10:59 ` [PATCH net-next 3/8] ice: use kzalloc() to allocate staging buffer for reading from GNSS Mike Rapoport (Microsoft)
2026-06-30 10:59 ` [PATCH net-next 4/8] libertas: debugfs: use kzalloc() to allocate formatting buffers Mike Rapoport (Microsoft)
2026-06-30 10:59 ` [PATCH net-next 5/8] mwifiex: " Mike Rapoport (Microsoft)
2026-06-30 10:59 ` [PATCH net-next 6/8] sfc/siena: use kmalloc() to allocate logging buffer Mike Rapoport (Microsoft)
2026-06-30 10:59 ` [PATCH net-next 7/8] sfc: " Mike Rapoport (Microsoft)
2026-06-30 10:59 ` [PATCH net-next 8/8] wlcore: allocate aggregation and firmware log buffers with kzalloc() Mike Rapoport (Microsoft)
2026-06-30 14:23 ` [PATCH net-next 0/8] drivers/net: replace __get_free_pages() with kmalloc() Jakub Kicinski
2026-06-30 14:40 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akPVYpzxwP8CIQxu@kernel.org \
--to=rppt@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=b43-dev@lists.infradead.org \
--cc=briannorris@chromium.org \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=francesco@dolcini.it \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-net-drivers@amd.com \
--cc=linux-wireless@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=skalluru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox