From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Wenchao Hao <haowenchao22@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Minchan Kim <minchan@kernel.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Nhat Pham <nphamcs@gmail.com>,
Joshua Hahn <joshua.hahnjy@gmail.com>,
Barry Song <baohua@kernel.org>,
Wenchao Hao <haowenchao@xiaomi.com>
Subject: Re: [PATCH v6 0/4] mm/zsmalloc: reduce lock contention in zs_free()
Date: Tue, 7 Jul 2026 16:18:23 +0900 [thread overview]
Message-ID: <akynv_js-5G88rGd@google.com> (raw)
In-Reply-To: <20260626015003.2965881-1-haowenchao22@gmail.com>
On (26/06/26 09:49), Wenchao Hao wrote:
[..]
> Changes since v5:
> - 2/4: rename obj_handle_class_lock() to obj_class_get_and_lock().
> - Pick up Reviewed-by from Barry Song on 2/4, 3/4, 4/4.
>
> Changes since v4:
> - 1/4: rename macros to make their intent clearer, following the
> kernel's *_BITS convention (Nhat Pham, Barry Song).
> - 3/4: drop the unused pool argument from __free_zspage_lockless().
>
> Changes since v3:
> - 1/4: gate ZS_OBJ_CLASS_BITS on a new spare-bit check so unsuitable
> configs (e.g. UML, no sparsemem) fall back to plain obj layout
> instead of breaking the build. (sashiko AI review)
> - 2/4: annotate handle_to_obj()/record_obj() with READ_ONCE/WRITE_ONCE
> to silence KCSAN; sync the #if predicate with patch 1. (sashiko AI review)
> - 4/4: clarify when async_free_zspage() runs; pick up Reviewed-by. (Nhat Pham)
> - Drop Reviewed-by from Nhat Pham on 1/4 and 2/4: substantial logic
> changes since v3, please re-review.
>
> Changes since v2:
> - 3/4: drop likely() hint and tidy up else-branch braces, per review
> nits from Nhat Pham and Joshua Hahn.
> - 4/4 (new): document free_zspage helper variants in a single comment
> block, per Nhat Pham.
> - Pick up Reviewed-by tags from Nhat Pham (1/4, 2/4, 3/4) and
> Joshua Hahn (3/4).
> - Fix patch 1/4 and 2/4 From: to match Signed-off-by, per Barry Song.
>
> Changes since v1:
> - Rename obj-encoding macros for clarity.
> - Make 32-bit / 64-bit handling transparent at call sites
> (no #ifdef in callers).
> - Extract a helper to keep zs_free() unified.
>
> Wenchao Hao (3):
> mm/zsmalloc: encode class index in obj value for lockless class lookup
> mm/zsmalloc: drop pool->lock from zs_free on 64-bit systems
> mm/zsmalloc: document free_zspage helper variants
>
> Xueyuan Chen (1):
> mm/zsmalloc: drop class lock before freeing zspage
Folks, really sorry for not being around and not being helpful,
I'm catching up on emails and will look at this in the coming days.
Many, many thanks to everyone who worked on it, reviewed it,
contributed to this work in one way or another. Thank you!
prev parent reply other threads:[~2026-07-07 7:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-26 1:49 [PATCH v6 0/4] mm/zsmalloc: reduce lock contention in zs_free() Wenchao Hao
2026-06-26 1:50 ` [PATCH v6 1/4] mm/zsmalloc: encode class index in obj value for lockless class lookup Wenchao Hao
2026-06-26 1:50 ` [PATCH v6 2/4] mm/zsmalloc: drop pool->lock from zs_free on 64-bit systems Wenchao Hao
2026-06-30 2:50 ` Andrew Morton
2026-06-26 1:50 ` [PATCH v6 3/4] mm/zsmalloc: drop class lock before freeing zspage Wenchao Hao
2026-06-26 1:50 ` [PATCH v6 4/4] mm/zsmalloc: document free_zspage helper variants Wenchao Hao
2026-06-28 4:36 ` [PATCH v6 0/4] mm/zsmalloc: reduce lock contention in zs_free() Andrew Morton
2026-07-07 7:18 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akynv_js-5G88rGd@google.com \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=haowenchao22@gmail.com \
--cc=haowenchao@xiaomi.com \
--cc=joshua.hahnjy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=nphamcs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox