From: Kairui Song <ryncsn@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Kiryl Shutsemau <kirill@shutemov.name>,
David Hildenbrand <david@kernel.org>,
Lorenzo Stoakes <ljs@kernel.org>,
Miaohe Lin <linmiaohe@huawei.com>,
Naoya Horiguchi <nao.horiguchi@gmail.com>,
Zi Yan <ziy@nvidia.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
"Liam R . Howlett" <liam@infradead.org>,
Nico Pache <npache@redhat.com>,
Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
Barry Song <baohua@kernel.org>,
Lance Yang <lance.yang@linux.dev>,
Usama Arif <usama.arif@linux.dev>,
Hao Zhang <zhanghao1@kylinos.cn>,
Hao Zhang <hao_zhang_kdev@163.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
"Kiryl Shutsemau (Meta)" <kas@kernel.org>,
stable@vger.kernel.org, Kairui Song <kasong@tencent.com>
Subject: Re: [PATCH v3] mm/huge_memory: unlock i_mmap_rwsem before releasing after-split folios
Date: Mon, 20 Jul 2026 12:35:40 +0800 [thread overview]
Message-ID: <al2b9eCBD3Rip7vk@KASONG-MC4> (raw)
In-Reply-To: <al2XTQLWB12sJQG5@casper.infradead.org>
On Mon, Jul 20, 2026 at 04:34:37AM +0800, Matthew Wilcox wrote:
> On Fri, Jul 17, 2026 at 07:58:51PM -0700, Andrew Morton wrote:
> > (why is mapping_set_update() a) a macro and b) undocumented?)
>
> commit 62e72d2cf702
>
> So make madvise(..., MADV_COLLAPSE) also call xas_set_lru() to pass the
> list_lru which we may want to insert xa_node into later. And move
> mapping_set_update to mm/internal.h, and turn into a macro to avoid
> including extra headers in mm/internal.h.
>
> Take it up with Kairui. And whoever it was added that patch to
> linux-mm.
Right, I initially wanted to make it a inline helper, since this function
were a macro and later become a static helper, so it should be super cheap
in the hot path. That requires to include extra headers in internal.h
and that looked a bit more uglier and every internel.h user will have
extra header dependency. Moving it to pagemap.h also looked confusing
along size other mapping_set_* helper, they are completely different
things, and this help should stay in mm/.
So I just partially restored how it was before b64e74e95aa6, It was
never documented though.
We can make it a function for sure, open to suggestions on this.
next prev parent reply other threads:[~2026-07-20 4:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260716095424.471052-1-kirill@shutemov.name>
2026-07-18 2:58 ` [PATCH v3] mm/huge_memory: unlock i_mmap_rwsem before releasing after-split folios Andrew Morton
2026-07-20 3:34 ` Matthew Wilcox
2026-07-20 4:35 ` Kairui Song [this message]
2026-07-20 3:26 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=al2b9eCBD3Rip7vk@KASONG-MC4 \
--to=ryncsn@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=hao_zhang_kdev@163.com \
--cc=kas@kernel.org \
--cc=kasong@tencent.com \
--cc=kirill@shutemov.name \
--cc=lance.yang@linux.dev \
--cc=liam@infradead.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=nao.horiguchi@gmail.com \
--cc=npache@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=stable@vger.kernel.org \
--cc=usama.arif@linux.dev \
--cc=willy@infradead.org \
--cc=zhanghao1@kylinos.cn \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox