From: "Theodore Tso" <tytso@mit.edu>
To: Matthew Wilcox <willy@infradead.org>
Cc: Longxing Li <coregee2000@gmail.com>,
akpm@linux-foundation.org, linux-ext4@vger.kernel.org,
adilger.kernel@dilger.ca, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: fix use-after-free in ext4 delayed I/O completion
Date: Fri, 10 Jul 2026 10:06:05 -0400 [thread overview]
Message-ID: <alD7q_AUlNaUwAup@mit.edu> (raw)
In-Reply-To: <ak-mQ2DnbaxIO_WU@casper.infradead.org>
On Thu, Jul 09, 2026 at 02:46:43PM -0500, Matthew Wilcox wrote:
>
> (also if this patch isn't AI slop, it's doing a Really Good Job of
> pretending to be AI slop. Why would you choose 'unsigned short' as
> the type?)
It's AI slop that didn't even bother to run it by an AI patch quality
review process such as Sashiko:
- [High] Skipping `queue_work()` when `igrab()` fails causes a permanent deadlock
during inode eviction by stranding pages in writeback state.
- [High] A data race and logical flaw with the 1-bit `i_rsv_need_iput` flag causes
permanent inode reference leaks during concurrent I/O completions.
Syzbot also reported the inconsistent igrab state issue. So it's AI
slop that wasted resources both with Shashiko and Syzbot....
Longxing Li, whether or not this is AI slop, this patch will tend to
cause me to distrust any future code submissions form you. I suggest
that you test patches and look at the code much more carefully before
sending, if you don't want to have a bad reputation as a patch
submitter.
Best regards,
- Ted
next prev parent reply other threads:[~2026-07-10 14:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 7:56 [PATCH] ext4: fix use-after-free in ext4 delayed I/O completion Longxing Li
2026-07-09 13:46 ` Matthew Wilcox
2026-07-10 14:06 ` Theodore Tso [this message]
2026-07-10 7:48 ` [syzbot ci] " syzbot ci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alD7q_AUlNaUwAup@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=coregee2000@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox