From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BDE56C44507 for ; Fri, 10 Jul 2026 15:02:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C302C6B00A5; Fri, 10 Jul 2026 11:02:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB8D16B00AA; Fri, 10 Jul 2026 11:02:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A81016B00AD; Fri, 10 Jul 2026 11:02:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 854B26B00A5 for ; Fri, 10 Jul 2026 11:02:00 -0400 (EDT) Received: from smtpin06.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 228ED169679 for ; Fri, 10 Jul 2026 15:02:00 +0000 (UTC) X-FDA: 84973182000.06.EEBC681 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf21.hostedemail.com (Postfix) with ESMTP id 701CF1C0010 for ; Fri, 10 Jul 2026 15:01:58 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=Aezvcf2o; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of ljs@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=ljs@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1783695718; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Nv6v5Gy5ZQKCjEDZ1CZd677nx3NlM5I4XdPHxBdo5us=; b=4B9f8Ncea1URYMczqZsJ3iBXgVunurY/h4cVB6Wb7neOLXS63LQjXsR5r7n552jJdQzpB5 /kVJepnuz4womSJ18s2uy8jD0kcSCDF2TF6c6tqMjJ0Op9R11kPZvJO0coi7vuw8AY37kf vVv1AsMupkoLNn9plnmOrwqL7d7lYeQ= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20260515 header.b=Aezvcf2o; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of ljs@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=ljs@kernel.org ARC-Seal: i=1; a=rsa-sha256; d=hostedemail.com; s=arc-20220608; cv=none; t=1783695718; b=zRvCHF7ClSyjE27VjwBFFl++EEEqCeLNcoRMRsfjx+jguT4QfLUXM45ZTezClcnPDMhZcn FIdDUPy3NNxuCQde2NS6eAtBhLloa4oGgMmGe5xlEIdU78BubR/gXsWN5QxgR/5F8V7apR 1B/V20lRlb2PsYD/2QbfZRQzB2SdNWs= Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 37DE644A58; Fri, 10 Jul 2026 15:01:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65E8A1F000E9; Fri, 10 Jul 2026 15:01:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783695717; bh=Nv6v5Gy5ZQKCjEDZ1CZd677nx3NlM5I4XdPHxBdo5us=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Aezvcf2oBz8R5O/JgeqQKn1Iv07D3k4kEuvwCc1b7Uv9q44jdZfUS20v8wyrCa/9F sFEfI7dW7gs9z+SsSfhJ8kA/ge/LrGSSz9zC3Je135DOXWvwgHKHjr0HNZUKiB8R0Z 6ZFI5o7wwOhve66iKnNqXpiMhf7SJFuqNWUQojN72CN7vt9E+8N+ylqWmq1V8VELbe 6ISmJ6bIDd6gomwGV7FsmpP5iGhPAK7B4N+ljOCC/csygDMZAkTZJGZNY4oR569umI ng8odBspjBH26Pq4TIGI6qDk3zs12pR3kiMN2IWrXV9IPeu4GxV8o5adjm1flT9Viv C2o6tJaaVjqqw== Date: Fri, 10 Jul 2026 16:01:32 +0100 From: Lorenzo Stoakes To: Gregory Price Cc: Andrew Morton , Russell King , Dinh Nguyen , Simon Schuster , "James E . J . Bottomley" , Helge Deller , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Ian Abbott , H Hartley Sweeten , Lucas Stach , David Airlie , Simona Vetter , Patrik Jakobsson , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Tomi Valkeinen , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Christian Koenig , Huang Rui , Ankit Agrawal , Alex Williamson , Alexander Viro , Christian Brauner , Dan Williams , Muchun Song , Oscar Salvador , David Hildenbrand , Suren Baghdasaryan , "Liam R . Howlett" , Matthew Wilcox , Marek Szyprowski , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Masami Hiramatsu , Oleg Nesterov , Steven Rostedt , SeongJae Park , Miaohe Lin , Hugh Dickins , Mike Rapoport , Kees Cook , Paolo Bonzini , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, linux-sgx@vger.kernel.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, iommu@lists.linux.dev, linux-perf-users@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, damon@lists.linux.dev, Pedro Falcato , Rik van Riel , Harry Yoo , Jann Horn Subject: Re: [PATCH 19/30] mm: use linear_page_[index, delta]() consistently Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 701CF1C0010 X-Stat-Signature: jxks3fhhezcjzwe3njdm1dspsokckett X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1783695718-477797 X-HE-Meta: U2FsdGVkX1/3yrp3twEeCxngovmo/4DH58/IzN9vjcIfgsG5yXi2BjZm+7kZs/LkttCw1dDFjh4jybuR7BNMB8dtRSbno0MZuEQuDP89z05q5iU3rnA8ZKSlXtS12HmGrk88y/tAE79g87tLD1e/LKVJ1P5Pdk58eguwNlYAyuaxCWpecrPRXsi4pMRiZTvO+mPPoKkwYJklm+87h1SDC3PfdBHqfmbrg4BH5mjEWP5C+rnAO5jSD1ctxJLx/qpQZU9LJ0I0uDgKyEt61MttvrBoB14t8HW3pNofv/EzbEzyM5RgONZ6sx1OBqsan9Jclb1iPvWDsDxX1nz0wBk3v4jOcgvJnZALW/NNFWE470TBWh1Hsl4Egcq6sf8W3xsNF0jnNzxKhhBaKNxblM+WRJrcdtxgO9+QhpEeaq31sn5H/ZzlIhSEdFCiLc9rwdoL4FedJwm96ao9ltHX5Bgqd4vbCUz4ycwlXjRu9OZ/inXwJqRoInpNjvWXNoI0/0avasMgfYJD9JGlx+nQCKN18/bwMmJYuiczH6AYbsePrHGt8DwBQ8srdlE9F27aBHN1WU23IW9B8Lalbdxqp77kpdSUMV/LnoF3BZpnqErY34boZ8vlqrrJiQuLwBkq7mkJnRP1KGCtd64fdIlMuSZy1vMREdzZ+5Y9TDc9xWAibvxZfYBA8bUjDS4Xul/F+Jod7nzXtRL2dqsaEOMfOlfP8tuYuvX4XcDNjJhxLo/egOBjQ1aj3vEYjNwMJBR3Fa+oK4KnD4jUxW4INhXZDvVoJogSVkmK4aLm3eThXQXYzN4ogt3crtefcWAr5CJih/+xsSOqFxJlrhN+PvQJP2o0aQQMiGIr0M1sWUg/eFoOEuQ3cjtMo4J+XbNncEkmrla0XATx8O3nsD06ipp725OntGaHnhH2/RN1fQEQDoMDjqhtCGP4eJgDvByyBZyjO4+2g22tXTwEpA8moVWi5Zv XBAF+s0z 1Mie32l5ga2JlJE301Z1mbQyCWh7gRJSNjoFuOQ4YWHfhzZejdRR577jlZ3f/y7aa+Sc8/YKF/hS5bCZSBeZK3WYlsF4cYXq2VB11dk+hXLHF4Izdp09QZ149yBgjnwSm7xZFS78N5Y2BS/wO9TdZ4uyAC4VxpIHExoNq+EVh/A+Tb7Hp8F1df5uaGpyd9+7uQJcPrbDEm61DVj9iDCgS3uTss77vJdwQ5pCI4naYw41YVx/Ep/m1KtGdfRv8Asb+BpQ2o6cvjsmtdhb1MN50QpncwDHxN3iIZ4iZ49kL7KnDf2wxSy6+11mAeO8PbtZbU+eBqxVnZakT+mjc9dy85sauM9jbymlvmkfh/eczJZ4y/pcINwj/vQceWg== Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 09, 2026 at 11:57:09AM -0400, Gregory Price wrote: > On Thu, Jul 09, 2026 at 11:55:54AM -0400, Gregory Price wrote: > > > @@ -2462,7 +2463,7 @@ static int comedi_vm_access(struct vm_area_struct *vma, unsigned long addr, > > > { > > > struct comedi_buf_map *bm = vma->vm_private_data; > > > unsigned long offset = > > > - addr - vma->vm_start + (vma->vm_pgoff << PAGE_SHIFT); > > > + addr - vma->vm_start + (vma_start_pgoff(vma) << PAGE_SHIFT); > > > > > > > Obviously correct, but was this intended for a different patch? > > > > ~Gregory > > bleh already caught, sorry for the noise :] Haha no thanks for picking it up, many eyes bugs etc. etc. ;) Cheers, Lorenzo