From: Matthew Wilcox <willy@infradead.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-mm@kvack.org, andriy.shevchenko@linux.intel.com,
usama.arif@linux.dev, hughd@google.com, ryan.roberts@arm.com,
"David Hildenbrand (Arm)" <david@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3] mm: Standardize printing for pgtable entries
Date: Sat, 11 Jul 2026 05:58:53 +0100 [thread overview]
Message-ID: <alHNjbiWFYXSPZtY@casper.infradead.org> (raw)
In-Reply-To: <20260709044334.1741263-1-anshuman.khandual@arm.com>
On Thu, Jul 09, 2026 at 10:13:34AM +0530, Anshuman Khandual wrote:
> @@ -532,34 +575,34 @@ static void __print_bad_page_map_pgtable(struct mm_struct *mm, unsigned long add
> * see locking requirements for print_bad_page_map().
> */
> pgdp = pgd_offset(mm, addr);
> - pgdv = pgd_val(*pgdp);
> + ptval_to_str(pgd_str, pgd_val(*pgdp));
>
> if (!pgd_present(*pgdp) || pgd_leaf(*pgdp)) {
> - pr_alert("pgd:%08llx\n", pgdv);
> + pr_alert("pgd:%s\n", pgd_str);
Why can't we do this as:
pr_alert("pgd:%*phN\n", sizeof(pgdv), &pgdv);
It'd save us all this stack space.
prev parent reply other threads:[~2026-07-11 4:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 4:43 [PATCH V3] mm: Standardize printing for pgtable entries Anshuman Khandual
2026-07-09 7:40 ` Andy Shevchenko
2026-07-09 9:12 ` David Hildenbrand (Arm)
2026-07-09 10:09 ` Andy Shevchenko
2026-07-09 10:19 ` David Hildenbrand (Arm)
2026-07-09 9:15 ` Petr Mladek
2026-07-09 10:11 ` Andy Shevchenko
2026-07-09 10:13 ` Andy Shevchenko
2026-07-09 10:24 ` David Hildenbrand (Arm)
2026-07-09 10:43 ` Andy Shevchenko
2026-07-09 11:12 ` Anshuman Khandual
2026-07-09 11:54 ` Andy Shevchenko
2026-07-10 0:08 ` Andrew Morton
2026-07-10 3:10 ` Anshuman Khandual
2026-07-10 3:32 ` Andrew Morton
2026-07-10 8:16 ` David Hildenbrand (Arm)
2026-07-11 4:58 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alHNjbiWFYXSPZtY@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=anshuman.khandual@arm.com \
--cc=david@kernel.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryan.roberts@arm.com \
--cc=usama.arif@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox