From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with SMTP id CD8536B0071 for ; Wed, 3 Feb 2010 11:14:11 -0500 (EST) Date: Wed, 3 Feb 2010 10:13:12 -0600 (CST) From: Christoph Lameter Subject: Re: [PATCH 32 of 32] khugepaged In-Reply-To: <20100202202450.GR4135@random.random> Message-ID: References: <51b543fab38b1290f176.1264969663@v2.random> <20100201225624.GB4135@random.random> <20100202202450.GR4135@random.random> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org To: Andrea Arcangeli Cc: linux-mm@kvack.org, Marcelo Tosatti , Adam Litke , Avi Kivity , Izik Eidus , Hugh Dickins , Nick Piggin , Rik van Riel , Mel Gorman , Dave Hansen , Benjamin Herrenschmidt , Ingo Molnar , Mike Travis , KAMEZAWA Hiroyuki , Chris Wright , Andrew Morton , bpicco@redhat.com, KOSAKI Motohiro , Balbir Singh , Arnd Bergmann List-ID: On Tue, 2 Feb 2010, Andrea Arcangeli wrote: > How would you say it? I think if ksm was forced to the migration pte > like it was discussed when ksm was first submitted, I would definitely > be forced to use it here too in order to get it merged. Do you disagree? How about at least consolidating the code with ksm pieces? > I prefer not to reuse the migration pte. I prefer to stick to the ksm > method. My rationale is pretty simple, migration pte requires an > additional logic in the pagefault code, while this doesn't and so it > has less dependencies and it looks simpler and more self contained to > me and it is enough for khugepaged as it is enough for ksm. The logic is already there ready for use. > pte freezing (ksm) or pmd_huge freezing (khugepaged). I think what > you're asking is over-engineering but again I welcome you to do it > yourself and prove you actually save lines, I don't see it myself. I > think if it was it so obvious as you pretend it to be, Hugh would have > cleaned it up considering it was an issue mentioned already. I am asking for simplification and that you do the cleanup work that comes with introcing new functionality in the kernel. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org