From: Christoph Lameter <cl@linux.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-mm@kvack.org, penberg@cs.helsinki.fi, mpm@selenic.com,
Andi Kleen <ak@linux.intel.com>,
fengguang.wu@intel.com
Subject: Re: [PATCH 2/2] HWPOISON: Attempt directed shrinking of slabs
Date: Wed, 6 Oct 2010 16:26:47 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1010061618470.8083@router.home> (raw)
In-Reply-To: <1286398930-11956-3-git-send-email-andi@firstfloor.org>
On Wed, 6 Oct 2010, Andi Kleen wrote:
> When a slab page is found try to shrink the specific slab first
> before trying to shrink all slabs and call other shrinkers.
> This can be done now using the new kmem_page_cache() call.
What you really would need here is targeted reclaim or the ability to move
objects into other slabs. The likelyhood of the shaking having any effect
is quite low.
The calling of the shrinkers is much more effective but it only works for
certain slabs. This is a broad shot against all slabs. It would be best to
call the fs shrinkers before kmem_cache_shrink(). You have to call
kmem_cache_shrink afterwards anyways because the slabs may keep recently
emptied slab pages around. The fs shrinkers may have evicted the objects
but the empty slab page is still around.
Maybe the best idea is to first call drop_slab() instead (evicts all possible fs
objects) and then call kmem_cache_shrink().
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-10-06 21:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 21:02 HWPOISON/SLAB: Allow shrinking of specific slab cache Andi Kleen
2010-10-06 21:02 ` [PATCH 1/2] SLAB: Add function to get slab cache for a page Andi Kleen
2010-10-06 21:42 ` Christoph Lameter
2010-10-07 5:34 ` Pekka Enberg
2010-10-07 6:34 ` Andi Kleen
2010-10-06 21:02 ` [PATCH 2/2] HWPOISON: Attempt directed shrinking of slabs Andi Kleen
2010-10-06 21:26 ` Christoph Lameter [this message]
2010-10-06 21:42 ` Andi Kleen
2010-10-06 21:44 ` Christoph Lameter
2010-10-06 21:55 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1010061618470.8083@router.home \
--to=cl@linux.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=fengguang.wu@intel.com \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).