linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] MM: Make "struct vm_region {...}" depend on !CONFIG_MMU.
@ 2010-04-05 14:56 Robert P. J. Day
  0 siblings, 0 replies; only message in thread
From: Robert P. J. Day @ 2010-04-05 14:56 UTC (permalink / raw)
  To: linux-mm


Since the "vm_region" structure appears to be relevant only under
NOMMU, conditionally include it in mm_types.h.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

---

  if i read mm_types.h, i can see the obvious conditional inclusion:

#ifndef CONFIG_MMU
        struct vm_region *vm_region;    /* NOMMU mapping region */
#endif

since that's the case, it seems only consistent to make the structure
declaration itself similarly conditional, no?

diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h
index b8bb9a6..76f1174 100644
--- a/include/linux/mm_types.h
+++ b/include/linux/mm_types.h
@@ -102,6 +102,7 @@ struct page {
 #endif
 };

+#ifndef CONFIG_MMU
 /*
  * A region containing a mapping of a non-memory backed file under NOMMU
  * conditions.  These are held in a global tree and are pinned by the VMAs that
@@ -120,6 +121,7 @@ struct vm_region {
 	bool		vm_icache_flushed : 1; /* true if the icache has been flushed for
 						* this region */
 };
+#endif

 /*
  * This struct defines a memory VMM memory area. There is one of these


========================================================================
Robert P. J. Day                               Waterloo, Ontario, CANADA

            Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday
========================================================================

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2010-04-05 14:58 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-05 14:56 [PATCH] MM: Make "struct vm_region {...}" depend on !CONFIG_MMU Robert P. J. Day

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).