Re: Security fix for remapping of page 0 (was [PATCH] Change ZERO_SIZE_PTR to point at unmapped space)

pageexec
2009-06-03T20:01:08Z

On 3 Jun 2009 at 11:50, Linus Torvalds wrote:

>
>
> On Wed, 3 Jun 2009, Linus Torvalds wrote:
> >
> > That means that you've already by-passed all the main security. It's thus
> > by definition less common than attack vectors like buffer overflows that
> > give you that capability in the first place.
>
> Btw, you obviously need to then _also_ pair it with some as-yet-unknown
> case of kernel bug to get to that NULL pointer (or zero-sized-alloc
> pointer) problem.

are you saying it's hard to find 'as-yet-unknown' null-deref bugs? what about
'already-known-but-not-yet-fixed-in-distro-kernel' ones? especially when the
disclosure process was, let's say, less than 'full'.

> You _also_ seem to be totally ignoring the fact that we already _do_
> protect against NULL pointers by default.

this whole discussion about NULL derefs is quite missing the point by the way.
the proper bug class is about unintended userland ptr derefs by the kernel,
of which NULL derefs are a small subset only. and you can't protect against
it by default or otherwise by banning userland from using its address space ;).

fixing ZERO_SIZE_PTR is about not making the mess of mixing userland/kernel
addresses worse, that's all. small piece of the parcel but then it's obviously
correct too.

> So I really don't see why you're making a big deal of this. It's as if you
> were talking about us not randomizing the address space - sure, you can
> turn it off, but so what? We do it by default.

and the amount of it is easily bruteforceable not to mention lack of
protection against said bruteforce. don't rest on your laurels yet ;).

> So it boils down to:
>
> - NULL pointers already cannot be in mmap memory

not all NULL deref bugs are literally around address 0, there's often an
offset involved, sometimes even under the attacker's control (a famous
userland example is discussed in
http://documents.iss.net/whitepapers/IBM_X-Force_WP_final.pdf
).

> (unless a distro has
> done something wrong - outside of the kernel)

do you have data about which distros and kernels enable this? and how
they handle v86 and stuff? suid root equivalent or something better?