From: Linus Torvalds <torvalds@linux-foundation.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH] mm: Make it easier to catch NULL cache names
Date: Mon, 27 Jul 2009 19:52:35 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.01.0907271951390.3186@localhost.localdomain> (raw)
In-Reply-To: <1248745735.30993.38.camel@pasglop>
On Tue, 28 Jul 2009, Benjamin Herrenschmidt wrote:
>
> Right now, if you inadvertently pass NULL to kmem_cache_create() at boot
> time, it crashes much later after boot somewhere deep inside sysfs which
> makes it very non obvious to figure out what's going on.
Please don't do BUG_ON() when there are alternatives.
In this case, something like
if (WARN_ON(!name))
return NULL;
would probably have worked too.
Linus
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-07-28 2:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-28 1:48 [PATCH] mm: Make it easier to catch NULL cache names Benjamin Herrenschmidt
2009-07-28 2:52 ` Linus Torvalds [this message]
2009-07-28 2:55 ` Benjamin Herrenschmidt
2009-07-28 5:01 ` David Rientjes
2009-07-28 7:39 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2009-07-28 4:11 Benjamin Herrenschmidt
2009-07-29 0:06 ` Andrew Morton
2009-07-29 5:55 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.01.0907271951390.3186@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).