From: Pekka Enberg <penberg@kernel.org>
To: alex shi <lkml.alex@gmail.com>
Cc: David Rientjes <rientjes@google.com>,
Shaohua Li <shaohua.li@intel.com>, linux-mm <linux-mm@kvack.org>,
cl@linux-foundation.org
Subject: Re: [patch] slub: fix a code merge error
Date: Tue, 15 Nov 2011 08:45:18 +0200 (EET) [thread overview]
Message-ID: <alpine.LFD.2.02.1111150842590.2347@tux.localdomain> (raw)
In-Reply-To: <CAGjg+kHstQGLvT+=K9v_s=hLDd0974JHR0N5EVsTbkYk2=s1vQ@mail.gmail.com>
>> Indeed. Please resend with proper subject and changelog with
>> Christoph's and David's ACKs included.
On Mon, 14 Nov 2011, alex shi wrote:
> SLUB stat attribute was designed for stat accounting only. I checked
> the total 24 attributes that used now. All of them used in stat() only
> except the DEACTIVATE_TO_HEAD/TAIL.
>
> And in fact, in the most of using scenarios the DEACTIVATE_TO_TAIL
> make reader confuse, TO_TAIL is correct but not for DEACTIVATE.
>
> Further more, CL also regretted this after he acked the original
> patches for this attribute mis-usages. He said "don't think we want
> this patch any more."
> http://permalink.gmane.org/gmane.linux.kernel.mm/67653 and want to use
> a comment instead of this confusing usage.
> https://lkml.org/lkml/2011/8/29/187
>
> So, as to this regression, from my viewpoint, reverting the
> DEACTIVATE_TO_TAIL incorrect usage(commit 136333d104) is a better way.
> :)
The enum is fine. I don't see any reason to revert the whole commit if
Shaohua's patch fixes the problem.
Pekka
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-11-15 6:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-10 8:04 [patch] slub: fix a code merge error Shaohua Li
2011-11-10 14:44 ` Christoph Lameter
2011-11-10 20:18 ` David Rientjes
2011-11-10 20:30 ` Pekka Enberg
2011-11-11 0:33 ` Shaohua Li
2011-11-14 1:56 ` alex shi
2011-11-14 3:12 ` Shaohua Li
2011-11-15 6:45 ` Pekka Enberg [this message]
2011-11-16 23:06 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1111150842590.2347@tux.localdomain \
--to=penberg@kernel.org \
--cc=cl@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=lkml.alex@gmail.com \
--cc=rientjes@google.com \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).