From: Pekka Enberg <penberg@kernel.org>
To: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: linux-kernel@vger.kernel.org, Chris Metcalf <cmetcalf@tilera.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Frederic Weisbecker <fweisbec@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
linux-mm@kvack.org, Matt Mackall <mpm@selenic.com>,
Sasha Levin <levinsasha928@gmail.com>,
Rik van Riel <riel@redhat.com>, Andi Kleen <andi@firstfloor.org>,
apkm@linux-foundation.org
Subject: Re: [PATCH v4 4/5] slub: Only IPI CPUs that have per cpu obj to flush
Date: Wed, 23 Nov 2011 08:23:31 +0200 (EET) [thread overview]
Message-ID: <alpine.LFD.2.02.1111230822270.1773@tux.localdomain> (raw)
In-Reply-To: <1321960128-15191-5-git-send-email-gilad@benyossef.com>
On Tue, 22 Nov 2011, Gilad Ben-Yossef wrote:
> static void flush_all(struct kmem_cache *s)
> {
> - on_each_cpu(flush_cpu_slab, s, 1);
> + cpumask_var_t cpus;
> + struct kmem_cache_cpu *c;
> + int cpu;
> +
> + if (likely(zalloc_cpumask_var(&cpus, GFP_ATOMIC))) {
__GFP_NOWARN too maybe?
> + for_each_online_cpu(cpu) {
> + c = per_cpu_ptr(s->cpu_slab, cpu);
> + if (c->page)
> + cpumask_set_cpu(cpu, cpus);
> + }
> + on_each_cpu_mask(cpus, flush_cpu_slab, s, 1);
> + free_cpumask_var(cpus);
> + } else
> + on_each_cpu(flush_cpu_slab, s, 1);
> }
Acked-by: Pekka Enberg <penberg@kernel.org>
I can't take the patch because it depends on a new API introduced in the
first patch.
I'm CC'ing Andrew.
Pekka
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-11-23 6:23 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 11:08 [PATCH v4 0/5] Reduce cross CPU IPI interference Gilad Ben-Yossef
2011-11-22 11:08 ` [PATCH v4 1/5] smp: Introduce a generic on_each_cpu_mask function Gilad Ben-Yossef
2011-11-22 11:08 ` [PATCH v4 2/5] arm: Move arm over to generic on_each_cpu_mask Gilad Ben-Yossef
2011-11-22 21:00 ` Russell King - ARM Linux
2011-11-23 6:47 ` Gilad Ben-Yossef
2011-11-22 11:08 ` [PATCH v4 3/5] tile: Move tile to use " Gilad Ben-Yossef
2011-11-22 11:08 ` [PATCH v4 4/5] slub: Only IPI CPUs that have per cpu obj to flush Gilad Ben-Yossef
2011-11-23 6:23 ` Pekka Enberg [this message]
2011-11-23 6:57 ` Pekka Enberg
2011-11-23 7:52 ` Gilad Ben-Yossef
2012-01-01 12:41 ` Avi Kivity
2012-01-01 16:12 ` Gilad Ben-Yossef
2012-01-01 16:50 ` Avi Kivity
2012-01-02 11:59 ` Gilad Ben-Yossef
2012-01-02 13:30 ` Avi Kivity
2012-01-08 16:13 ` Gilad Ben-Yossef
2012-01-08 16:15 ` Avi Kivity
2011-11-22 11:08 ` [PATCH v4 5/5] mm: Only IPI CPUs to drain local pages if they exist Gilad Ben-Yossef
2011-11-23 7:45 ` Pekka Enberg
2011-12-23 10:28 ` Mel Gorman
2011-12-25 9:39 ` Gilad Ben-Yossef
2011-12-30 15:04 ` Mel Gorman
2011-12-30 15:25 ` Chris Metcalf
2011-12-30 16:08 ` Mel Gorman
2011-12-30 20:29 ` Gilad Ben-Yossef
2012-01-01 8:03 ` Gilad Ben-Yossef
2011-12-30 20:16 ` Gilad Ben-Yossef
2011-11-23 1:36 ` [PATCH v4 0/5] Reduce cross CPU IPI interference Chris Metcalf
2011-11-23 6:52 ` Gilad Ben-Yossef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1111230822270.1773@tux.localdomain \
--to=penberg@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=apkm@linux-foundation.org \
--cc=cmetcalf@tilera.com \
--cc=fweisbec@gmail.com \
--cc=gilad@benyossef.com \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@arm.linux.org.uk \
--cc=mpm@selenic.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).