From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx146.postini.com [74.125.245.146]) by kanga.kvack.org (Postfix) with SMTP id 950386B004A for ; Wed, 29 Feb 2012 02:37:40 -0500 (EST) Received: by lamf4 with SMTP id f4so10599109lam.14 for ; Tue, 28 Feb 2012 23:37:38 -0800 (PST) Date: Wed, 29 Feb 2012 09:37:23 +0200 (EET) From: Pekka Enberg Subject: Re: [PATCH] mm: SLAB Out-of-memory diagnostics In-Reply-To: <20120229032715.GA23758@t510.redhat.com> Message-ID: References: <20120229032715.GA23758@t510.redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Rafael Aquini Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Randy Dunlap , Christoph Lameter , Matt Mackall , Rik van Riel , Josef Bacik , David Rientjes On Wed, 29 Feb 2012, Rafael Aquini wrote: > Following the example at mm/slub.c, add out-of-memory diagnostics to the SLAB > allocator to help on debugging OOM conditions. This patch also adds a new > sysctl, 'oom_dump_slabs_forced', that overrides the effect of __GFP_NOWARN page > allocation flag and forces the kernel to report every slab allocation failure. > > An example print out looks like this: > > > SLAB: Unable to allocate memory on node 0 (gfp=0x11200) > cache: bio-0, object size: 192, order: 0 > node0: slabs: 3/3, objs: 60/60, free: 0 > > Signed-off-by: Rafael Aquini > --- > Documentation/sysctl/vm.txt | 23 ++++++++++++++++++ > include/linux/slab.h | 2 + > kernel/sysctl.c | 9 +++++++ > mm/slab.c | 55 ++++++++++++++++++++++++++++++++++++++++++- > 4 files changed, 88 insertions(+), 1 deletions(-) No SLUB support for this? > diff --git a/Documentation/sysctl/vm.txt b/Documentation/sysctl/vm.txt > index 96f0ee8..75bdf91 100644 > --- a/Documentation/sysctl/vm.txt > +++ b/Documentation/sysctl/vm.txt > @@ -498,6 +498,29 @@ this is causing problems for your system/application. > > ============================================================== > > +oom_dump_slabs_forced > + > +Overrides the effects of __GFP_NOWARN page allocation flag, thus forcing > +the system to print warnings about every allocation failure for the > +slab allocator, and helping on debugging certain OOM conditions. > +The print out is pretty similar, and complements data that is reported by > +the page allocator out-of-memory warning: > + > + > + SLAB: Unable to allocate memory on node 0 (gfp=0x11200) > + cache: bio-0, object size: 192, order: 0 > + node0: slabs: 3/3, objs: 60/60, free: 0 > + > +If this is set to zero, the default behavior is observed and warnings will only > +be printed out for allocation requests that didn't set the __GFP_NOWARN flag. > + > +When set to non-zero, this information is shown whenever the allocator finds > +itself failing to grant a request, regardless the __GFP_NOWARN flag status. > + > +The default value is 0 (disabled). > + > +============================================================== > + Why do you want to add a sysctl for this? That'd be an ABI that we need to keep around forever. Is there any reason we shouldn't just enable this unconditionally? Pekka -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org