From: Pekka Enberg <penberg@kernel.org>
To: Rafael Aquini <aquini@redhat.com>
Cc: David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Randy Dunlap <rdunlap@xenotime.net>,
Christoph Lameter <cl@linux-foundation.org>,
Matt Mackall <mpm@selenic.com>, Rik van Riel <riel@redhat.com>,
Josef Bacik <josef@redhat.com>
Subject: Re: [PATCH] mm: SLAB Out-of-memory diagnostics
Date: Mon, 5 Mar 2012 12:33:49 +0200 (EET) [thread overview]
Message-ID: <alpine.LFD.2.02.1203051233440.1945@tux.localdomain> (raw)
In-Reply-To: <20120302143323.GB1868@t510.redhat.com>
On Fri, 2 Mar 2012, Rafael Aquini wrote:
> On Wed, Feb 29, 2012 at 05:26:07PM -0800, David Rientjes wrote:
> > On Wed, 29 Feb 2012, Rafael Aquini wrote:
> >
> > > Following the example at mm/slub.c, add out-of-memory diagnostics to the SLAB
> > > allocator to help on debugging OOM conditions. This patch also adds a new
> > > sysctl, 'oom_dump_slabs_forced', that overrides the effect of __GFP_NOWARN page
> > > allocation flag and forces the kernel to report every slab allocation failure.
> > >
> > > An example print out looks like this:
> > >
> > > <snip page allocator out-of-memory message>
> > > SLAB: Unable to allocate memory on node 0 (gfp=0x11200)
> > > cache: bio-0, object size: 192, order: 0
> > > node0: slabs: 3/3, objs: 60/60, free: 0
> > >
> > > Signed-off-by: Rafael Aquini <aquini@redhat.com>
> >
> > I like it, except for the addition of the sysctl. __GFP_NOWARN is used
> > for a reason, usually because whatever is allocating memory can gracefully
> > handle a failure and should not be emitted to the kernel log under any
> > circumstances.
>
> Ok, I'll drop the sysctl part then. Pekka?
Yes, please.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-03-05 10:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 3:27 [PATCH] mm: SLAB Out-of-memory diagnostics Rafael Aquini
2012-02-29 7:37 ` Pekka Enberg
2012-02-29 18:16 ` Rafael Aquini
2012-02-29 18:45 ` Rafael Aquini
2012-03-01 1:26 ` David Rientjes
2012-03-02 14:33 ` Rafael Aquini
2012-03-05 10:33 ` Pekka Enberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1203051233440.1945@tux.localdomain \
--to=penberg@kernel.org \
--cc=aquini@redhat.com \
--cc=cl@linux-foundation.org \
--cc=josef@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=rdunlap@xenotime.net \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).