From: Pekka Enberg <penberg@kernel.org>
To: Anton Vorontsov <anton.vorontsov@linaro.org>
Cc: Leonid Moiseichuk <leonid.moiseichuk@nokia.com>,
John Stultz <john.stultz@linaro.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linaro-kernel@lists.linaro.org, patches@linaro.org
Subject: Re: [PATCH 1/2] vmevent: Should not grab mutex in the atomic context
Date: Wed, 18 Apr 2012 23:01:58 +0300 (EEST) [thread overview]
Message-ID: <alpine.LFD.2.02.1204182301430.11868@tux.localdomain> (raw)
In-Reply-To: <20120418083356.GA31556@lizard>
On Wed, 18 Apr 2012, Anton Vorontsov wrote:
> vmevent grabs a mutex in the atomic context, and so this pops up:
>
> BUG: sleeping function called from invalid context at kernel/mutex.c:271
> in_atomic(): 1, irqs_disabled(): 0, pid: 0, name: swapper/0
> 1 lock held by swapper/0/0:
> #0: (&watch->timer){+.-...}, at: [<ffffffff8103eb80>] call_timer_fn+0x0/0xf0
> Pid: 0, comm: swapper/0 Not tainted 3.2.0+ #6
> Call Trace:
> <IRQ> [<ffffffff8102f5da>] __might_sleep+0x12a/0x1e0
> [<ffffffff810bd990>] ? vmevent_match+0xe0/0xe0
> [<ffffffff81321f2c>] mutex_lock_nested+0x3c/0x340
> [<ffffffff81064b33>] ? lock_acquire+0xa3/0xc0
> [<ffffffff8103eb80>] ? internal_add_timer+0x110/0x110
> [<ffffffff810bd990>] ? vmevent_match+0xe0/0xe0
> [<ffffffff810bda21>] vmevent_timer_fn+0x91/0xf0
> [<ffffffff810bd990>] ? vmevent_match+0xe0/0xe0
> [<ffffffff8103ebf5>] call_timer_fn+0x75/0xf0
> [<ffffffff8103eb80>] ? internal_add_timer+0x110/0x110
> [<ffffffff81062fdd>] ? trace_hardirqs_on_caller+0x7d/0x120
> [<ffffffff8103ee9f>] run_timer_softirq+0x10f/0x1e0
> [<ffffffff810bd990>] ? vmevent_match+0xe0/0xe0
> [<ffffffff81038d90>] __do_softirq+0xb0/0x160
> [<ffffffff8105eb0f>] ? tick_program_event+0x1f/0x30
> [<ffffffff8132642c>] call_softirq+0x1c/0x26
> [<ffffffff810036d5>] do_softirq+0x85/0xc0
>
> This patch fixes the issue by removing the mutex and making the logic
> lock-free.
>
> Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
Applied, thanks!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-04-18 20:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 8:32 [PATCH v2 0/2] vmevent: Greater-than attribute + one-shot mode + a bugfix Anton Vorontsov
2012-04-18 8:33 ` [PATCH 1/2] vmevent: Should not grab mutex in the atomic context Anton Vorontsov
2012-04-18 20:01 ` Pekka Enberg [this message]
2012-04-18 8:35 ` [PATCH 2/2] vmevent: Implement greater-than attribute and one-shot mode Anton Vorontsov
2012-04-18 20:01 ` Pekka Enberg
2012-04-18 22:46 ` Anton Vorontsov
2012-04-19 5:42 ` Pekka Enberg
2012-04-19 16:29 ` [PATCH v3 " Anton Vorontsov
2012-05-01 13:18 ` [PATCH v4] vmevent: Implement greater-than attribute state " Anton Vorontsov
2012-05-01 21:04 ` Rik van Riel
2012-05-02 0:20 ` Anton Vorontsov
2012-05-02 1:20 ` KOSAKI Motohiro
2012-05-02 3:31 ` Anton Vorontsov
2012-05-02 3:50 ` Anton Vorontsov
2012-05-02 5:04 ` Minchan Kim
2012-05-02 6:46 ` leonid.moiseichuk
2012-05-02 6:57 ` Pekka Enberg
2012-05-02 7:41 ` Minchan Kim
2012-05-02 6:51 ` Pekka Enberg
2012-05-03 10:52 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1204182301430.11868@tux.localdomain \
--to=penberg@kernel.org \
--cc=anton.vorontsov@linaro.org \
--cc=john.stultz@linaro.org \
--cc=leonid.moiseichuk@nokia.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).