* [PATCH 1/2] vmevent: don't leak unitialized data to userspace
@ 2012-05-23 7:27 Bartlomiej Zolnierkiewicz
2012-05-25 7:17 ` Pekka Enberg
0 siblings, 1 reply; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2012-05-23 7:27 UTC (permalink / raw)
To: Pekka Enberg; +Cc: Anton Vorontsov, linux-mm
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: [PATCH] vmevent: don't leak unitialized data to userspace
Remember to initialize all attrs[nr] fields in vmevent_setup_watch().
Cc: Anton Vorontsov <anton.vorontsov@linaro.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
mm/vmevent.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
Index: b/mm/vmevent.c
===================================================================
--- a/mm/vmevent.c 2012-05-22 17:51:13.195231958 +0200
+++ b/mm/vmevent.c 2012-05-22 17:51:40.991231956 +0200
@@ -350,7 +350,10 @@
attrs = new;
- attrs[nr++].type = attr->type;
+ attrs[nr].type = attr->type;
+ attrs[nr].value = 0;
+ attrs[nr].state = 0;
+ nr++;
}
watch->sample_attrs = attrs;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] vmevent: don't leak unitialized data to userspace
2012-05-23 7:27 [PATCH 1/2] vmevent: don't leak unitialized data to userspace Bartlomiej Zolnierkiewicz
@ 2012-05-25 7:17 ` Pekka Enberg
0 siblings, 0 replies; 2+ messages in thread
From: Pekka Enberg @ 2012-05-25 7:17 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: Anton Vorontsov, linux-mm
On Wed, 23 May 2012, Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Subject: [PATCH] vmevent: don't leak unitialized data to userspace
>
> Remember to initialize all attrs[nr] fields in vmevent_setup_watch().
>
> Cc: Anton Vorontsov <anton.vorontsov@linaro.org>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> mm/vmevent.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> Index: b/mm/vmevent.c
> ===================================================================
> --- a/mm/vmevent.c 2012-05-22 17:51:13.195231958 +0200
> +++ b/mm/vmevent.c 2012-05-22 17:51:40.991231956 +0200
> @@ -350,7 +350,10 @@
>
> attrs = new;
>
> - attrs[nr++].type = attr->type;
> + attrs[nr].type = attr->type;
> + attrs[nr].value = 0;
> + attrs[nr].state = 0;
> + nr++;
> }
>
> watch->sample_attrs = attrs;
Applied, thanks!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-25 7:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-23 7:27 [PATCH 1/2] vmevent: don't leak unitialized data to userspace Bartlomiej Zolnierkiewicz
2012-05-25 7:17 ` Pekka Enberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).