From: Pekka Enberg <penberg@kernel.org>
To: David Rientjes <rientjes@google.com>
Cc: Joonsoo Kim <js1304@gmail.com>,
Christoph Lameter <cl@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
torvalds@linux-foundation.org
Subject: Re: [PATCH] slub: change cmpxchg_double_slab in get_freelist() to __cmpxchg_double_slab
Date: Fri, 1 Jun 2012 09:39:20 +0300 (EEST) [thread overview]
Message-ID: <alpine.LFD.2.02.1206010934460.2163@tux.localdomain> (raw)
In-Reply-To: <alpine.DEB.2.00.1205311351540.2764@chino.kir.corp.google.com>
On Mon, 14 May 2012, David Rientjes wrote:
> > On Fri, 11 May 2012, Joonsoo Kim wrote:
> >
> > > get_freelist() is only called by __slab_alloc with interrupt disabled,
> > > so __cmpxchg_double_slab is suitable.
> > >
> > > Signed-off-by: Joonsoo Kim <js1304@gmail.com>
> >
> > Acked-by: David Rientjes <rientjes@google.com>
On Thu, 31 May 2012, David Rientjes wrote:
> Pekka, did you want to pick this up so it can get into linux-next?
We now made get_freelist() *require* interrupts to be disabled which
deserves a comment, no?
Also, what do we gain from patches like this? It's somewhat
counterintuitive that we have a function with "cmpxchg" in it which is not
always atomic (i.e. you need to have interrupts disabled).
IIRC, there was even a long rant about this by Linus but I'm unable to
find it in my email archives.
Pekka
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-01 6:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 15:56 [PATCH] slub: change cmpxchg_double_slab in get_freelist() to __cmpxchg_double_slab Joonsoo Kim
2012-05-15 6:32 ` David Rientjes
2012-05-31 20:52 ` David Rientjes
2012-06-01 6:39 ` Pekka Enberg [this message]
2012-06-01 12:18 ` JoonSoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1206010934460.2163@tux.localdomain \
--to=penberg@kernel.org \
--cc=cl@linux-foundation.org \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).