* Re: [PATCH 3/7] mm/slub.c: remove invalid reference to list iterator variable
2012-07-08 11:37 ` [PATCH 3/7] mm/slub.c: remove invalid reference to list iterator variable Julia Lawall
@ 2012-07-09 9:04 ` Pekka Enberg
2012-07-09 13:53 ` Christoph Lameter
1 sibling, 0 replies; 3+ messages in thread
From: Pekka Enberg @ 2012-07-09 9:04 UTC (permalink / raw)
To: Julia Lawall
Cc: Christoph Lameter, kernel-janitors, Matt Mackall, linux-mm,
linux-kernel
On Sun, 8 Jul 2012, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> If list_for_each_entry, etc complete a traversal of the list, the iterator
> variable ends up pointing to an address at an offset from the list head,
> and not a meaningful structure. Thus this value should not be used after
> the end of the iterator. The patch replaces s->name by al->name, which is
> referenced nearby.
>
> This problem was found using Coccinelle (http://coccinelle.lip6.fr/).
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> mm/slub.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/slub.c b/mm/slub.c
> index cc4ed03..ef9bf01 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -5395,7 +5395,7 @@ static int __init slab_sysfs_init(void)
> err = sysfs_slab_alias(al->s, al->name);
> if (err)
> printk(KERN_ERR "SLUB: Unable to add boot slab alias"
> - " %s to sysfs\n", s->name);
> + " %s to sysfs\n", al->name);
> kfree(al);
> }
Applied, thanks!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 3/7] mm/slub.c: remove invalid reference to list iterator variable
2012-07-08 11:37 ` [PATCH 3/7] mm/slub.c: remove invalid reference to list iterator variable Julia Lawall
2012-07-09 9:04 ` Pekka Enberg
@ 2012-07-09 13:53 ` Christoph Lameter
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Lameter @ 2012-07-09 13:53 UTC (permalink / raw)
To: Julia Lawall
Cc: kernel-janitors, Pekka Enberg, Matt Mackall, linux-mm,
linux-kernel
On Sun, 8 Jul 2012, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> If list_for_each_entry, etc complete a traversal of the list, the iterator
> variable ends up pointing to an address at an offset from the list head,
> and not a meaningful structure. Thus this value should not be used after
> the end of the iterator. The patch replaces s->name by al->name, which is
> referenced nearby.
Acked-by: Christoph Lameter <cl@linux.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread