From: Thomas Gleixner <tglx@linutronix.de>
To: Christoph Lameter <cl@linux.com>
Cc: linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] slub: Use the correct per cpu slab on CPU_DEAD
Date: Tue, 30 Oct 2012 18:01:47 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.02.1210301801030.2756@ionos> (raw)
In-Reply-To: <0000013ab24a800e-75ac1059-9697-42ed-b64a-7ba0d6223fba-000000@email.amazonses.com>
On Tue, 30 Oct 2012, Christoph Lameter wrote:
> On Sat, 27 Oct 2012, Thomas Gleixner wrote:
>
> > Correct this by extending the arguments of unfreeze_partials with the
> > target cpu number and use per_cpu_ptr instead of this_cpu_ptr.
>
> Passing the kmem_cache_cpu pointer instead simplifies this a bit and avoid
> a per_cpu_ptr operations. That reduces code somewhat and results in no
> additional operations for the fast path.
>
>
> Subject: Use correct cpu_slab on dead cpu
>
> Pass a kmem_cache_cpu pointer into unfreeze partials so that a different
> kmem_cache_cpu structure than the local one can be specified.
>
> Reported-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Christoph Lameter <cl@linux.com>
Yep. That looks less ugly :)
Acked-by: Thomas Gleixner <tglx@linutronix.de>
> Index: linux/mm/slub.c
> ===================================================================
> --- linux.orig/mm/slub.c 2012-10-30 10:23:33.040649727 -0500
> +++ linux/mm/slub.c 2012-10-30 10:25:03.401312250 -0500
> @@ -1874,10 +1874,10 @@ redo:
> *
> * This function must be called with interrupt disabled.
> */
> -static void unfreeze_partials(struct kmem_cache *s)
> +static void unfreeze_partials(struct kmem_cache *s,
> + struct kmem_cache_cpu *c)
> {
> struct kmem_cache_node *n = NULL, *n2 = NULL;
> - struct kmem_cache_cpu *c = this_cpu_ptr(s->cpu_slab);
> struct page *page, *discard_page = NULL;
>
> while ((page = c->partial)) {
> @@ -1963,7 +1963,7 @@ static int put_cpu_partial(struct kmem_c
> * set to the per node partial list.
> */
> local_irq_save(flags);
> - unfreeze_partials(s);
> + unfreeze_partials(s, this_cpu_ptr(s->cpu_slab));
> local_irq_restore(flags);
> oldpage = NULL;
> pobjects = 0;
> @@ -2006,7 +2006,7 @@ static inline void __flush_cpu_slab(stru
> if (c->page)
> flush_slab(s, c);
>
> - unfreeze_partials(s);
> + unfreeze_partials(s, c);
> }
> }
>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-10-30 17:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-27 19:18 [PATCH] slub: Use the correct per cpu slab on CPU_DEAD Thomas Gleixner
2012-10-30 15:29 ` Christoph Lameter
2012-10-30 17:01 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1210301801030.2756@ionos \
--to=tglx@linutronix.de \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).