From: Hugh Dickins <hughd@google.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Sasha Levin <sasha.levin@oracle.com>,
Mel Gorman <mgorman@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
Petr Holasek <pholasek@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH] ksm: make rmap walks more scalable
Date: Thu, 20 Dec 2012 14:40:59 -0800 (PST) [thread overview]
Message-ID: <alpine.LNX.2.00.1212201438190.977@eggly.anvils> (raw)
In-Reply-To: <CA+55aFxfS0SBbRBRULX4Hm7a-xOY7ebJ=Ncu2cAdH2xvcZFO+Q@mail.gmail.com>
On Thu, 20 Dec 2012, Linus Torvalds wrote:
> On Thu, Dec 20, 2012 at 1:49 PM, Sasha Levin <sasha.levin@oracle.com> wrote:
> > On 12/19/2012 08:44 PM, Hugh Dickins wrote:
> >> The rmap walks in ksm.c are like those in rmap.c:
> >> they can safely be done with anon_vma_lock_read().
> >>
> >> Signed-off-by: Hugh Dickins <hughd@google.com>
> >> ---
> >
> > Hi Hugh,
> >
> > This patch didn't fix the ksm oopses I'm seeing.
> >
> > This is with both patches applied:
>
> Looks like another NULL mm pointer in ksmd.. Hugh fixed one in
> 2832bc19f666 ("sched: numa: ksm: fix oops in task_numa_placment()"),
> this looks like more of the same.
>
> At a guess, it looks like get_mergeable_page() has a rmap_item with no
> mm. No idea how that happened. Hugh? Some race due to something that
> depended on the mmap_sem being exclusive, rather than for
> read-ownership?
No, it's just a misunderstanding: Sasha's problem is with a linux-next
that has Petr's NUMA KSM patch in, and we're still ironing known issues
out of that one. Not a problem for 3.8-rc1.
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-12-20 22:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-20 1:42 [PATCH] sched: numa: ksm: fix oops in task_numa_placment() Hugh Dickins
2012-12-20 1:44 ` [PATCH] ksm: make rmap walks more scalable Hugh Dickins
2012-12-20 11:17 ` Mel Gorman
2012-12-20 21:49 ` Sasha Levin
2012-12-20 22:26 ` Linus Torvalds
2012-12-20 22:40 ` Hugh Dickins [this message]
2012-12-20 22:37 ` Hugh Dickins
2012-12-20 22:43 ` Sasha Levin
2012-12-21 0:36 ` Petr Holasek
2012-12-21 2:35 ` Hugh Dickins
2012-12-20 11:14 ` [PATCH] sched: numa: ksm: fix oops in task_numa_placment() Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1212201438190.977@eggly.anvils \
--to=hughd@google.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=pholasek@redhat.com \
--cc=sasha.levin@oracle.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).