Re: [PATCH] mm: fix kerneldoc on mem_cgroup_replace_page

Michal Hocko
2015-12-02T10:17:18Z

On Wed 02-12-15 01:33:03, Hugh Dickins wrote:
> Whoops, I missed removing the kerneldoc comment of the lrucare arg
> removed from mem_cgroup_replace_page; but it's a good comment, keep it.
>
> Signed-off-by: Hugh Dickins <hughd@google.com>

Acked-by: Michal Hocko <mhocko@suse.com>

> ---
>
> mm/memcontrol.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- 4.4-rc3/mm/memcontrol.c 2015-11-15 21:06:56.505752425 -0800
> +++ linux/mm/memcontrol.c 2015-11-30 17:40:42.510193391 -0800
> @@ -5511,11 +5511,11 @@ void mem_cgroup_uncharge_list(struct lis
> * mem_cgroup_replace_page - migrate a charge to another page
> * @oldpage: currently charged page
> * @newpage: page to transfer the charge to
> - * @lrucare: either or both pages might be on the LRU already
> *
> * Migrate the charge from @oldpage to @newpage.
> *
> * Both pages must be locked, @newpage->mapping must be set up.
> + * Either or both pages might be on the LRU already.
> */
> void mem_cgroup_replace_page(struct page *oldpage, struct page *newpage)
> {

--
Michal Hocko
SUSE Labs